From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: Marcelo Schmitt <marcelo.schmitt@analog.com>,
lars@metafoo.de, Michael.Hennerich@analog.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, marcelo.schmitt1@gmail.com,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Add support for AD4000 series
Date: Sat, 13 Apr 2024 17:07:22 +0100 [thread overview]
Message-ID: <20240413170722.44399921@jic23-huawei> (raw)
In-Reply-To: <CAMknhBFoX9mC3F43GSmYZyET9oQvHEB+AAsesZv-aEgFPZPA_w@mail.gmail.com>
> >
> > - Span compression and offset.
> > For non-differential ADCs, enabling the span compression requires an input offset.
> > Link: https://www.analog.com/media/en/technical-documentation/data-sheets/AD4000-4004-4008.pdf
> > page 18
> > and
> > Link: https://www.analog.com/media/en/technical-documentation/data-sheets/ad4002-4006-4010.pdf
> > page 19
> > I updated the _offset attribute for those ADCs according to span compression
> > being enabled or not. Is it okay to have an attribute update cause an update to
> > another one?
Yes. Happens all the time and it's not possible in general to define an ABI where
this doesn't happen on some combinations. scale in particular can be affected in lots
of fun non linear ways by other attributes.
How you handle it is a bit up to the driver writer and interpretation of what is
most natural for a given combination.
Sometimes:
a) Stash previously set value of the other attributes and try to find a new value
as near as possible give constraint of whatever else was just written
b) Just use whatever the register value now corresponds to given the other attribute
changed
Either way userspace needs to take another look at other attributes to see if they
changed after changing anything that might have an influence. It can then update
them however it likes.
> > Maybe also make the span compression a dt property and have it fixed after probe?
>
> This doesn't sound like something that belongs in DT since it doesn't
> depend on the physical properties of what is wired to the input.
>
> But the fact that offset should not be read until after scale is set
> sounds like a quirk that would be worth documenting in some
> chip-specific docs.
Agreed - it is useful to hint at this but in general software has to check
everything as there are lots of these sorts of interactions :(
Jonathan
prev parent reply other threads:[~2024-04-13 16:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 14:30 [PATCH v2 0/2] Add support for AD4000 series Marcelo Schmitt
2024-04-08 14:31 ` [PATCH v2 1/2] dt-bindings: iio: adc: Add AD4000 Marcelo Schmitt
2024-04-09 2:57 ` David Lechner
2024-04-09 15:30 ` Marcelo Schmitt
2024-04-13 16:14 ` Jonathan Cameron
2024-04-13 17:33 ` David Lechner
2024-04-14 18:09 ` Jonathan Cameron
2024-04-16 21:46 ` Marcelo Schmitt
2024-04-20 14:17 ` Jonathan Cameron
2024-04-21 22:38 ` Marcelo Schmitt
2024-04-08 14:31 ` [PATCH v2 2/2] iio: adc: Add support for AD4000 Marcelo Schmitt
2024-04-09 3:05 ` David Lechner
2024-04-09 16:09 ` Marcelo Schmitt
2024-04-09 16:44 ` David Lechner
2024-04-09 18:12 ` Marcelo Schmitt
2024-04-13 16:34 ` Jonathan Cameron
2024-04-13 16:19 ` Jonathan Cameron
2024-04-13 16:39 ` Jonathan Cameron
2024-04-09 2:54 ` [PATCH v2 0/2] Add support for AD4000 series David Lechner
2024-04-09 14:59 ` Marcelo Schmitt
2024-04-09 16:31 ` David Lechner
2024-04-13 16:07 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240413170722.44399921@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.