From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Alisa-Dariana Roman <alisadariana@gmail.com>,
michael.hennerich@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
alexandru.tachici@analog.com, lars@metafoo.de, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
lgirdwood@gmail.com, broonie@kernel.org, andy@kernel.org,
nuno.sa@analog.com, marcelo.schmitt@analog.com,
bigunclemax@gmail.com, dlechner@baylibre.com,
okan.sahin@analog.com, fr0st61te@gmail.com,
alisa.roman@analog.com, marcus.folkesson@gmail.com,
schnelle@linux.ibm.com, liambeguin@gmail.com
Subject: Re: [PATCH v6 5/5] iio: adc: ad7192: Add AD7194 support
Date: Sat, 20 Apr 2024 11:55:15 +0100 [thread overview]
Message-ID: <20240420115457.44f558cf@jic23-huawei> (raw)
In-Reply-To: <CAHp75VctFbys8ARoE9ZqsCSCOYWjsZnR80g+YXstbyzo5r6TYw@mail.gmail.com>
On Wed, 17 Apr 2024 20:06:00 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Wed, Apr 17, 2024 at 8:01 PM Alisa-Dariana Roman
> <alisadariana@gmail.com> wrote:
> >
> > Unlike the other AD719Xs, AD7194 has configurable differential
> > channels. The user can dynamically configure them in the devicetree.
> >
> > Also modify config AD7192 description for better scaling.
>
> ...
>
> > + device_for_each_child_node(dev, child) {
>
> You can use scoped variant AFAIU that's available in Jonathan's tree.
>
> > + *ad7194_channels = ad7194_chan_diff;
> > + ad7194_channels->scan_index = index++;
> > + ret = ad7194_parse_channel(child, ad7194_channels);
> > + if (ret) {
>
> > + fwnode_handle_put(child);
>
> With the above this wouldn't be needed.
>
As it's a minor improvement, and I tend not to like unnecessary
interdependence of series in my tree (until they are in char-misc
and hence no chance of them changing), I'm fine with not using
that new functionality here.
That will change once it's upstream of course!
I will send a pull request to Greg nice and early this cycle
so that should be in my upstream soon.
I'm also fine with you using this if you want to though!
Jonathan
> > + return ret;
> > + }
> > + ad7194_channels++;
> > + }
>
next prev parent reply other threads:[~2024-04-20 10:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 17:00 [PATCH v6 0/5] iio: adc: ad7192: Add AD7194 support Alisa-Dariana Roman
2024-04-17 17:00 ` [PATCH v6 1/5] iio: adc: ad7192: Use standard attribute Alisa-Dariana Roman
2024-04-20 10:37 ` Jonathan Cameron
2024-04-17 17:00 ` [PATCH v6 2/5] dt-bindings: iio: adc: ad7192: Add aincom supply Alisa-Dariana Roman
2024-04-19 21:35 ` Rob Herring
2024-04-17 17:00 ` [PATCH v6 3/5] " Alisa-Dariana Roman
2024-04-17 17:08 ` Andy Shevchenko
2024-04-20 10:42 ` Jonathan Cameron
2024-04-17 17:00 ` [PATCH v6 4/5] dt-bindings: iio: adc: ad7192: Add AD7194 support Alisa-Dariana Roman
2024-04-18 14:40 ` Rob Herring
2024-04-20 10:52 ` Jonathan Cameron
2024-04-17 17:00 ` [PATCH v6 5/5] " Alisa-Dariana Roman
2024-04-17 17:06 ` Andy Shevchenko
2024-04-20 10:55 ` Jonathan Cameron [this message]
2024-04-20 11:02 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240420115457.44f558cf@jic23-huawei \
--to=jic23@kernel.org \
--cc=alexandru.tachici@analog.com \
--cc=alisa.roman@analog.com \
--cc=alisadariana@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=bigunclemax@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=fr0st61te@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=liambeguin@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=marcus.folkesson@gmail.com \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=okan.sahin@analog.com \
--cc=robh@kernel.org \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.