From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7890A625; Sat, 20 Apr 2024 13:06:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713618412; cv=none; b=I4ftQ8+xB2hojlZKW6bjRBQgmEKflof/hzTmIuE+7eLMYbOId7KfGFuKAyNX474MOpUsrgvFtd+8vWSqKj+ZAeB3q7h7hNXYyH768ZJaMhv1FaGRTqGPag8kCKEmGG0Obo6Th7yVXAXhvTA0m4oNVvcRzDYPhcCbaVKVueoGtuA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713618412; c=relaxed/simple; bh=N4vN3xcboLIjcxz6Bmykno3uW1Git1Vd/uH85dY0LS4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KhZRo4qIKXAZbo+hFdGUpig+LvKJh8BMmCp3qwGleuvjgPKbd5540vSpp3Vb+p2/9lG0oJZGFHptpvfRJf5R09ZoAh4fI/mkvjKf+YSpPx9P5LahHK6jkOcV9F2rNpZ21jN1yAUzK8q+xH79MuaT+1xpmdQMlkCPtQtw7+iIe4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QYK0GRP+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QYK0GRP+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11066C072AA; Sat, 20 Apr 2024 13:06:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713618412; bh=N4vN3xcboLIjcxz6Bmykno3uW1Git1Vd/uH85dY0LS4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QYK0GRP+m4Cct/mfSzhcXZFYfRmR4F4A+nQncYRYOW4DLMxbJD1BE6SRBD5xV3Ofe 2AjUjcCbiirX6iZYY4zEy4l2OUgWpnIsAUJlcPCpiHGaKycKG8VBDlILk9ayDo9A6A KDZWM8ASfUMcg0JPPReGhFT20Gsv2bjRw0Y2FAQbWO4ZAWuxirTDbncjL4DkBDEFDk IdLMFknMJUF1YYTiqY1nxHbmhbGEgFW5SzrbAenic1DgQizC4uHO+BO52ZIYKakqvD 0rQeDLmpxu9cMQ5mF/SipssCiD86PA9pQBwYyAIabut3WzfHLti89sxmhG5GLM73FD AXo64nLedJ//A== Date: Sat, 20 Apr 2024 14:06:35 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Aren Moynihan , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Liam Girdwood , Mark Brown , Ondrej Jirman , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , linux-iio@vger.kernel.org, phone-devel@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Willow Barraco Subject: Re: [PATCH 3/4] iio: light: stk3310: log error if reading the chip id fails Message-ID: <20240420140635.6dffa2fb@jic23-huawei> In-Reply-To: References: <20240414175300.956243-1-aren@peacevolution.org> <20240414175716.958831-1-aren@peacevolution.org> <20240414175716.958831-3-aren@peacevolution.org> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 15 Apr 2024 18:05:54 +0300 Andy Shevchenko wrote: > On Sun, Apr 14, 2024 at 8:57=E2=80=AFPM Aren Moynihan wrote: > > > > If the chip isn't powered, this call is likely to return an error. > > Without a log here the driver will silently fail to probe. Common errors > > are ENXIO (when the chip isn't powered) and ETIMEDOUT (when the i2c bus > > isn't powered). =20 >=20 > > ret =3D regmap_read(data->regmap, STK3310_REG_ID, &chipid); > > - if (ret < 0) > > + if (ret < 0) { > > + dev_err(&client->dev, "failed to read chip id: %d", ret= ); > > return ret; > > + } =20 >=20 > Briefly looking at the code it seems that this one is strictly part of > the probe phase, which means we may use >=20 > return dev_err_probe(...); >=20 > pattern. Yet, you may add another patch to clean up all of them: > _probe(), _init(), _regmap_init() to use the same pattern everywhere. >=20 Yes, a precursor patch to use dev_err_probe() throughout the probe only functions in this driver would be excellent. Jonathan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F775C4345F for ; Sat, 20 Apr 2024 13:07:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jRFs9ZOwGmpRK0b3fmOr/xHZiD/bKVH83fNWWibXClc=; b=3hna/j9r1WOCV0 ET4exZHNgal+SwJxE2Y0uu6yxIWJAeoLpR25rSvZSG20/Z3EvlU8/jUid8lIM/HCzEtLrqliROLXk oIiRz5oVW5zghmpflt+5Ic0P3LQ+sMLzhb7QICFywZxD/wLObC4BDKDeSXfukOIGie7hCaQxVn/sY QJh5PAkBtV8bCLWOGTo2X3jgJHKweLW4ekg+YAH0D2pH7+yrMrc73eSNh5tntySLvIg3v8Ylcyfn8 +ka9Mh7wjnRvkpXJN2Cr4gETrBeiPy8NgyUeHYKo9zyJwfc/WplXN/EikO92mbx+R7kBAPaGvKIMB 9RZFe/79JhYFRxolTtmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryAQx-00000008Ww6-04B5; Sat, 20 Apr 2024 13:07:11 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryAQu-00000008WlS-059H for linux-arm-kernel@lists.infradead.org; Sat, 20 Apr 2024 13:07:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E91F4CE17B3; Sat, 20 Apr 2024 13:06:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11066C072AA; Sat, 20 Apr 2024 13:06:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713618412; bh=N4vN3xcboLIjcxz6Bmykno3uW1Git1Vd/uH85dY0LS4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QYK0GRP+m4Cct/mfSzhcXZFYfRmR4F4A+nQncYRYOW4DLMxbJD1BE6SRBD5xV3Ofe 2AjUjcCbiirX6iZYY4zEy4l2OUgWpnIsAUJlcPCpiHGaKycKG8VBDlILk9ayDo9A6A KDZWM8ASfUMcg0JPPReGhFT20Gsv2bjRw0Y2FAQbWO4ZAWuxirTDbncjL4DkBDEFDk IdLMFknMJUF1YYTiqY1nxHbmhbGEgFW5SzrbAenic1DgQizC4uHO+BO52ZIYKakqvD 0rQeDLmpxu9cMQ5mF/SipssCiD86PA9pQBwYyAIabut3WzfHLti89sxmhG5GLM73FD AXo64nLedJ//A== Date: Sat, 20 Apr 2024 14:06:35 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Aren Moynihan , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Liam Girdwood , Mark Brown , Ondrej Jirman , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , linux-iio@vger.kernel.org, phone-devel@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Willow Barraco Subject: Re: [PATCH 3/4] iio: light: stk3310: log error if reading the chip id fails Message-ID: <20240420140635.6dffa2fb@jic23-huawei> In-Reply-To: References: <20240414175300.956243-1-aren@peacevolution.org> <20240414175716.958831-1-aren@peacevolution.org> <20240414175716.958831-3-aren@peacevolution.org> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240420_060708_278429_499BD0E2 X-CRM114-Status: GOOD ( 17.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAxNSBBcHIgMjAyNCAxODowNTo1NCArMDMwMApBbmR5IFNoZXZjaGVua28gPGFuZHku c2hldmNoZW5rb0BnbWFpbC5jb20+IHdyb3RlOgoKPiBPbiBTdW4sIEFwciAxNCwgMjAyNCBhdCA4 OjU34oCvUE0gQXJlbiBNb3luaWhhbiA8YXJlbkBwZWFjZXZvbHV0aW9uLm9yZz4gd3JvdGU6Cj4g Pgo+ID4gSWYgdGhlIGNoaXAgaXNuJ3QgcG93ZXJlZCwgdGhpcyBjYWxsIGlzIGxpa2VseSB0byBy ZXR1cm4gYW4gZXJyb3IuCj4gPiBXaXRob3V0IGEgbG9nIGhlcmUgdGhlIGRyaXZlciB3aWxsIHNp bGVudGx5IGZhaWwgdG8gcHJvYmUuIENvbW1vbiBlcnJvcnMKPiA+IGFyZSBFTlhJTyAod2hlbiB0 aGUgY2hpcCBpc24ndCBwb3dlcmVkKSBhbmQgRVRJTUVET1VUICh3aGVuIHRoZSBpMmMgYnVzCj4g PiBpc24ndCBwb3dlcmVkKS4gIAo+IAo+ID4gICAgICAgICByZXQgPSByZWdtYXBfcmVhZChkYXRh LT5yZWdtYXAsIFNUSzMzMTBfUkVHX0lELCAmY2hpcGlkKTsKPiA+IC0gICAgICAgaWYgKHJldCA8 IDApCj4gPiArICAgICAgIGlmIChyZXQgPCAwKSB7Cj4gPiArICAgICAgICAgICAgICAgZGV2X2Vy cigmY2xpZW50LT5kZXYsICJmYWlsZWQgdG8gcmVhZCBjaGlwIGlkOiAlZCIsIHJldCk7Cj4gPiAg ICAgICAgICAgICAgICAgcmV0dXJuIHJldDsKPiA+ICsgICAgICAgfSAgCj4gCj4gQnJpZWZseSBs b29raW5nIGF0IHRoZSBjb2RlIGl0IHNlZW1zIHRoYXQgdGhpcyBvbmUgaXMgc3RyaWN0bHkgcGFy dCBvZgo+IHRoZSBwcm9iZSBwaGFzZSwgd2hpY2ggbWVhbnMgd2UgbWF5IHVzZQo+IAo+ICAgcmV0 dXJuIGRldl9lcnJfcHJvYmUoLi4uKTsKPiAKPiBwYXR0ZXJuLiBZZXQsIHlvdSBtYXkgYWRkIGFu b3RoZXIgcGF0Y2ggdG8gY2xlYW4gdXAgYWxsIG9mIHRoZW06Cj4gX3Byb2JlKCksIF9pbml0KCks IF9yZWdtYXBfaW5pdCgpIHRvIHVzZSB0aGUgc2FtZSBwYXR0ZXJuIGV2ZXJ5d2hlcmUuCj4gCgpZ ZXMsIGEgcHJlY3Vyc29yIHBhdGNoIHRvIHVzZSBkZXZfZXJyX3Byb2JlKCkgdGhyb3VnaG91dCB0 aGUgcHJvYmUgb25seQpmdW5jdGlvbnMgaW4gdGhpcyBkcml2ZXIgd291bGQgYmUgZXhjZWxsZW50 LgoKSm9uYXRoYW4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK