From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C55B107B2; Sat, 20 Apr 2024 09:11:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713604294; cv=none; b=Fy48uhlfA6rQXRwBe/7xJ1A+SPT7iQ6GlhXZDS+jYjYbIB+mkAH6149Bfl+v+GNbJ3a6tbmDKSQcoHKPsSq0C1ZdvMkNE1HkH+nll2AgdeRwf5vWVz6LJKUASjBxDNiNM9KZmK53cwQVNAD53RUkdcy2KHt0mSz/jkZAzjTCfN4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713604294; c=relaxed/simple; bh=gx+4p/uDBfF9iByUyBCzGltg748yzYFaTBhBB8UsaaI=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=A6Qxdt0AlZnQ2f3oFAxplmICh7d02SlpM8GM6tpCIJu0o5bSf4PZiaxfL/79BMxWNCKNtC/B5xrShbqSSABPNlnZRrSQFY+kHCeJKOwIcmo23PP1fyJ02HovmuRPj1m+tQBVbx1u8eCkaJ1m8j4q6zWhPwg6WAuT+sAUr2zN/2Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WiOFFcIs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WiOFFcIs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72072C072AA; Sat, 20 Apr 2024 09:11:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713604294; bh=gx+4p/uDBfF9iByUyBCzGltg748yzYFaTBhBB8UsaaI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WiOFFcIsUZjqS2Hu+iFB3XXcMZa5pzL1HBjixIci52d8Dz9R1WD9G9VB56jkKYeZ0 yDy0eI1sbeixq6g8aSxoZ6nlN7GVrsoYNR+OtdV5qezCXWWNalxmX0AQMOmxxVvjB8 mDIxwHW3sBjsjL/fldCkVAVACyfuDXihwfUSyE32m5VVdZN1QGS01/8WCa5+GHvn0e eqnq4e8Pva3SV5BNn9cHwpijQL1+svPQU6wcQztqSBwE5iNQ3v/A2Gh1fOxnMqAWe6 p9b3Z1WSt5cu2C+P9w6zBxw+xdBSQlJVW4JFCyv2uFOrSDGSq+nT5wb2kq12tKe8xw OK7o8nQPMJ1wg== Date: Sat, 20 Apr 2024 18:11:21 +0900 From: Masami Hiramatsu (Google) To: Mike Rapoport Cc: Song Liu , Mark Rutland , Peter Zijlstra , linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , Bjorn Topel , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free() Message-Id: <20240420181121.d6c7be11a6f98dc2462f8b41@kernel.org> In-Reply-To: References: X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Sat, 20 Apr 2024 07:22:50 +0300 Mike Rapoport wrote: > On Fri, Apr 19, 2024 at 02:42:16PM -0700, Song Liu wrote: > > On Fri, Apr 19, 2024 at 1:00 PM Mike Rapoport wrote: > > > > > > On Fri, Apr 19, 2024 at 10:32:39AM -0700, Song Liu wrote: > > > > On Fri, Apr 19, 2024 at 10:03 AM Mike Rapoport wrote: > > > > [...] > > > > > > > > > > > > > > [1] https://lore.kernel.org/all/20240411160526.2093408-1-rppt@kernel.org > > > > > > > > > > > > For the ROX to work, we need different users (module text, kprobe, etc.) to have > > > > > > the same execmem_range. From [1]: > > > > > > > > > > > > static void *execmem_cache_alloc(struct execmem_range *range, size_t size) > > > > > > { > > > > > > ... > > > > > > p = __execmem_cache_alloc(size); > > > > > > if (p) > > > > > > return p; > > > > > > err = execmem_cache_populate(range, size); > > > > > > ... > > > > > > } > > > > > > > > > > > > We are calling __execmem_cache_alloc() without range. For this to work, > > > > > > we can only call execmem_cache_alloc() with one execmem_range. > > > > > > > > > > Actually, on x86 this will "just work" because everything shares the same > > > > > address space :) > > > > > > > > > > The 2M pages in the cache will be in the modules space, so > > > > > __execmem_cache_alloc() will always return memory from that address space. > > > > > > > > > > For other architectures this indeed needs to be fixed with passing the > > > > > range to __execmem_cache_alloc() and limiting search in the cache for that > > > > > range. > > > > > > > > I think we at least need the "map to" concept (initially proposed by Thomas) > > > > to get this work. For example, EXECMEM_BPF and EXECMEM_KPROBE > > > > maps to EXECMEM_MODULE_TEXT, so that all these actually share > > > > the same range. > > > > > > Why? > > > > IIUC, we need to update __execmem_cache_alloc() to take a range pointer as > > input. module text will use "range" for EXECMEM_MODULE_TEXT, while kprobe > > will use "range" for EXECMEM_KPROBE. Without "map to" concept or sharing > > the "range" object, we will have to compare different range parameters to check > > we can share cached pages between module text and kprobe, which is not > > efficient. Did I miss something? Song, thanks for trying to eplain. I think I need to explain why I used module_alloc() originally. This depends on how kprobe features are implemented on the architecture, and how much features are supported on kprobes. Because kprobe jump optimization and kprobe jump-back optimization need to use a jump instruction to jump into the trampoline and jump back from the trampoline directly, if the architecuture jmp instruction supports +-2GB range like x86, it needs to allocate the trampoline buffer inside such address space. This requirement is similar to the modules (because module function needs to call other functions in the kernel etc.), at least kprobes on x86 used module_alloc(). However, if an architecture only supports breakpoint/trap based kprobe, it does not need to consider whether the execmem is allocated. > > We can always share large ROX pages as long as they are within the correct > address space. The permissions for them are ROX and the alignment > differences are due to KASAN and this is handled during allocation of the > large page to refill the cache. __execmem_cache_alloc() only needs to limit > the search for the address space of the range. So I don't think EXECMEM_KPROBE always same as EXECMEM_MODULE_TEXT, it should be configured for each arch. Especially, if it is only used for searching parameter, it looks OK to me. Thank you, > > And regardless, they way we deal with sharing of the cache can be sorted > out later. > > > Thanks, > > Song > > -- > Sincerely yours, > Mike. > -- Masami Hiramatsu (Google) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A9AAC4345F for ; Sat, 20 Apr 2024 09:11:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Message-Id:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BoFoEuZBZ2GmgT6nTY1yj8VyWaMDsukznPzPW7inFGs=; b=OlmsyEezt8mlGV 7ZkSvyakzK7jqxpmDU53kWFTEEKhm0TmT+IWac66EE0BwocSwKutCq3UZIiMlo26TROSmZu+z8KoW ieGPTC2cPCnt/yIsIytt7xHokNU6WwVgYNkuuml6H832eBQdGgJaaB6f422J6CrNTrn3U6ZvLdeas zGgvrAS0D1DVsCReAS8T7EH44wQP76ACZE+erTaKNYzzNB+uRZjgffb8Tat2Vqe5dr+imVeIjcReL 2WISOuNeNA9OHXO00sUsRJJCPiFvJDOYeCuNCHHup1XnIfmRKGt4oqisDY22T7nMEIFQOkRanYmzd RODPUb/RAkqbZbMSbtqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ry6l1-00000008A6x-0OVH; Sat, 20 Apr 2024 09:11:39 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ry6kx-00000008A4N-13fA; Sat, 20 Apr 2024 09:11:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9266A60677; Sat, 20 Apr 2024 09:11:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72072C072AA; Sat, 20 Apr 2024 09:11:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713604294; bh=gx+4p/uDBfF9iByUyBCzGltg748yzYFaTBhBB8UsaaI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WiOFFcIsUZjqS2Hu+iFB3XXcMZa5pzL1HBjixIci52d8Dz9R1WD9G9VB56jkKYeZ0 yDy0eI1sbeixq6g8aSxoZ6nlN7GVrsoYNR+OtdV5qezCXWWNalxmX0AQMOmxxVvjB8 mDIxwHW3sBjsjL/fldCkVAVACyfuDXihwfUSyE32m5VVdZN1QGS01/8WCa5+GHvn0e eqnq4e8Pva3SV5BNn9cHwpijQL1+svPQU6wcQztqSBwE5iNQ3v/A2Gh1fOxnMqAWe6 p9b3Z1WSt5cu2C+P9w6zBxw+xdBSQlJVW4JFCyv2uFOrSDGSq+nT5wb2kq12tKe8xw OK7o8nQPMJ1wg== Date: Sat, 20 Apr 2024 18:11:21 +0900 From: Masami Hiramatsu (Google) To: Mike Rapoport Cc: Song Liu , Mark Rutland , Peter Zijlstra , linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , Bjorn Topel , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free() Message-Id: <20240420181121.d6c7be11a6f98dc2462f8b41@kernel.org> In-Reply-To: References: X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240420_021135_430981_1BDF893C X-CRM114-Status: GOOD ( 33.44 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gU2F0LCAyMCBBcHIgMjAyNCAwNzoyMjo1MCArMDMwMApNaWtlIFJhcG9wb3J0IDxycHB0QGtl cm5lbC5vcmc+IHdyb3RlOgoKPiBPbiBGcmksIEFwciAxOSwgMjAyNCBhdCAwMjo0MjoxNlBNIC0w NzAwLCBTb25nIExpdSB3cm90ZToKPiA+IE9uIEZyaSwgQXByIDE5LCAyMDI0IGF0IDE6MDDigK9Q TSBNaWtlIFJhcG9wb3J0IDxycHB0QGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4gPgo+ID4gPiBPbiBG cmksIEFwciAxOSwgMjAyNCBhdCAxMDozMjozOUFNIC0wNzAwLCBTb25nIExpdSB3cm90ZToKPiA+ ID4gPiBPbiBGcmksIEFwciAxOSwgMjAyNCBhdCAxMDowM+KAr0FNIE1pa2UgUmFwb3BvcnQgPHJw cHRAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPiA+ID4gWy4uLl0KPiA+ID4gPiA+ID4gPgo+ID4gPiA+ ID4gPiA+IFsxXSBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvMjAyNDA0MTExNjA1MjYuMjA5 MzQwOC0xLXJwcHRAa2VybmVsLm9yZwo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBGb3IgdGhlIFJP WCB0byB3b3JrLCB3ZSBuZWVkIGRpZmZlcmVudCB1c2VycyAobW9kdWxlIHRleHQsIGtwcm9iZSwg ZXRjLikgdG8gaGF2ZQo+ID4gPiA+ID4gPiB0aGUgc2FtZSBleGVjbWVtX3JhbmdlLiBGcm9tIFsx XToKPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gc3RhdGljIHZvaWQgKmV4ZWNtZW1fY2FjaGVfYWxs b2Moc3RydWN0IGV4ZWNtZW1fcmFuZ2UgKnJhbmdlLCBzaXplX3Qgc2l6ZSkKPiA+ID4gPiA+ID4g ewo+ID4gPiA+ID4gPiAuLi4KPiA+ID4gPiA+ID4gICAgICAgIHAgPSBfX2V4ZWNtZW1fY2FjaGVf YWxsb2Moc2l6ZSk7Cj4gPiA+ID4gPiA+ICAgICAgICBpZiAocCkKPiA+ID4gPiA+ID4gICAgICAg ICAgICAgICAgcmV0dXJuIHA7Cj4gPiA+ID4gPiA+ICAgICAgIGVyciA9IGV4ZWNtZW1fY2FjaGVf cG9wdWxhdGUocmFuZ2UsIHNpemUpOwo+ID4gPiA+ID4gPiAuLi4KPiA+ID4gPiA+ID4gfQo+ID4g PiA+ID4gPgo+ID4gPiA+ID4gPiBXZSBhcmUgY2FsbGluZyBfX2V4ZWNtZW1fY2FjaGVfYWxsb2Mo KSB3aXRob3V0IHJhbmdlLiBGb3IgdGhpcyB0byB3b3JrLAo+ID4gPiA+ID4gPiB3ZSBjYW4gb25s eSBjYWxsIGV4ZWNtZW1fY2FjaGVfYWxsb2MoKSB3aXRoIG9uZSBleGVjbWVtX3JhbmdlLgo+ID4g PiA+ID4KPiA+ID4gPiA+IEFjdHVhbGx5LCBvbiB4ODYgdGhpcyB3aWxsICJqdXN0IHdvcmsiIGJl Y2F1c2UgZXZlcnl0aGluZyBzaGFyZXMgdGhlIHNhbWUKPiA+ID4gPiA+IGFkZHJlc3Mgc3BhY2Ug OikKPiA+ID4gPiA+Cj4gPiA+ID4gPiBUaGUgMk0gcGFnZXMgaW4gdGhlIGNhY2hlIHdpbGwgYmUg aW4gdGhlIG1vZHVsZXMgc3BhY2UsIHNvCj4gPiA+ID4gPiBfX2V4ZWNtZW1fY2FjaGVfYWxsb2Mo KSB3aWxsIGFsd2F5cyByZXR1cm4gbWVtb3J5IGZyb20gdGhhdCBhZGRyZXNzIHNwYWNlLgo+ID4g PiA+ID4KPiA+ID4gPiA+IEZvciBvdGhlciBhcmNoaXRlY3R1cmVzIHRoaXMgaW5kZWVkIG5lZWRz IHRvIGJlIGZpeGVkIHdpdGggcGFzc2luZyB0aGUKPiA+ID4gPiA+IHJhbmdlIHRvIF9fZXhlY21l bV9jYWNoZV9hbGxvYygpIGFuZCBsaW1pdGluZyBzZWFyY2ggaW4gdGhlIGNhY2hlIGZvciB0aGF0 Cj4gPiA+ID4gPiByYW5nZS4KPiA+ID4gPgo+ID4gPiA+IEkgdGhpbmsgd2UgYXQgbGVhc3QgbmVl ZCB0aGUgIm1hcCB0byIgY29uY2VwdCAoaW5pdGlhbGx5IHByb3Bvc2VkIGJ5IFRob21hcykKPiA+ ID4gPiB0byBnZXQgdGhpcyB3b3JrLiBGb3IgZXhhbXBsZSwgRVhFQ01FTV9CUEYgYW5kIEVYRUNN RU1fS1BST0JFCj4gPiA+ID4gbWFwcyB0byBFWEVDTUVNX01PRFVMRV9URVhULCBzbyB0aGF0IGFs bCB0aGVzZSBhY3R1YWxseSBzaGFyZQo+ID4gPiA+IHRoZSBzYW1lIHJhbmdlLgo+ID4gPgo+ID4g PiBXaHk/Cj4gPiAKPiA+IElJVUMsIHdlIG5lZWQgdG8gdXBkYXRlIF9fZXhlY21lbV9jYWNoZV9h bGxvYygpIHRvIHRha2UgYSByYW5nZSBwb2ludGVyIGFzCj4gPiBpbnB1dC4gbW9kdWxlIHRleHQg d2lsbCB1c2UgInJhbmdlIiBmb3IgRVhFQ01FTV9NT0RVTEVfVEVYVCwgd2hpbGUga3Byb2JlCj4g PiB3aWxsIHVzZSAicmFuZ2UiIGZvciBFWEVDTUVNX0tQUk9CRS4gV2l0aG91dCAibWFwIHRvIiBj b25jZXB0IG9yIHNoYXJpbmcKPiA+IHRoZSAicmFuZ2UiIG9iamVjdCwgd2Ugd2lsbCBoYXZlIHRv IGNvbXBhcmUgZGlmZmVyZW50IHJhbmdlIHBhcmFtZXRlcnMgdG8gY2hlY2sKPiA+IHdlIGNhbiBz aGFyZSBjYWNoZWQgcGFnZXMgYmV0d2VlbiBtb2R1bGUgdGV4dCBhbmQga3Byb2JlLCB3aGljaCBp cyBub3QKPiA+IGVmZmljaWVudC4gRGlkIEkgbWlzcyBzb21ldGhpbmc/CgpTb25nLCB0aGFua3Mg Zm9yIHRyeWluZyB0byBlcGxhaW4uIEkgdGhpbmsgSSBuZWVkIHRvIGV4cGxhaW4gd2h5IEkgdXNl ZAptb2R1bGVfYWxsb2MoKSBvcmlnaW5hbGx5LgoKVGhpcyBkZXBlbmRzIG9uIGhvdyBrcHJvYmUg ZmVhdHVyZXMgYXJlIGltcGxlbWVudGVkIG9uIHRoZSBhcmNoaXRlY3R1cmUsIGFuZApob3cgbXVj aCBmZWF0dXJlcyBhcmUgc3VwcG9ydGVkIG9uIGtwcm9iZXMuCgpCZWNhdXNlIGtwcm9iZSBqdW1w IG9wdGltaXphdGlvbiBhbmQga3Byb2JlIGp1bXAtYmFjayBvcHRpbWl6YXRpb24gbmVlZCB0bwp1 c2UgYSBqdW1wIGluc3RydWN0aW9uIHRvIGp1bXAgaW50byB0aGUgdHJhbXBvbGluZSBhbmQganVt cCBiYWNrIGZyb20gdGhlCnRyYW1wb2xpbmUgZGlyZWN0bHksIGlmIHRoZSBhcmNoaXRlY3V0dXJl IGptcCBpbnN0cnVjdGlvbiBzdXBwb3J0cyArLTJHQiByYW5nZQpsaWtlIHg4NiwgaXQgbmVlZHMg dG8gYWxsb2NhdGUgdGhlIHRyYW1wb2xpbmUgYnVmZmVyIGluc2lkZSBzdWNoIGFkZHJlc3Mgc3Bh Y2UuClRoaXMgcmVxdWlyZW1lbnQgaXMgc2ltaWxhciB0byB0aGUgbW9kdWxlcyAoYmVjYXVzZSBt b2R1bGUgZnVuY3Rpb24gbmVlZHMgdG8KY2FsbCBvdGhlciBmdW5jdGlvbnMgaW4gdGhlIGtlcm5l bCBldGMuKSwgYXQgbGVhc3Qga3Byb2JlcyBvbiB4ODYgdXNlZAptb2R1bGVfYWxsb2MoKS4KCkhv d2V2ZXIsIGlmIGFuIGFyY2hpdGVjdHVyZSBvbmx5IHN1cHBvcnRzIGJyZWFrcG9pbnQvdHJhcCBi YXNlZCBrcHJvYmUsCml0IGRvZXMgbm90IG5lZWQgdG8gY29uc2lkZXIgd2hldGhlciB0aGUgZXhl Y21lbSBpcyBhbGxvY2F0ZWQuCgo+IAo+IFdlIGNhbiBhbHdheXMgc2hhcmUgbGFyZ2UgUk9YIHBh Z2VzIGFzIGxvbmcgYXMgdGhleSBhcmUgd2l0aGluIHRoZSBjb3JyZWN0Cj4gYWRkcmVzcyBzcGFj ZS4gVGhlIHBlcm1pc3Npb25zIGZvciB0aGVtIGFyZSBST1ggYW5kIHRoZSBhbGlnbm1lbnQKPiBk aWZmZXJlbmNlcyBhcmUgZHVlIHRvIEtBU0FOIGFuZCB0aGlzIGlzIGhhbmRsZWQgZHVyaW5nIGFs bG9jYXRpb24gb2YgdGhlCj4gbGFyZ2UgcGFnZSB0byByZWZpbGwgdGhlIGNhY2hlLiBfX2V4ZWNt ZW1fY2FjaGVfYWxsb2MoKSBvbmx5IG5lZWRzIHRvIGxpbWl0Cj4gdGhlIHNlYXJjaCBmb3IgdGhl IGFkZHJlc3Mgc3BhY2Ugb2YgdGhlIHJhbmdlLgoKU28gSSBkb24ndCB0aGluayBFWEVDTUVNX0tQ Uk9CRSBhbHdheXMgc2FtZSBhcyBFWEVDTUVNX01PRFVMRV9URVhULCBpdApzaG91bGQgYmUgY29u ZmlndXJlZCBmb3IgZWFjaCBhcmNoLiBFc3BlY2lhbGx5LCBpZiBpdCBpcyBvbmx5IHVzZWQgZm9y CnNlYXJjaGluZyBwYXJhbWV0ZXIsIGl0IGxvb2tzIE9LIHRvIG1lLgoKVGhhbmsgeW91LAoKPiAK PiBBbmQgcmVnYXJkbGVzcywgdGhleSB3YXkgd2UgZGVhbCB3aXRoIHNoYXJpbmcgb2YgdGhlIGNh Y2hlIGNhbiBiZSBzb3J0ZWQKPiBvdXQgbGF0ZXIuCj4gCj4gPiBUaGFua3MsCj4gPiBTb25nCj4g Cj4gLS0gCj4gU2luY2VyZWx5IHlvdXJzLAo+IE1pa2UuCj4gCgoKLS0gCk1hc2FtaSBIaXJhbWF0 c3UgKEdvb2dsZSkgPG1oaXJhbWF0QGtlcm5lbC5vcmc+CgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgt cmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67E7FC001CC for ; Sat, 20 Apr 2024 09:11:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Message-Id:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7iAWzEJYb+/pn0QHpbTOhAel6Pl9UwEeVf0AZG9qqmg=; b=AOpbrLob9CneM9 yRMwWjzWXHEGsHsGaoOj6NRsv+fAcZWgkHVUgLomg+JqX0uBB4bNnIgWC6rcX7MvQ1MzVVTO3f3pq 4oO6cjc3LWKc/rL+FXelhels6v1IaEYd0DzSQ35sXnEtHEgJ1JSSlDgkiLgeJJLJ++A0bFYN3XluD IvDqkKPMjVAXdycWocCWOmo9dWUiFXQdPiFyVOW6lW4yAfSL4OQ8kR5/EE7OCGGHF3EPeemzXEVki 50KexqxIsFg+pAk2aO3EQ25hHN4MAV8708Fg7PkUVZSJt9GoZ7JsugLH/WMwH9oUphUqQg3Lf8VNA JWBtDjqkCIrnl5iSRseQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ry6l0-00000008A6f-1Zlt; Sat, 20 Apr 2024 09:11:38 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ry6kx-00000008A4N-13fA; Sat, 20 Apr 2024 09:11:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9266A60677; Sat, 20 Apr 2024 09:11:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72072C072AA; Sat, 20 Apr 2024 09:11:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713604294; bh=gx+4p/uDBfF9iByUyBCzGltg748yzYFaTBhBB8UsaaI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WiOFFcIsUZjqS2Hu+iFB3XXcMZa5pzL1HBjixIci52d8Dz9R1WD9G9VB56jkKYeZ0 yDy0eI1sbeixq6g8aSxoZ6nlN7GVrsoYNR+OtdV5qezCXWWNalxmX0AQMOmxxVvjB8 mDIxwHW3sBjsjL/fldCkVAVACyfuDXihwfUSyE32m5VVdZN1QGS01/8WCa5+GHvn0e eqnq4e8Pva3SV5BNn9cHwpijQL1+svPQU6wcQztqSBwE5iNQ3v/A2Gh1fOxnMqAWe6 p9b3Z1WSt5cu2C+P9w6zBxw+xdBSQlJVW4JFCyv2uFOrSDGSq+nT5wb2kq12tKe8xw OK7o8nQPMJ1wg== Date: Sat, 20 Apr 2024 18:11:21 +0900 From: Masami Hiramatsu (Google) To: Mike Rapoport Cc: Song Liu , Mark Rutland , Peter Zijlstra , linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , Bjorn Topel , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free() Message-Id: <20240420181121.d6c7be11a6f98dc2462f8b41@kernel.org> In-Reply-To: References: X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240420_021135_430981_1BDF893C X-CRM114-Status: GOOD ( 33.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCAyMCBBcHIgMjAyNCAwNzoyMjo1MCArMDMwMApNaWtlIFJhcG9wb3J0IDxycHB0QGtl cm5lbC5vcmc+IHdyb3RlOgoKPiBPbiBGcmksIEFwciAxOSwgMjAyNCBhdCAwMjo0MjoxNlBNIC0w NzAwLCBTb25nIExpdSB3cm90ZToKPiA+IE9uIEZyaSwgQXByIDE5LCAyMDI0IGF0IDE6MDDigK9Q TSBNaWtlIFJhcG9wb3J0IDxycHB0QGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4gPgo+ID4gPiBPbiBG cmksIEFwciAxOSwgMjAyNCBhdCAxMDozMjozOUFNIC0wNzAwLCBTb25nIExpdSB3cm90ZToKPiA+ ID4gPiBPbiBGcmksIEFwciAxOSwgMjAyNCBhdCAxMDowM+KAr0FNIE1pa2UgUmFwb3BvcnQgPHJw cHRAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPiA+ID4gWy4uLl0KPiA+ID4gPiA+ID4gPgo+ID4gPiA+ ID4gPiA+IFsxXSBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvMjAyNDA0MTExNjA1MjYuMjA5 MzQwOC0xLXJwcHRAa2VybmVsLm9yZwo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBGb3IgdGhlIFJP WCB0byB3b3JrLCB3ZSBuZWVkIGRpZmZlcmVudCB1c2VycyAobW9kdWxlIHRleHQsIGtwcm9iZSwg ZXRjLikgdG8gaGF2ZQo+ID4gPiA+ID4gPiB0aGUgc2FtZSBleGVjbWVtX3JhbmdlLiBGcm9tIFsx XToKPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gc3RhdGljIHZvaWQgKmV4ZWNtZW1fY2FjaGVfYWxs b2Moc3RydWN0IGV4ZWNtZW1fcmFuZ2UgKnJhbmdlLCBzaXplX3Qgc2l6ZSkKPiA+ID4gPiA+ID4g ewo+ID4gPiA+ID4gPiAuLi4KPiA+ID4gPiA+ID4gICAgICAgIHAgPSBfX2V4ZWNtZW1fY2FjaGVf YWxsb2Moc2l6ZSk7Cj4gPiA+ID4gPiA+ICAgICAgICBpZiAocCkKPiA+ID4gPiA+ID4gICAgICAg ICAgICAgICAgcmV0dXJuIHA7Cj4gPiA+ID4gPiA+ICAgICAgIGVyciA9IGV4ZWNtZW1fY2FjaGVf cG9wdWxhdGUocmFuZ2UsIHNpemUpOwo+ID4gPiA+ID4gPiAuLi4KPiA+ID4gPiA+ID4gfQo+ID4g PiA+ID4gPgo+ID4gPiA+ID4gPiBXZSBhcmUgY2FsbGluZyBfX2V4ZWNtZW1fY2FjaGVfYWxsb2Mo KSB3aXRob3V0IHJhbmdlLiBGb3IgdGhpcyB0byB3b3JrLAo+ID4gPiA+ID4gPiB3ZSBjYW4gb25s eSBjYWxsIGV4ZWNtZW1fY2FjaGVfYWxsb2MoKSB3aXRoIG9uZSBleGVjbWVtX3JhbmdlLgo+ID4g PiA+ID4KPiA+ID4gPiA+IEFjdHVhbGx5LCBvbiB4ODYgdGhpcyB3aWxsICJqdXN0IHdvcmsiIGJl Y2F1c2UgZXZlcnl0aGluZyBzaGFyZXMgdGhlIHNhbWUKPiA+ID4gPiA+IGFkZHJlc3Mgc3BhY2Ug OikKPiA+ID4gPiA+Cj4gPiA+ID4gPiBUaGUgMk0gcGFnZXMgaW4gdGhlIGNhY2hlIHdpbGwgYmUg aW4gdGhlIG1vZHVsZXMgc3BhY2UsIHNvCj4gPiA+ID4gPiBfX2V4ZWNtZW1fY2FjaGVfYWxsb2Mo KSB3aWxsIGFsd2F5cyByZXR1cm4gbWVtb3J5IGZyb20gdGhhdCBhZGRyZXNzIHNwYWNlLgo+ID4g PiA+ID4KPiA+ID4gPiA+IEZvciBvdGhlciBhcmNoaXRlY3R1cmVzIHRoaXMgaW5kZWVkIG5lZWRz IHRvIGJlIGZpeGVkIHdpdGggcGFzc2luZyB0aGUKPiA+ID4gPiA+IHJhbmdlIHRvIF9fZXhlY21l bV9jYWNoZV9hbGxvYygpIGFuZCBsaW1pdGluZyBzZWFyY2ggaW4gdGhlIGNhY2hlIGZvciB0aGF0 Cj4gPiA+ID4gPiByYW5nZS4KPiA+ID4gPgo+ID4gPiA+IEkgdGhpbmsgd2UgYXQgbGVhc3QgbmVl ZCB0aGUgIm1hcCB0byIgY29uY2VwdCAoaW5pdGlhbGx5IHByb3Bvc2VkIGJ5IFRob21hcykKPiA+ ID4gPiB0byBnZXQgdGhpcyB3b3JrLiBGb3IgZXhhbXBsZSwgRVhFQ01FTV9CUEYgYW5kIEVYRUNN RU1fS1BST0JFCj4gPiA+ID4gbWFwcyB0byBFWEVDTUVNX01PRFVMRV9URVhULCBzbyB0aGF0IGFs bCB0aGVzZSBhY3R1YWxseSBzaGFyZQo+ID4gPiA+IHRoZSBzYW1lIHJhbmdlLgo+ID4gPgo+ID4g PiBXaHk/Cj4gPiAKPiA+IElJVUMsIHdlIG5lZWQgdG8gdXBkYXRlIF9fZXhlY21lbV9jYWNoZV9h bGxvYygpIHRvIHRha2UgYSByYW5nZSBwb2ludGVyIGFzCj4gPiBpbnB1dC4gbW9kdWxlIHRleHQg d2lsbCB1c2UgInJhbmdlIiBmb3IgRVhFQ01FTV9NT0RVTEVfVEVYVCwgd2hpbGUga3Byb2JlCj4g PiB3aWxsIHVzZSAicmFuZ2UiIGZvciBFWEVDTUVNX0tQUk9CRS4gV2l0aG91dCAibWFwIHRvIiBj b25jZXB0IG9yIHNoYXJpbmcKPiA+IHRoZSAicmFuZ2UiIG9iamVjdCwgd2Ugd2lsbCBoYXZlIHRv IGNvbXBhcmUgZGlmZmVyZW50IHJhbmdlIHBhcmFtZXRlcnMgdG8gY2hlY2sKPiA+IHdlIGNhbiBz aGFyZSBjYWNoZWQgcGFnZXMgYmV0d2VlbiBtb2R1bGUgdGV4dCBhbmQga3Byb2JlLCB3aGljaCBp cyBub3QKPiA+IGVmZmljaWVudC4gRGlkIEkgbWlzcyBzb21ldGhpbmc/CgpTb25nLCB0aGFua3Mg Zm9yIHRyeWluZyB0byBlcGxhaW4uIEkgdGhpbmsgSSBuZWVkIHRvIGV4cGxhaW4gd2h5IEkgdXNl ZAptb2R1bGVfYWxsb2MoKSBvcmlnaW5hbGx5LgoKVGhpcyBkZXBlbmRzIG9uIGhvdyBrcHJvYmUg ZmVhdHVyZXMgYXJlIGltcGxlbWVudGVkIG9uIHRoZSBhcmNoaXRlY3R1cmUsIGFuZApob3cgbXVj aCBmZWF0dXJlcyBhcmUgc3VwcG9ydGVkIG9uIGtwcm9iZXMuCgpCZWNhdXNlIGtwcm9iZSBqdW1w IG9wdGltaXphdGlvbiBhbmQga3Byb2JlIGp1bXAtYmFjayBvcHRpbWl6YXRpb24gbmVlZCB0bwp1 c2UgYSBqdW1wIGluc3RydWN0aW9uIHRvIGp1bXAgaW50byB0aGUgdHJhbXBvbGluZSBhbmQganVt cCBiYWNrIGZyb20gdGhlCnRyYW1wb2xpbmUgZGlyZWN0bHksIGlmIHRoZSBhcmNoaXRlY3V0dXJl IGptcCBpbnN0cnVjdGlvbiBzdXBwb3J0cyArLTJHQiByYW5nZQpsaWtlIHg4NiwgaXQgbmVlZHMg dG8gYWxsb2NhdGUgdGhlIHRyYW1wb2xpbmUgYnVmZmVyIGluc2lkZSBzdWNoIGFkZHJlc3Mgc3Bh Y2UuClRoaXMgcmVxdWlyZW1lbnQgaXMgc2ltaWxhciB0byB0aGUgbW9kdWxlcyAoYmVjYXVzZSBt b2R1bGUgZnVuY3Rpb24gbmVlZHMgdG8KY2FsbCBvdGhlciBmdW5jdGlvbnMgaW4gdGhlIGtlcm5l bCBldGMuKSwgYXQgbGVhc3Qga3Byb2JlcyBvbiB4ODYgdXNlZAptb2R1bGVfYWxsb2MoKS4KCkhv d2V2ZXIsIGlmIGFuIGFyY2hpdGVjdHVyZSBvbmx5IHN1cHBvcnRzIGJyZWFrcG9pbnQvdHJhcCBi YXNlZCBrcHJvYmUsCml0IGRvZXMgbm90IG5lZWQgdG8gY29uc2lkZXIgd2hldGhlciB0aGUgZXhl Y21lbSBpcyBhbGxvY2F0ZWQuCgo+IAo+IFdlIGNhbiBhbHdheXMgc2hhcmUgbGFyZ2UgUk9YIHBh Z2VzIGFzIGxvbmcgYXMgdGhleSBhcmUgd2l0aGluIHRoZSBjb3JyZWN0Cj4gYWRkcmVzcyBzcGFj ZS4gVGhlIHBlcm1pc3Npb25zIGZvciB0aGVtIGFyZSBST1ggYW5kIHRoZSBhbGlnbm1lbnQKPiBk aWZmZXJlbmNlcyBhcmUgZHVlIHRvIEtBU0FOIGFuZCB0aGlzIGlzIGhhbmRsZWQgZHVyaW5nIGFs bG9jYXRpb24gb2YgdGhlCj4gbGFyZ2UgcGFnZSB0byByZWZpbGwgdGhlIGNhY2hlLiBfX2V4ZWNt ZW1fY2FjaGVfYWxsb2MoKSBvbmx5IG5lZWRzIHRvIGxpbWl0Cj4gdGhlIHNlYXJjaCBmb3IgdGhl IGFkZHJlc3Mgc3BhY2Ugb2YgdGhlIHJhbmdlLgoKU28gSSBkb24ndCB0aGluayBFWEVDTUVNX0tQ Uk9CRSBhbHdheXMgc2FtZSBhcyBFWEVDTUVNX01PRFVMRV9URVhULCBpdApzaG91bGQgYmUgY29u ZmlndXJlZCBmb3IgZWFjaCBhcmNoLiBFc3BlY2lhbGx5LCBpZiBpdCBpcyBvbmx5IHVzZWQgZm9y CnNlYXJjaGluZyBwYXJhbWV0ZXIsIGl0IGxvb2tzIE9LIHRvIG1lLgoKVGhhbmsgeW91LAoKPiAK PiBBbmQgcmVnYXJkbGVzcywgdGhleSB3YXkgd2UgZGVhbCB3aXRoIHNoYXJpbmcgb2YgdGhlIGNh Y2hlIGNhbiBiZSBzb3J0ZWQKPiBvdXQgbGF0ZXIuCj4gCj4gPiBUaGFua3MsCj4gPiBTb25nCj4g Cj4gLS0gCj4gU2luY2VyZWx5IHlvdXJzLAo+IE1pa2UuCj4gCgoKLS0gCk1hc2FtaSBIaXJhbWF0 c3UgKEdvb2dsZSkgPG1oaXJhbWF0QGtlcm5lbC5vcmc+CgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10AFBC4345F for ; Sat, 20 Apr 2024 09:12:22 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=WiOFFcIs; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VM5Pd4lKbz3cPl for ; Sat, 20 Apr 2024 19:12:21 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=WiOFFcIs; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=mhiramat@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VM5Nq113jz3bsT for ; Sat, 20 Apr 2024 19:11:39 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9266A60677; Sat, 20 Apr 2024 09:11:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72072C072AA; Sat, 20 Apr 2024 09:11:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713604294; bh=gx+4p/uDBfF9iByUyBCzGltg748yzYFaTBhBB8UsaaI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WiOFFcIsUZjqS2Hu+iFB3XXcMZa5pzL1HBjixIci52d8Dz9R1WD9G9VB56jkKYeZ0 yDy0eI1sbeixq6g8aSxoZ6nlN7GVrsoYNR+OtdV5qezCXWWNalxmX0AQMOmxxVvjB8 mDIxwHW3sBjsjL/fldCkVAVACyfuDXihwfUSyE32m5VVdZN1QGS01/8WCa5+GHvn0e eqnq4e8Pva3SV5BNn9cHwpijQL1+svPQU6wcQztqSBwE5iNQ3v/A2Gh1fOxnMqAWe6 p9b3Z1WSt5cu2C+P9w6zBxw+xdBSQlJVW4JFCyv2uFOrSDGSq+nT5wb2kq12tKe8xw OK7o8nQPMJ1wg== Date: Sat, 20 Apr 2024 18:11:21 +0900 From: Masami Hiramatsu (Google) To: Mike Rapoport Subject: Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free() Message-Id: <20240420181121.d6c7be11a6f98dc2462f8b41@kernel.org> In-Reply-To: References: X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , x86@kernel.org, Peter Zijlstra , Catalin Marinas , Russell King , Song Liu , Donald Dutile , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Nadav Amit , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Helge Deller , Huacai Chen , Luis Chamberlain , linux-mips@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Alexandre Ghiti , Will Deacon , Heiko Carstens , Steven Rostedt , loongarch@lists.linux.dev, Thomas Gleixner , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , linux-parisc@vger.kernel.org, Puranjay Mohan , linux-mm@kvack.org, netdev@vger.kernel.org, Ken t Overstreet , linux-kernel@vger.kernel.org, Dinh Nguyen , Bjorn Topel , Eric Chanudet , Palmer Dabbelt , Andrew Morton , Rick Edgecombe , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , linux-modules@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, 20 Apr 2024 07:22:50 +0300 Mike Rapoport wrote: > On Fri, Apr 19, 2024 at 02:42:16PM -0700, Song Liu wrote: > > On Fri, Apr 19, 2024 at 1:00 PM Mike Rapoport wrote: > > > > > > On Fri, Apr 19, 2024 at 10:32:39AM -0700, Song Liu wrote: > > > > On Fri, Apr 19, 2024 at 10:03 AM Mike Rapoport wrote: > > > > [...] > > > > > > > > > > > > > > [1] https://lore.kernel.org/all/20240411160526.2093408-1-rppt@kernel.org > > > > > > > > > > > > For the ROX to work, we need different users (module text, kprobe, etc.) to have > > > > > > the same execmem_range. From [1]: > > > > > > > > > > > > static void *execmem_cache_alloc(struct execmem_range *range, size_t size) > > > > > > { > > > > > > ... > > > > > > p = __execmem_cache_alloc(size); > > > > > > if (p) > > > > > > return p; > > > > > > err = execmem_cache_populate(range, size); > > > > > > ... > > > > > > } > > > > > > > > > > > > We are calling __execmem_cache_alloc() without range. For this to work, > > > > > > we can only call execmem_cache_alloc() with one execmem_range. > > > > > > > > > > Actually, on x86 this will "just work" because everything shares the same > > > > > address space :) > > > > > > > > > > The 2M pages in the cache will be in the modules space, so > > > > > __execmem_cache_alloc() will always return memory from that address space. > > > > > > > > > > For other architectures this indeed needs to be fixed with passing the > > > > > range to __execmem_cache_alloc() and limiting search in the cache for that > > > > > range. > > > > > > > > I think we at least need the "map to" concept (initially proposed by Thomas) > > > > to get this work. For example, EXECMEM_BPF and EXECMEM_KPROBE > > > > maps to EXECMEM_MODULE_TEXT, so that all these actually share > > > > the same range. > > > > > > Why? > > > > IIUC, we need to update __execmem_cache_alloc() to take a range pointer as > > input. module text will use "range" for EXECMEM_MODULE_TEXT, while kprobe > > will use "range" for EXECMEM_KPROBE. Without "map to" concept or sharing > > the "range" object, we will have to compare different range parameters to check > > we can share cached pages between module text and kprobe, which is not > > efficient. Did I miss something? Song, thanks for trying to eplain. I think I need to explain why I used module_alloc() originally. This depends on how kprobe features are implemented on the architecture, and how much features are supported on kprobes. Because kprobe jump optimization and kprobe jump-back optimization need to use a jump instruction to jump into the trampoline and jump back from the trampoline directly, if the architecuture jmp instruction supports +-2GB range like x86, it needs to allocate the trampoline buffer inside such address space. This requirement is similar to the modules (because module function needs to call other functions in the kernel etc.), at least kprobes on x86 used module_alloc(). However, if an architecture only supports breakpoint/trap based kprobe, it does not need to consider whether the execmem is allocated. > > We can always share large ROX pages as long as they are within the correct > address space. The permissions for them are ROX and the alignment > differences are due to KASAN and this is handled during allocation of the > large page to refill the cache. __execmem_cache_alloc() only needs to limit > the search for the address space of the range. So I don't think EXECMEM_KPROBE always same as EXECMEM_MODULE_TEXT, it should be configured for each arch. Especially, if it is only used for searching parameter, it looks OK to me. Thank you, > > And regardless, they way we deal with sharing of the cache can be sorted > out later. > > > Thanks, > > Song > > -- > Sincerely yours, > Mike. > -- Masami Hiramatsu (Google)