From: Heiner Kallweit <hkallweit1@gmail.com>
To: renjun wang <renjunw0@foxmail.com>,
andrew@lunn.ch, linux@armlinux.org.uk
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: update fields of mii_ioctl_data for transferring C45 data.
Date: Sat, 20 Apr 2024 10:00:54 +0200 [thread overview]
Message-ID: <2e81babf-2a69-4b41-9b34-6e8ed742b2c1@gmail.com> (raw)
In-Reply-To: <tencent_78F3412B4E523FEC8F19FADAC32475318706@qq.com>
On 20.04.2024 02:41, renjun wang wrote:
> The phy_id is used as u32 type in function mdio_phy_id_is_c45()
> with the 30th bit for distinguishing C22 and C45. The reg_num is
> also used as u32 type in function mdiobus_c45_read() or someplace
> else. For more C45 information needed and data structure alignment
> consideration, change these two fields to __u32 type which can make
What do you mean with alignment consideration?
> user space program transferring clause 45 type information to kernel
> directly.
>
With this change you break userspace. And in general: If you make
such a change, you should also use it.
> Signed-off-by: renjun wang <renjunw0@foxmail.com>
> ---
> include/uapi/linux/mii.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/mii.h b/include/uapi/linux/mii.h
> index 39f7c44baf53..68c085b049de 100644
> --- a/include/uapi/linux/mii.h
> +++ b/include/uapi/linux/mii.h
> @@ -176,8 +176,8 @@
>
> /* This structure is used in all SIOCxMIIxxx ioctl calls */
> struct mii_ioctl_data {
> - __u16 phy_id;
> - __u16 reg_num;
> + __u32 phy_id;
> + __u32 reg_num;
> __u16 val_in;
> __u16 val_out;
> };
next prev parent reply other threads:[~2024-04-20 8:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 0:41 [PATCH] net: phy: update fields of mii_ioctl_data for transferring C45 data renjun wang
2024-04-20 8:00 ` Heiner Kallweit [this message]
2024-04-20 8:37 ` Russell King (Oracle)
2024-04-20 14:17 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e81babf-2a69-4b41-9b34-6e8ed742b2c1@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=renjunw0@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.