From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7742C4345F for ; Sun, 21 Apr 2024 08:54:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DLAXbGwUeVR/fLMhBqBgQRpzq3dXy2dZFuqxONOq6ZI=; b=4q21UPnDzfAYB1 5Cv2ermQ0whtDL9kHnD7xitf/UUQIqCPaGa/gsf9yp8+kCLqg6NIE2SLjLkqIqG9Pc/V5HQyKlurf dNaPKXIoRUS60TxQTt7CNxJUCiauMTx8GiaoMZzlh2jF4/30EuYoQ9EmXZR6qmiG1nYskmes8xCwh a7m2E8QLxAMALt3iNgG//RL+FYown18U0e6zIBh7c1TPd50A+fg1o6ULIAyM7QKB/f2HcS4FTc+Dx zntR7g0tNi3mMZVDkhG4C7Nfj9XoLQQ7PNZ8zWnrwCk+Lkx8LtC3TFylrKURca6gvvWCxqUa/j6Gq TfMGP8cBNQODGHkicMIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rySxe-0000000A9cX-33ZS; Sun, 21 Apr 2024 08:54:10 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rySxb-0000000A9be-0ZGY for linux-arm-kernel@lists.infradead.org; Sun, 21 Apr 2024 08:54:08 +0000 Received: from [192.168.1.105] (unknown [103.251.226.10]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 15482674; Sun, 21 Apr 2024 10:53:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1713689592; bh=eaVJSKc5oCRD99pk5u5bgQtIJBks9d5keyCfCBN20Fg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Y5fm++7fhszfF+0TYufHuIjCh8LCZLTtTBbuLgRQplSLqLlZqxlvKCW6T+bEsm17O S++stCD6Z425p+jDWzJbXJI9NZ7DtpeG8HJI9FhclB1vgpmpZJe85fIkMlDwY96/EB tlX6Hck7/obF3q2eak+HSeFDUBWEuDTfWLJ6+eYc= Message-ID: <6b83abcf-5cb1-4e61-b839-b4d51abda18a@ideasonboard.com> Date: Sun, 21 Apr 2024 14:23:54 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] staging: vchiq_core: Use printk messages for devices Content-Language: en-US To: Stefan Wahren , Greg Kroah-Hartman , Florian Fainelli Cc: Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org References: <20240420115351.27713-1-wahrenst@gmx.net> <20240420115351.27713-2-wahrenst@gmx.net> From: Umang Jain In-Reply-To: <20240420115351.27713-2-wahrenst@gmx.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240421_015407_421480_EAFB40B5 X-CRM114-Status: GOOD ( 12.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stefan, Thank you for the patch On 20/04/24 5:23 pm, Stefan Wahren wrote: > Now that struct vchiq_state has a device reference, we can convert > the remaining printk message helpers. > > Signed-off-by: Stefan Wahren Reviewed-by: Umang Jain > --- > .../vc04_services/interface/vchiq_arm/vchiq_core.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > index 3397365e551e..129d73fec2bf 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > @@ -697,7 +697,8 @@ reserve_space(struct vchiq_state *state, size_t space, int is_blocking) > > if (tx_pos == (state->slot_queue_available * VCHIQ_SLOT_SIZE)) { > complete(&state->slot_available_event); > - pr_warn("%s: invalid tx_pos: %d\n", __func__, tx_pos); > + dev_warn(state->dev, "%s: invalid tx_pos: %d\n", > + __func__, tx_pos); > return NULL; > } > > @@ -1732,10 +1733,9 @@ parse_message(struct vchiq_state *state, struct vchiq_header *header) > break; > } > if (queue->process != queue->remote_insert) { > - pr_err("%s: p %x != ri %x\n", > - __func__, > - queue->process, > - queue->remote_insert); > + dev_err(state->dev, "%s: p %x != ri %x\n", > + __func__, queue->process, > + queue->remote_insert); > mutex_unlock(&service->bulk_mutex); > goto bail_not_ready; > } > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1623625 for ; Sun, 21 Apr 2024 08:54:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713689645; cv=none; b=TWTqTR5JXEuOreoSWJo3Zd6JESRbq7cZNjHEJqvvmvdvhqyKdXQZCk1QPi0g2WC8LHPD3QF7hPTrqjLnKwaJlGO2cALeNChXVZq0IWNAwULSIljhviHk+IWxuuIOD8bBd6SfFvOaiQydbbZxWGclRac/7yCpRDx9GaROzBJ3xBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713689645; c=relaxed/simple; bh=eaVJSKc5oCRD99pk5u5bgQtIJBks9d5keyCfCBN20Fg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XMvKTgtbY1m70sY3hGLEFgXUZmWugOVTZxLkvaYMbXazVCkcUV7wPkg4hTwe+MrfFMIMqbW/k7uhyOyMvgJFDl26pSmjy405bYaectHkwGEeE6jw/2bAsZ/Gknio0fLUyMXWBjNYRRibHQNfWhoG5p8DAiGEJsJxt11/I/JRpMY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=Y5fm++7f; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Y5fm++7f" Received: from [192.168.1.105] (unknown [103.251.226.10]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 15482674; Sun, 21 Apr 2024 10:53:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1713689592; bh=eaVJSKc5oCRD99pk5u5bgQtIJBks9d5keyCfCBN20Fg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Y5fm++7fhszfF+0TYufHuIjCh8LCZLTtTBbuLgRQplSLqLlZqxlvKCW6T+bEsm17O S++stCD6Z425p+jDWzJbXJI9NZ7DtpeG8HJI9FhclB1vgpmpZJe85fIkMlDwY96/EB tlX6Hck7/obF3q2eak+HSeFDUBWEuDTfWLJ6+eYc= Message-ID: <6b83abcf-5cb1-4e61-b839-b4d51abda18a@ideasonboard.com> Date: Sun, 21 Apr 2024 14:23:54 +0530 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] staging: vchiq_core: Use printk messages for devices Content-Language: en-US To: Stefan Wahren , Greg Kroah-Hartman , Florian Fainelli Cc: Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org References: <20240420115351.27713-1-wahrenst@gmx.net> <20240420115351.27713-2-wahrenst@gmx.net> From: Umang Jain In-Reply-To: <20240420115351.27713-2-wahrenst@gmx.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefan, Thank you for the patch On 20/04/24 5:23 pm, Stefan Wahren wrote: > Now that struct vchiq_state has a device reference, we can convert > the remaining printk message helpers. > > Signed-off-by: Stefan Wahren Reviewed-by: Umang Jain > --- > .../vc04_services/interface/vchiq_arm/vchiq_core.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > index 3397365e551e..129d73fec2bf 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > @@ -697,7 +697,8 @@ reserve_space(struct vchiq_state *state, size_t space, int is_blocking) > > if (tx_pos == (state->slot_queue_available * VCHIQ_SLOT_SIZE)) { > complete(&state->slot_available_event); > - pr_warn("%s: invalid tx_pos: %d\n", __func__, tx_pos); > + dev_warn(state->dev, "%s: invalid tx_pos: %d\n", > + __func__, tx_pos); > return NULL; > } > > @@ -1732,10 +1733,9 @@ parse_message(struct vchiq_state *state, struct vchiq_header *header) > break; > } > if (queue->process != queue->remote_insert) { > - pr_err("%s: p %x != ri %x\n", > - __func__, > - queue->process, > - queue->remote_insert); > + dev_err(state->dev, "%s: p %x != ri %x\n", > + __func__, queue->process, > + queue->remote_insert); > mutex_unlock(&service->bulk_mutex); > goto bail_not_ready; > } > -- > 2.34.1 >