From: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: <devicetree@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Rob Herring <robh@kernel.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
<quic_ppratap@quicinc.com>, <quic_jackp@quicinc.com>,
Bjorn Andersson <quic_bjorande@quicinc.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Conor Dooley <conor+dt@kernel.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Johan Hovold <johan@kernel.org>, Felipe Balbi <balbi@kernel.org>
Subject: Re: [PATCH v21 5/9] dt-bindings: usb: qcom,dwc3: Add bindings for SC8280 Multiport
Date: Sat, 20 Apr 2024 19:23:35 +0530 [thread overview]
Message-ID: <7034e026-5c50-4c65-ba78-e9c73f4a276a@quicinc.com> (raw)
In-Reply-To: <3ca24a3d-e7e0-4f68-9a6f-ebaf83079ebe@linaro.org>
On 4/20/2024 5:01 PM, Krzysztof Kozlowski wrote:
> On 20/04/2024 06:48, Krishna Kurapati wrote:
>> Add the compatible string for SC8280 Multiport USB controller from
>> Qualcomm.
>>
>> There are 4 power event interrupts supported by this controller
>> (one for each port of multiport controller). Add all the 4 as
>> non-optional interrupts for SC8280XP-MP
>>
>> Also each port of multiport has one DP and one DM IRQ. Add all DP/DM
>> IRQs related to 4 ports of SC8280XP Teritiary controller.
>>
>> Also added SuperSpeed PHY interrupt for both Superspeed ports.
>>
>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
>> Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com>
>
> v21 and suddenly you drop tags requiring everyone to re-review this. I
> do not think this process is working. I will not re-review this.
>
> This is a friendly reminder during the review process.
>
> It looks like you received a tag and forgot to add it.
>
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions, under or above your Signed-off-by tag. Tag is "received", when
> provided in a message replied to you on the mailing list. Tools like b4
> can help here. However, there's no need to repost patches *only* to add
> the tags. The upstream maintainer will do that for tags received on the
> version they apply.
>
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
>
> If a tag was not added on purpose, please state why and what changed.
>
>
Hi Krzysztof,
There was a commit text change to fix minor nits:
-> One minor spell check: /s/oen/one
-> minor nits like: /s/ss/SuperSpeed
So removed the tags and requested for a review.
"Updated commit text in patches 2/5/6."
Apologies, My intention was to just fix the spell check and minor nits.
.
The changes in v21 were in patches 1/2/4/7/9.
Patches 3 and 8 were left untouched.
Made minor nit fixes to commit text in patches 5 and 6 so that it
feels more accurate.
Regards,
Krishna,
next prev parent reply other threads:[~2024-04-20 13:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 4:48 [PATCH v21 0/9] Add multiport support for DWC3 controllers Krishna Kurapati
2024-04-20 4:48 ` [PATCH v21 1/9] dt-bindings: usb: Add bindings for multiport properties on DWC3 controller Krishna Kurapati
2024-04-20 11:28 ` Krzysztof Kozlowski
2024-04-22 6:54 ` Johan Hovold
2024-04-20 4:48 ` [PATCH v21 2/9] usb: dwc3: core: Access XHCI address space temporarily to read port info Krishna Kurapati
2024-04-22 6:56 ` Johan Hovold
2024-04-24 1:11 ` Thinh Nguyen
2024-04-20 4:48 ` [PATCH v21 3/9] usb: dwc3: core: Skip setting event buffers for host only controllers Krishna Kurapati
2024-04-20 4:48 ` [PATCH v21 4/9] usb: dwc3: core: Refactor PHY logic to support Multiport Controller Krishna Kurapati
2024-04-22 7:10 ` Johan Hovold
2024-04-24 1:13 ` Thinh Nguyen
2024-04-20 4:48 ` [PATCH v21 5/9] dt-bindings: usb: qcom,dwc3: Add bindings for SC8280 Multiport Krishna Kurapati
2024-04-20 11:31 ` Krzysztof Kozlowski
2024-04-20 13:53 ` Krishna Kurapati PSSNV [this message]
2024-04-21 14:03 ` Krzysztof Kozlowski
2024-04-22 7:12 ` Johan Hovold
2024-04-22 7:13 ` Johan Hovold
2024-04-20 4:48 ` [PATCH v21 6/9] usb: dwc3: qcom: Add helper function to request wakeup interrupts Krishna Kurapati
2024-04-22 7:18 ` Johan Hovold
2024-04-24 1:14 ` Thinh Nguyen
2024-04-20 4:48 ` [PATCH v21 7/9] usb: dwc3: qcom: Refactor IRQ handling in glue driver Krishna Kurapati
2024-04-22 7:20 ` Johan Hovold
2024-04-24 1:17 ` Thinh Nguyen
2024-04-20 4:49 ` [PATCH v21 8/9] usb: dwc3: qcom: Enable wakeup for applicable ports of multiport Krishna Kurapati
2024-04-24 1:18 ` Thinh Nguyen
2024-04-20 4:49 ` [PATCH v21 9/9] usb: dwc3: qcom: Add multiport suspend/resume support for wrapper Krishna Kurapati
2024-04-22 7:22 ` Johan Hovold
2024-04-24 1:18 ` Thinh Nguyen
2024-04-22 1:21 ` [PATCH v21 0/9] Add multiport support for DWC3 controllers Minda Chen
2024-04-22 7:27 ` Johan Hovold
2024-04-22 7:40 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7034e026-5c50-4c65-ba78-e9c73f4a276a@quicinc.com \
--to=quic_kriskura@quicinc.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=andersson@kernel.org \
--cc=balbi@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_bjorande@quicinc.com \
--cc=quic_jackp@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.