From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB422C4345F for ; Tue, 23 Apr 2024 11:42:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vcKGcU/Xs7jxDy4i2u4j4BD1c2ZwzQbSf//UGN4iqVY=; b=elkWAhzyefkJ8y ITcabz5rFjeBwmUtSV4+LLu+MrPWrbhDW83qCPUVrjIL7ZjLNgQ0+u2SHiRFnZfoQCHHfbp6cwy4h IzVQQSIUTSz3JuCW/l4CdxtdI+EYtkfppQZCls3w+hGuKL/qc7VazuQqvASw9o3QAs4nh+IcUQd25 w2p71RVO9T9wviXE9eByonxDgCIcl5QmskNJfhu2SETQwR+sOSyzAMo8Wt3v/ujnC0lZJsP4/ZzoK iW/C1zGzHxPLlZRJE8f5668Uja3Cc2hF7c9SmaLtJKhgzTp4H2S0g7OiY67gTDpErFI5hlfFU7Ov6 Th7SB5RiC8hEdJredyqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzEXi-0000000HA2o-12O5; Tue, 23 Apr 2024 11:42:34 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzEXe-0000000HA1P-32OM for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2024 11:42:31 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1C9EC61389; Tue, 23 Apr 2024 11:42:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B198DC116B1; Tue, 23 Apr 2024 11:42:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713872549; bh=QMG25wM6rNvenjQtlyiQjo4wKkHfNNfh8ctqNlKRPrA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MR/vuGmMmZRRofGLRXaEDB3/rGlBK4+EQdZ549jIGxDzw6yfyKRDZPHcr4aL2d7XD BcEuluhBq/9vbgBGzkBGvCXfLs0bOR5YogHlWCLdFwXvfZudVW3rY24wH8/Keahr9E 4wXl9MlsfUfQ9yRgmgT9gQ/PVvRpIamsSVTcg+5JIxWD97abPHTsy7TApuzUcVS/5u mRNu8wtoh537Ia+HMRjN3CRdq8vHfErziu1F1xDG1aDY2+SjPJMdl6sY0XDHSQPhPe vh7RixfiRkyeUCa/1NSahJp+IGskWNsktdcJ6exYPEtB0CrJmI0ylPQRJqpRvRXO78 IsfK54dedPLTA== Received: from [12.161.88.66] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rzEXb-0079xU-B6; Tue, 23 Apr 2024 12:42:27 +0100 Date: Tue, 23 Apr 2024 12:42:22 +0100 Message-ID: <87r0ewtie9.wl-maz@kernel.org> From: Marc Zyngier To: Zenghui Yu Cc: Jon Hunter , , , , James Morse , Suzuki K Poulose , Oliver Upton , Joey Gouly , Fuad Tabba , Mostafa Saleh , Will Deacon , Catalin Marinas , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH v4 12/15] KVM: arm64: nv: Add emulation for ERETAx instructions In-Reply-To: <4c2fd210-fa36-8462-8a4d-70135cc2f040@huawei.com> References: <20240419102935.1935571-1-maz@kernel.org> <20240419102935.1935571-13-maz@kernel.org> <14667111-4ad6-48d2-93ee-742c5075f407@nvidia.com> <4c2fd210-fa36-8462-8a4d-70135cc2f040@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 12.161.88.66 X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, jonathanh@nvidia.com, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, joey.gouly@arm.com, tabba@google.com, smostafa@google.com, will@kernel.org, catalin.marinas@arm.com, linux-tegra@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240423_044230_874868_2765CCE0 X-CRM114-Status: GOOD ( 21.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyMyBBcHIgMjAyNCAxMDo0MDoyMiArMDEwMCwKWmVuZ2h1aSBZdSA8eXV6ZW5naHVp QGh1YXdlaS5jb20+IHdyb3RlOgo+IAo+IE9uIDIwMjQvNC8yMyAxNzoyMiwgSm9uIEh1bnRlciB3 cm90ZToKPiA+IAo+ID4gU29tZSBvZiBvdXIgYnVpbGRlcnMgY3VycmVudGx5IGhhdmUgYW4gb2xk ZXIgdmVyc2lvbiBvZiBHQ0MgKHY2KSBhbmQKPiA+IGFmdGVyIHRoaXMgY2hhbmdlIEkgYW0gc2Vl aW5nIC4uLgo+ID4gCj4gPiAgwqAgQ0PCoMKgwqDCoMKgIGFyY2gvYXJtNjQva3ZtL3BhdXRoLm8K PiA+IC90bXAvY2NvaHN0MHYuczogQXNzZW1ibGVyIG1lc3NhZ2VzOgo+ID4gL3RtcC9jY29oc3Qw di5zOjExNzc6IEVycm9yOiB1bmtub3duIGFyY2hpdGVjdHVyYWwgZXh0ZW5zaW9uIGBwYXV0aCcK PiA+IC90bXAvY2NvaHN0MHYuczoxMTc3OiBFcnJvcjogdW5rbm93biBtbmVtb25pYyBgcGFjZ2En IC0tIGBwYWNnYSB4MjEseDIyLHgwJwo+ID4gL2xvY2FsL3dvcmtkaXIvdGVncmEvbWx0LWxpbnV4 X25leHQva2VybmVsL3NjcmlwdHMvTWFrZWZpbGUuYnVpbGQ6MjQ0Ogo+ID4gcmVjaXBlIGZvciB0 YXJnZXQgJ2FyY2gvYXJtNjQva3ZtL3BhdXRoLm8nIGZhaWxlZAo+ID4gbWFrZVs1XTogKioqIFth cmNoL2FybTY0L2t2bS9wYXV0aC5vXSBFcnJvciAxCj4gPiAvbG9jYWwvd29ya2Rpci90ZWdyYS9t bHQtbGludXhfbmV4dC9rZXJuZWwvc2NyaXB0cy9NYWtlZmlsZS5idWlsZDo0ODU6Cj4gPiByZWNp cGUgZm9yIHRhcmdldCAnYXJjaC9hcm02NC9rdm0nIGZhaWxlZAo+ID4gbWFrZVs0XTogKioqIFth cmNoL2FybTY0L2t2bV0gRXJyb3IgMgo+ID4gL2xvY2FsL3dvcmtkaXIvdGVncmEvbWx0LWxpbnV4 X25leHQva2VybmVsL3NjcmlwdHMvTWFrZWZpbGUuYnVpbGQ6NDg1Ogo+ID4gcmVjaXBlIGZvciB0 YXJnZXQgJ2FyY2gvYXJtNjQnIGZhaWxlZAo+ID4gbWFrZVszXTogKioqIFthcmNoL2FybTY0XSBF cnJvciAyCj4gPiAKPiA+IAo+ID4gSSBrbm93IHRoaXMgaXMgcHJldHR5IG9sZCBub3cgYW5kIEkg YW0gdHJ5aW5nIHRvIGdldCB0aGVzZSBidWlsZGVycwo+ID4gdXBkYXRlZC4gSG93ZXZlciwgdGhl IGtlcm5lbCBkb2NzIHN0aWxsIHNob3cgdGhhdCBHQ0MgdjUuMSBpcwo+ID4gc3VwcG9ydGVkIFsw XS4KPiAKPiBXYXMganVzdCBsb29raW5nIGF0IHRoZSBkaXNjdXNzaW9uIFsxXSA7LSkgLiBGWUkg dGhlcmUgaXMgYWxyZWFkeSBhCj4gcGF0Y2ggb24gdGhlIGxpc3QgWzJdIHdoaWNoIHNob3VsZCBi ZSBtZXJnZWQgc29vbi4KCkluZGVlZC4gLW5leHQgYXMgb2YgdG9kYXkgYWxyZWFkeSBoYXMgdGhl IGZpeCwgYWx0aG91Z2ggSSdtIHJld29ya2luZwppdCB0byB0YWtlIE1hcmsncyByZW1hcmtzIGlu dG8gYWNjb3VudC4KCkpvbiwgY2FuIHlvdSBjb25maXJtIHRoYXQgbmV4dC0yMDI0MDQyMyBidWls ZHMgd2l0aCB5b3VyIHNldHVwPwoKVGhhbmtzLAoKCU0uCgotLSAKV2l0aG91dCBkZXZpYXRpb24g ZnJvbSB0aGUgbm9ybSwgcHJvZ3Jlc3MgaXMgbm90IHBvc3NpYmxlLgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 484D87E761; Tue, 23 Apr 2024 11:42:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713872550; cv=none; b=bPD+raBqu4a+b+6Lpneim2ZO+97VacYf6VDVu0FP05Lzx5jg5P/qVoSAFGv/DntrfA3aoOC/LZcYmTcGVc5M+qoF7A9BoatwYxDTsHK0gdfAfJZInO2KAsgQRswWCI62lzpYSZ7CnI0625Hz2zopshfMJxQVZ+C6SPn9wNCIxlw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713872550; c=relaxed/simple; bh=QMG25wM6rNvenjQtlyiQjo4wKkHfNNfh8ctqNlKRPrA=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=GL84apB1XJDN1jqESCuNTUCupX3wYKv5/Sk9eRwqpsAEY1+4Ek/sW7JGCvhq0hX9u3gMsQEnFbR5rUuA0mWILwFN6unuN23q9qZepeyHyG6EFe/wmh0+zLQTrNwG9sGjPgNQNzyAAF/pQDhAXTC++3K87y3uxCc0p5JgmyZfdNs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MR/vuGmM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MR/vuGmM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B198DC116B1; Tue, 23 Apr 2024 11:42:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713872549; bh=QMG25wM6rNvenjQtlyiQjo4wKkHfNNfh8ctqNlKRPrA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MR/vuGmMmZRRofGLRXaEDB3/rGlBK4+EQdZ549jIGxDzw6yfyKRDZPHcr4aL2d7XD BcEuluhBq/9vbgBGzkBGvCXfLs0bOR5YogHlWCLdFwXvfZudVW3rY24wH8/Keahr9E 4wXl9MlsfUfQ9yRgmgT9gQ/PVvRpIamsSVTcg+5JIxWD97abPHTsy7TApuzUcVS/5u mRNu8wtoh537Ia+HMRjN3CRdq8vHfErziu1F1xDG1aDY2+SjPJMdl6sY0XDHSQPhPe vh7RixfiRkyeUCa/1NSahJp+IGskWNsktdcJ6exYPEtB0CrJmI0ylPQRJqpRvRXO78 IsfK54dedPLTA== Received: from [12.161.88.66] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rzEXb-0079xU-B6; Tue, 23 Apr 2024 12:42:27 +0100 Date: Tue, 23 Apr 2024 12:42:22 +0100 Message-ID: <87r0ewtie9.wl-maz@kernel.org> From: Marc Zyngier To: Zenghui Yu Cc: Jon Hunter , , , , James Morse , Suzuki K Poulose , Oliver Upton , Joey Gouly , Fuad Tabba , Mostafa Saleh , Will Deacon , Catalin Marinas , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH v4 12/15] KVM: arm64: nv: Add emulation for ERETAx instructions In-Reply-To: <4c2fd210-fa36-8462-8a4d-70135cc2f040@huawei.com> References: <20240419102935.1935571-1-maz@kernel.org> <20240419102935.1935571-13-maz@kernel.org> <14667111-4ad6-48d2-93ee-742c5075f407@nvidia.com> <4c2fd210-fa36-8462-8a4d-70135cc2f040@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 12.161.88.66 X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, jonathanh@nvidia.com, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, joey.gouly@arm.com, tabba@google.com, smostafa@google.com, will@kernel.org, catalin.marinas@arm.com, linux-tegra@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 23 Apr 2024 10:40:22 +0100, Zenghui Yu wrote: >=20 > On 2024/4/23 17:22, Jon Hunter wrote: > >=20 > > Some of our builders currently have an older version of GCC (v6) and > > after this change I am seeing ... > >=20 > > =C2=A0 CC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 arch/arm64/kvm/pauth.o > > /tmp/ccohst0v.s: Assembler messages: > > /tmp/ccohst0v.s:1177: Error: unknown architectural extension `pauth' > > /tmp/ccohst0v.s:1177: Error: unknown mnemonic `pacga' -- `pacga x21,x22= ,x0' > > /local/workdir/tegra/mlt-linux_next/kernel/scripts/Makefile.build:244: > > recipe for target 'arch/arm64/kvm/pauth.o' failed > > make[5]: *** [arch/arm64/kvm/pauth.o] Error 1 > > /local/workdir/tegra/mlt-linux_next/kernel/scripts/Makefile.build:485: > > recipe for target 'arch/arm64/kvm' failed > > make[4]: *** [arch/arm64/kvm] Error 2 > > /local/workdir/tegra/mlt-linux_next/kernel/scripts/Makefile.build:485: > > recipe for target 'arch/arm64' failed > > make[3]: *** [arch/arm64] Error 2 > >=20 > >=20 > > I know this is pretty old now and I am trying to get these builders > > updated. However, the kernel docs still show that GCC v5.1 is > > supported [0]. >=20 > Was just looking at the discussion [1] ;-) . FYI there is already a > patch on the list [2] which should be merged soon. Indeed. -next as of today already has the fix, although I'm reworking it to take Mark's remarks into account. Jon, can you confirm that next-20240423 builds with your setup? Thanks, M. --=20 Without deviation from the norm, progress is not possible.