* [PATCH net v3] net: b44: set pause params only when interface is up
@ 2024-04-19 20:44 Peter Münster
2024-04-19 21:14 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Peter Münster @ 2024-04-19 20:44 UTC (permalink / raw
To: netdev; +Cc: Michael Chan
[-- Attachment #1.1: Type: text/plain, Size: 99 bytes --]
Hi,
This patch fixes a kernel panic when using netifd.
Kind regards,
--
Peter
[-- Attachment #1.2: 0001-net-b44-set-pause-params-only-when-interface-is-up.patch --]
[-- Type: text/x-patch, Size: 1709 bytes --]
b44_free_rings() accesses b44::rx_buffers (and ::tx_buffers)
unconditionally, but b44::rx_buffers is only valid when the
device is up (they get allocated in b44_open(), and deallocated
again in b44_close()), any other time these is just a NULL pointers.
So if you try to change the pause params while the network interface
is disabled/administratively down, everything explodes (which likely
netifd tries to do).
Link: https://github.com/openwrt/openwrt/issues/13789
Fixes: 1da177e4c3f4 (Linux-2.6.12-rc2)
Cc: stable@vger.kernel.org
Reported-by: Peter Münster <pm@a16n.net>
Suggested-by: Jonas Gorski <jonas.gorski@gmail.com>
Signed-off-by: Vaclav Svoboda <svoboda@neng.cz>
Tested-by: Peter Münster <pm@a16n.net>
Signed-off-by: Peter Münster <pm@a16n.net>
---
drivers/net/ethernet/broadcom/b44.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c
index 3e4fb3c3e834..1be6d14030bc 100644
--- a/drivers/net/ethernet/broadcom/b44.c
+++ b/drivers/net/ethernet/broadcom/b44.c
@@ -2009,12 +2009,14 @@ static int b44_set_pauseparam(struct net_device *dev,
bp->flags |= B44_FLAG_TX_PAUSE;
else
bp->flags &= ~B44_FLAG_TX_PAUSE;
- if (bp->flags & B44_FLAG_PAUSE_AUTO) {
- b44_halt(bp);
- b44_init_rings(bp);
- b44_init_hw(bp, B44_FULL_RESET);
- } else {
- __b44_set_flow_ctrl(bp, bp->flags);
+ if (netif_running(dev)) {
+ if (bp->flags & B44_FLAG_PAUSE_AUTO) {
+ b44_halt(bp);
+ b44_init_rings(bp);
+ b44_init_hw(bp, B44_FULL_RESET);
+ } else {
+ __b44_set_flow_ctrl(bp, bp->flags);
+ }
}
spin_unlock_irq(&bp->lock);
--
2.35.3
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net v3] net: b44: set pause params only when interface is up
2024-04-19 20:44 [PATCH net v3] net: b44: set pause params only when interface is up Peter Münster
@ 2024-04-19 21:14 ` Andrew Lunn
2024-04-20 6:40 ` Peter Münster
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2024-04-19 21:14 UTC (permalink / raw
To: Peter Münster; +Cc: netdev, Michael Chan
On Fri, Apr 19, 2024 at 10:44:28PM +0200, Peter Münster wrote:
> Hi,
>
> This patch fixes a kernel panic when using netifd.
>
> Kind regards,
> --
> Peter
Still above the --- . Don't use attachments.
The best way to send patches is
git format-patch
followed by
git send email
https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format
Alternatively, look at b4:
https://b4.docs.kernel.org/en/latest/contributor/prep.html
Interestingly, patchwork does seemed to of extracted the patch:
https://patchwork.kernel.org/project/netdevbpf/patch/87o7a5yteb.fsf@a16n.net/
So it could be the patch can be applied as it is. Lets see what Jakub
says.
Anyway:
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
We are picky about things like this because there are a lot of patches
flying around, and we need to be efficient at applying them. So we
want patches in a specific format. It takes a little bit of time to
learn to do it correct, but once you use the tools correctly it
becomes simple as a developer and efficient for those receiving the
patches.
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v3] net: b44: set pause params only when interface is up
2024-04-19 21:14 ` Andrew Lunn
@ 2024-04-20 6:40 ` Peter Münster
0 siblings, 0 replies; 3+ messages in thread
From: Peter Münster @ 2024-04-20 6:40 UTC (permalink / raw
To: Andrew Lunn; +Cc: netdev, Michael Chan
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
On Fri, Apr 19 2024, Andrew Lunn wrote:
> Still above the --- . Don't use attachments.
Ah, ok, sorry.
> Lets see what Jakub says.
Ok, so I should wait before sending v4?
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Another line to attach to the patch for v4?
> We are picky about things like this
No problem, I fully understand.
--
Peter
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-20 6:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-19 20:44 [PATCH net v3] net: b44: set pause params only when interface is up Peter Münster
2024-04-19 21:14 ` Andrew Lunn
2024-04-20 6:40 ` Peter Münster
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.