From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A0DD74420; Mon, 15 Apr 2024 14:05:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713189936; cv=none; b=KSbGRzHbl7Ei3IJtOI6+NgekFDiOytgd6WivQpUin0bpD4eQb7WemNG9BRtNKm3783j4HW8ywSbyyBtotWoR35i8H0Xodd9qpI8cx60Vv8RetcIr3LkyXMd7oGxEoSEDe6L8b/xMYI68ieQbpaBXECNANGaAPi4QpJE7UzsB9D4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713189936; c=relaxed/simple; bh=C2RaXFcuh6uhrQqFZdquLpLy57EbGKkPUni9Jf4Km8E=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=gQPDm4x5IosXjz312JCq5OUHq9IJV2631BLzYVNQDkl5TG8QANgKSyMDhsIKA8weBO5ZXyIAtG34F88QZGUvwT765EHIhMNcDInMJzxpxPOAKIMBlix0Zkn69KeUkcs1Lr9q1JCf3vROxUvd2aSA3l9VKT++PUyEkP3HIuMVd+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jpzx8k0X; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jpzx8k0X" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-563cb3ba9daso3121476a12.3; Mon, 15 Apr 2024 07:05:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713189929; x=1713794729; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ce+RZRNdvY2/c7BMbLG8IKG8g7W50m+r0bqN56BPld4=; b=jpzx8k0XvsE30XWjgOnfcrzTqufdwG0YJLdCGuWsWyorExU7YcQ5d1dQXT4ynOw2uY IxAhq3MiH5qaRTcWmgyg5XRpN95GW9pAnY440FKkbp0I2luXggqwvvnlP+gMUoXWY3BZ Hldh1RGHlbD57FcYBpFhBZ9pVx3CQx5LbHZG/AW0lWr2qLrAoBKcjZY8KkvmZGTOD+sr YTC5eefT7+fedTPXGLIrwQbUHvddnw3NDsWmzfHRFDeLpAlg3MKX25Upflgw8yA7Eogb oQPV2Gs2a+OIiyvJsBXbxe1UTZ38eNqIgoznRoAoxRAAKSwBnfKIzTWrUAaheJK66VVQ C/+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713189929; x=1713794729; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ce+RZRNdvY2/c7BMbLG8IKG8g7W50m+r0bqN56BPld4=; b=nWFvHhGZ7DdEJY3mIMW5wwJsT55+DTkXwZo1hrX6OSV4M+qcNQBiibY2l/bRP1dLY5 YXM7Fi/FOGBTEmyqiLogQ7ep6pTtoV/bogHKzwH6ElM5t8X37vdXlWB9OKMjAYHQz5wA MJp28yifH40vbVCoKQxemMmCxlYeiDYtNkHOeon65+uzg7NkzN9uqAvJWS5ubzbn1vGC ipa9kNQzGq6lHP4QW79dX/gAy83xh5ZDOzuN/bkMLALKHu0lVmMi2qWi8wkoAB9QQQGS RVwW1ovU/lzpkbVbQMc7SRlTG+xbeGiEhgw2PTpadLSrQQkON6xGkTsPQbI5Vl8l4f4I TDWw== X-Forwarded-Encrypted: i=1; AJvYcCVFkolld2GFSqzusotWP8OWhiy852shbAkkZ4sdOoL1vqM9DqmpzM3oaP2asPDb7EZzUK5ci+5EDywlfrsoaXqCBddOwNGzw3AVmhDZx++InNs+ZNMs0Ziz4RkDXD3oHUtWbC2gAFBUComXH4Ztat1IAvz7ArN9iHOZO3DoNx8j487LzhGhwoZ6OYiUVllvkIDbbSpiZsn2mfm8M92xUwwa X-Gm-Message-State: AOJu0Yy0FZY007OVcR8AAdQuqipFhgID2qZDOl+X3VE0RilWqSAM6FzT yR//VpNJd0o6w5zME25rCSat/DrAYB4zSfSZNLm+CnrT6eeHuDpMgC+PayWuabZOFSDiuE80S0h DyfFN0kgLanOaCSeiMIvGqSyZChQ= X-Google-Smtp-Source: AGHT+IH86wMUY1Sjlbl77b74h8OkFHcq+fDgDK9uWIRulsSWUGwrIz3dHKroKOaN9XoU6ownWtnCcV0AOUGrp658hc4= X-Received: by 2002:a17:906:1355:b0:a4a:3441:2e2a with SMTP id x21-20020a170906135500b00a4a34412e2amr6807358ejb.55.1713189929060; Mon, 15 Apr 2024 07:05:29 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240414175300.956243-1-aren@peacevolution.org> <20240414175716.958831-1-aren@peacevolution.org> <20240414175716.958831-2-aren@peacevolution.org> In-Reply-To: <20240414175716.958831-2-aren@peacevolution.org> From: Andy Shevchenko Date: Mon, 15 Apr 2024 17:04:53 +0300 Message-ID: Subject: Re: [PATCH 2/4] iio: light: stk3310: Implement vdd supply and power it off during suspend To: Aren Moynihan Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Liam Girdwood , Mark Brown , Ondrej Jirman , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , linux-iio@vger.kernel.org, phone-devel@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Willow Barraco Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Apr 14, 2024 at 8:57=E2=80=AFPM Aren Moynihan wrote: > > From: Ondrej Jirman > > VDD power input can be used to completely power off the chip during > system suspend. Do so if available. ... > #include > #include > #include > +#include Move it to be ordered and add a blank line to separate iio/*.h group. ... > + data->vdd_reg =3D devm_regulator_get_optional(&client->dev, "vdd"= ); > + if (IS_ERR(data->vdd_reg)) { > + ret =3D PTR_ERR(data->vdd_reg); > + if (ret =3D=3D -ENODEV) > + data->vdd_reg =3D NULL; > + else Redundant 'else' when you follow the pattern "check for error condition fir= st". > + return dev_err_probe(&client->dev, ret, > + "get regulator vdd failed\n"= ); > + } ... > + if (data->vdd_reg) { > + ret =3D regulator_enable(data->vdd_reg); > + if (ret) > + return dev_err_probe(&client->dev, ret, > + "regulator vdd enable failed= \n"); > + > + usleep_range(1000, 2000); fsleep() > + } ... > stk3310_set_state(iio_priv(indio_dev), STK3310_STATE_STANDBY); > + if (data->vdd_reg) > + regulator_disable(data->vdd_reg); I forgot to check the order of freeing resources, be sure you have no devm_*() releases happening before this call. ... > + usleep_range(1000, 2000); fsleep() --=20 With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87440C4345F for ; Mon, 15 Apr 2024 14:05:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D+cdUyCaGWy15NKbq8P4BI6f+iVb3kDD9kuFpR765zg=; b=CMS5mvMHLymJPl Zd68fr4miXBYwSEe4aIE+CyYiapw7/gdAI5HaVLHRrNAbNGn1aZTA8AecOpJldU3dPHCHHIEphgvX Jm0K1I3gs7m9v9YAh39EmYdV3djopt9TeR+Kv2UrtkH1vzEiSzsGyUhn0How+o47e6yflPN9y+kNA ngFdQUO7cJWaWDWyAtTlAYpKk59jBlZoSImfJ8y42kmj6H8+FeYBsliNxAmbenBLolGEVff/i9HDb +E5syi6I+LyLJcVOJTutZAxh0luqzOlffWruqu1AcTOIUUIEBwx4yMbdTmNp9rqGLMi7t8pJssEGw wOm9ULRmQyzBrCzEZd9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwMxo-00000008cq3-1wMU; Mon, 15 Apr 2024 14:05:40 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwMxf-00000008cp6-1mcq for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2024 14:05:38 +0000 Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-a523524e5baso380453066b.3 for ; Mon, 15 Apr 2024 07:05:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713189929; x=1713794729; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ce+RZRNdvY2/c7BMbLG8IKG8g7W50m+r0bqN56BPld4=; b=B/t9q+5KiGO5GZFK5WGGsfHHb+Xh4ipoztkNGth4zTxY29nAcYbQbQ+5g7eq8XWGeG YggucA1J0VcDwCQDsZu4VRUJB8AuvQ/VOtOnpUB9OKpyE2O7g20VGZna3L0vHu1Vk2a4 Q3aSlbeh+bEjUFhTXFPPXZ0dShrar/BBvsP5uMebM9z8KIV9vnx2hKilu8HjdKBqFsbo mpqm+HK5/2FEPaniedYWmsHyg/E4RaT3aDblm1vIXJLj6doW0TPGMxMXPxmbRLnzU2nb 0tOc8nyhV2fs8Z47UhUu5LB+cShgTlaQ3JqncLIb/ZqMaclpguJH0oVZoSyRiL+lMWcf JKhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713189929; x=1713794729; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ce+RZRNdvY2/c7BMbLG8IKG8g7W50m+r0bqN56BPld4=; b=jwHzR/+BdjaAdlM3JvEHoyblC0Wn9VRunl0Rthbq+XK09OjDiZuyzt+QMAXM4ydiy2 nl0XpANy4EzEkk5WW6rXKM8vLA0ji4szS07bVwP7/AFsnMympjVWmEPCAm1ATMJ+9Vj3 bfE5nw4OGcKhoeTfryYQu0VmPMS6jgkWBOZom0kQmsMf+F99xwrbnua8d9/Knrh8qiiJ LwbXUBTy8+Sz90ULEWm4VyRH2lGqqtmrOBcaMWi+cQ9IziFMS58ohfxNy2Xbg7ZylzuC QMcUsJT1fbDc/qpbZtct7TuNWRjNXI9Kmpm8j6cRiGQ9Cc4ckGCLcDV/5q4aZTiKpxa8 3TpQ== X-Forwarded-Encrypted: i=1; AJvYcCXPzkhy0nYru0sYdF8DmnctguaYPFm1UFRITTmxFGL/Z5gXbeGbcY8kc8YhJUcyUIuS7fuJac/uKrCoEKhdUI50E2qCg/wXUvjZkPUWJiP0RA+gOK4= X-Gm-Message-State: AOJu0YxQXw0QWOP6woBxD8zoEfQ48Kez5MsrFiCz+yO0X2NRgBZQDBwr gsp4pfIdvTL3+gAMEHF5gd4Yh4H6oMFQHAKgsE5B8B3E73Cp80Ub9g7qZ4KB7DKEs6AeQmch8Kb Ehce4hJlIJKWVk8qv/f6tyy0VNFo= X-Google-Smtp-Source: AGHT+IH86wMUY1Sjlbl77b74h8OkFHcq+fDgDK9uWIRulsSWUGwrIz3dHKroKOaN9XoU6ownWtnCcV0AOUGrp658hc4= X-Received: by 2002:a17:906:1355:b0:a4a:3441:2e2a with SMTP id x21-20020a170906135500b00a4a34412e2amr6807358ejb.55.1713189929060; Mon, 15 Apr 2024 07:05:29 -0700 (PDT) MIME-Version: 1.0 References: <20240414175300.956243-1-aren@peacevolution.org> <20240414175716.958831-1-aren@peacevolution.org> <20240414175716.958831-2-aren@peacevolution.org> In-Reply-To: <20240414175716.958831-2-aren@peacevolution.org> From: Andy Shevchenko Date: Mon, 15 Apr 2024 17:04:53 +0300 Message-ID: Subject: Re: [PATCH 2/4] iio: light: stk3310: Implement vdd supply and power it off during suspend To: Aren Moynihan Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Liam Girdwood , Mark Brown , Ondrej Jirman , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , linux-iio@vger.kernel.org, phone-devel@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Willow Barraco X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_070531_564934_F471662C X-CRM114-Status: GOOD ( 13.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCBBcHIgMTQsIDIwMjQgYXQgODo1N+KAr1BNIEFyZW4gTW95bmloYW4gPGFyZW5AcGVh Y2V2b2x1dGlvbi5vcmc+IHdyb3RlOgo+Cj4gRnJvbTogT25kcmVqIEppcm1hbiA8bWVnaUB4ZmYu Y3o+Cj4KPiBWREQgcG93ZXIgaW5wdXQgY2FuIGJlIHVzZWQgdG8gY29tcGxldGVseSBwb3dlciBv ZmYgdGhlIGNoaXAgZHVyaW5nCj4gc3lzdGVtIHN1c3BlbmQuIERvIHNvIGlmIGF2YWlsYWJsZS4K Ci4uLgoKPiAgI2luY2x1ZGUgPGxpbnV4L2lpby9ldmVudHMuaD4KPiAgI2luY2x1ZGUgPGxpbnV4 L2lpby9paW8uaD4KPiAgI2luY2x1ZGUgPGxpbnV4L2lpby9zeXNmcy5oPgoKPiArI2luY2x1ZGUg PGxpbnV4L3JlZ3VsYXRvci9jb25zdW1lci5oPgoKTW92ZSBpdCB0byBiZSBvcmRlcmVkIGFuZCBh ZGQgYSBibGFuayBsaW5lIHRvIHNlcGFyYXRlIGlpby8qLmggZ3JvdXAuCgouLi4KCj4gKyAgICAg ICBkYXRhLT52ZGRfcmVnID0gZGV2bV9yZWd1bGF0b3JfZ2V0X29wdGlvbmFsKCZjbGllbnQtPmRl diwgInZkZCIpOwo+ICsgICAgICAgaWYgKElTX0VSUihkYXRhLT52ZGRfcmVnKSkgewo+ICsgICAg ICAgICAgICAgICByZXQgPSBQVFJfRVJSKGRhdGEtPnZkZF9yZWcpOwo+ICsgICAgICAgICAgICAg ICBpZiAocmV0ID09IC1FTk9ERVYpCj4gKyAgICAgICAgICAgICAgICAgICAgICAgZGF0YS0+dmRk X3JlZyA9IE5VTEw7Cgo+ICsgICAgICAgICAgICAgICBlbHNlCgpSZWR1bmRhbnQgJ2Vsc2UnIHdo ZW4geW91IGZvbGxvdyB0aGUgcGF0dGVybiAiY2hlY2sgZm9yIGVycm9yIGNvbmRpdGlvbiBmaXJz dCIuCgo+ICsgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBkZXZfZXJyX3Byb2JlKCZjbGll bnQtPmRldiwgcmV0LAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICJnZXQgcmVndWxhdG9yIHZkZCBmYWlsZWRcbiIpOwo+ICsgICAgICAgfQoKLi4uCgo+ICsg ICAgICAgaWYgKGRhdGEtPnZkZF9yZWcpIHsKPiArICAgICAgICAgICAgICAgcmV0ID0gcmVndWxh dG9yX2VuYWJsZShkYXRhLT52ZGRfcmVnKTsKPiArICAgICAgICAgICAgICAgaWYgKHJldCkKPiAr ICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gZGV2X2Vycl9wcm9iZSgmY2xpZW50LT5kZXYs IHJldCwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAicmVn dWxhdG9yIHZkZCBlbmFibGUgZmFpbGVkXG4iKTsKPiArCj4gKyAgICAgICAgICAgICAgIHVzbGVl cF9yYW5nZSgxMDAwLCAyMDAwKTsKCmZzbGVlcCgpCgo+ICsgICAgICAgfQoKLi4uCgo+ICAgICAg ICAgc3RrMzMxMF9zZXRfc3RhdGUoaWlvX3ByaXYoaW5kaW9fZGV2KSwgU1RLMzMxMF9TVEFURV9T VEFOREJZKTsKPiArICAgICAgIGlmIChkYXRhLT52ZGRfcmVnKQo+ICsgICAgICAgICAgICAgICBy ZWd1bGF0b3JfZGlzYWJsZShkYXRhLT52ZGRfcmVnKTsKCkkgZm9yZ290IHRvIGNoZWNrIHRoZSBv cmRlciBvZiBmcmVlaW5nIHJlc291cmNlcywgYmUgc3VyZSB5b3UgaGF2ZSBubwpkZXZtXyooKSBy ZWxlYXNlcyBoYXBwZW5pbmcgYmVmb3JlIHRoaXMgY2FsbC4KCi4uLgoKPiArICAgICAgICAgICAg ICAgdXNsZWVwX3JhbmdlKDEwMDAsIDIwMDApOwoKZnNsZWVwKCkKCi0tIApXaXRoIEJlc3QgUmVn YXJkcywKQW5keSBTaGV2Y2hlbmtvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==