From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6ED117AD78; Thu, 18 Apr 2024 18:20:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713464405; cv=none; b=JTl5T136aYViEtvjP05htcCDkxO1NLqJ+NtqPrM6oj2NDymFAP6qriHe6TT3lgBUvU9+HoBrykoTZOSMhb7/AqsDC5IzfjnhLKX1U2rqinOwDmm/VUT+MdcJ4gBPl6bvQHRh2fF0teeosg6VRTS4ldKEXKwxsspNlR4yNJXhccU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713464405; c=relaxed/simple; bh=eG3q+zpUjWVOdPOZkaSjqo0usEFxFJPlILtnK4zyysA=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=qfmKTG2ZNGM98SuYB+yHL5FSToNSnwhONOHGuvktWLGl9vzshp+VmPTFsnQEWki0bLSoh9o7J9tZ4q2Q5nd0kQb41/S3UVM+8TckDe+NUbaN9Bkt2gBJcKuZlNGu3LrV0QVZelYD7lpK6lsd3EfJJ5xSBabEGecTBYbtwIR03Jc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TjAaH3rT; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TjAaH3rT" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5196c755e82so1527929e87.0; Thu, 18 Apr 2024 11:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713464402; x=1714069202; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eG3q+zpUjWVOdPOZkaSjqo0usEFxFJPlILtnK4zyysA=; b=TjAaH3rTcwZ6baENl3JUClYjXuNMYAGnHMc2Do0UqNcXq6iKXfphcPn/YEuiQc04EH r6sovmdLq36+sYpiocEw/AYX493w5HBFxWxMhLbMf4NCEenXNb7/nK8BLX4Hn1hyVUJ0 2DNQgSS06phU3tEYhDk5M0MqfTThvqeCrKofEvivuqxdWuCzYq3dKdZW4Sgvjij15cel vJTx7B7SmymBG36jrkDD5tZM/NVcSA6jCBVIVXN4n9g3BkMjWNq3Xvf9QaKTlZ5CZVxk wHuD6QAhNceA5HmJpltl4RRjs+yqh9nrjDT30v5N6GeUrfhAeRzgIIIfpW1/GM+f5dS5 9dfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713464402; x=1714069202; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eG3q+zpUjWVOdPOZkaSjqo0usEFxFJPlILtnK4zyysA=; b=k8HN+lQxyRGtaAmPcO8s5w6Fj+NU0E77E1VuDSlAcaP/P3hrlNIqb1Qx5R5DkKZLlC ZkK/FJsvCoQHo815a9tk6LZR7CQreeQ4sgcWQddOqOohefi7eK/f2cCdoELGFpwsA58m 21T52ez7ahVoAUTNsF+SG9Nzp9xd6Icqg16CldY0pgG489+674McEO7nn+7s2Xisl/vh k5uQDejpeTMpA6OGWEDuTEvQz2DdytvXW//tIMItMvX/WYEh+LnaefehhhBPt7z/rnvm nfFRs0jodqN8OrAX/HBMWp+9e73V+sFjQ+Z74Pr9r1ZxGIBSQ2CrB2wtt0f7V1nRQre5 TMLQ== X-Forwarded-Encrypted: i=1; AJvYcCWQ+3tBJQz6CLSEWc0ibw4jvg1KDXrqR8jP0nQyTCoMjmmvCWu3tvkynShwBExFvtoUekEmlBoc25AUoxiDbV7dqiqRhUZvxJZbCUvok4bk8rxGVzmgzkVNfEfej72orIacBZ8TathXlSt0hFhmFht+QqBXwaxpE8G4/v1K6nLyE8bV10ht+6KY4Zhnrq65YebLYAZt4SybWFBCSlqmtdxD X-Gm-Message-State: AOJu0Yw0M5oi82PgzpNaD4YKRgpGI3SuKSnfOdIbr16GWHWK2NCSCD6i Rr6FJb+Te5wwp6o+7k4wK79RQw1hVcnFtsQircUMeFBz398tSDKeRbLABiTnlUU58HgyCqqF5ZQ wOLWlntBPhgWM34pdjte+VNuLprI= X-Google-Smtp-Source: AGHT+IHalOQ/s3NxiyYDgT5G+ca4oEPzuDrE48u3GmuLSNbZCinbhI/Pfbda9fQysbueYW+MPNlitEcynwqbQEQ4c54= X-Received: by 2002:a05:6512:3b1e:b0:515:9185:652f with SMTP id f30-20020a0565123b1e00b005159185652fmr2480035lfv.33.1713464401599; Thu, 18 Apr 2024 11:20:01 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240414175300.956243-1-aren@peacevolution.org> <20240414175716.958831-1-aren@peacevolution.org> <20240414175716.958831-2-aren@peacevolution.org> In-Reply-To: From: Andy Shevchenko Date: Thu, 18 Apr 2024 21:19:24 +0300 Message-ID: Subject: Re: [PATCH 2/4] iio: light: stk3310: Implement vdd supply and power it off during suspend To: Aren Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Liam Girdwood , Mark Brown , Ondrej Jirman , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , linux-iio@vger.kernel.org, phone-devel@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Willow Barraco Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Apr 18, 2024 at 8:50=E2=80=AFPM Aren wrote= : > On Thu, Apr 18, 2024 at 06:56:09PM +0300, Andy Shevchenko wrote: > > On Thu, Apr 18, 2024 at 6:06=E2=80=AFPM Aren w= rote: > > > On Mon, Apr 15, 2024 at 05:04:53PM +0300, Andy Shevchenko wrote: > > > > On Sun, Apr 14, 2024 at 8:57=E2=80=AFPM Aren Moynihan wrote: ... > > > > I forgot to check the order of freeing resources, be sure you have = no > > > > devm_*() releases happening before this call. > > > > > > If I understand what you're saying, this should be fine. The driver j= ust > > > uses devm to clean up acquired resources after remove is called. Or a= m I > > > missing something and resources could be freed before calling > > > stk3310_remove? > > > > I'm not objecting to that. The point here is that the resources should > > be freed in the reversed order. devm-allocated resources are deferred > > to be freed after the explicit driver ->remove() callback. At the end > > it should not interleave with each other, i.o.w. it should be > > probe: devm followed by non-devm > > remove: non-devm only. > > I think what you're describing is already the case, with the exception > of parts of the probe function not changed in this patch mixing > acquiring resources through devm with configuring the device. Okay, then we are fine! > I hope I'm not being dense, thanks for the clarification --=20 With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 398F2C4345F for ; Thu, 18 Apr 2024 18:20:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3AgtkH6BkwCf3lGhPYmiJlo3oLoiho/vpOvbtlF4NfM=; b=YWUuM+ynX/Xriu rnxhxdisumpfh48B/ckaVjZsjUyvhQTW5QELwaL6aVP3XZXNh0paomtrfF+WC9cZlWHxFQAJHrUxO ZU4IWrfRZhxDwWwIxgXv70htBpDeP0q9wM7uyi0VHT2qQ/GhDQLVoY+bDzZ0mefUgbOJUlLHHUHzX SEB3CD7X9Z0DmeDDAYI0yO8sx7VApRAmn7K9rwPKvu+niuocFc4CKJdGa70x1wuemgUSLgFVt++AP VYlNVNLMBRIeueeBD4ijvTvFR5QgxoOgTbOO2uS7iy6JU5QBkEO2AFO0ZFTNXwoYZDYHRuTIWC9So cIRnbzHM2lJjZ/Hsdq3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxWMm-00000003Jrv-2FDW; Thu, 18 Apr 2024 18:20:12 +0000 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxWMj-00000003JqI-2CZe for linux-arm-kernel@lists.infradead.org; Thu, 18 Apr 2024 18:20:10 +0000 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-518a56cdc03so1349659e87.1 for ; Thu, 18 Apr 2024 11:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713464402; x=1714069202; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eG3q+zpUjWVOdPOZkaSjqo0usEFxFJPlILtnK4zyysA=; b=d1RRq1O53mXUHRoGurGDH5WHiihz80UMmkkR63V917wPxzKtL3+Jp4X1RrCHpYJGUw xy98iVosVXnVKuYlWRuwwbIMa6iu4SmfO72tCWUlRQ5gtJG/RUXLVJesSGAblSMTSldN 6wImbejMoaq1fy8mTCUqYVGNpKGD7GnP0Mm8Q7w1/CVpXxVMQ81h8eshfuncM3PeuXue 4nkQcA5Qfp9XTKqK+s7ZbdYO8vllkS1l+pH12XcZu4WRPE/rq/tcCPzAxdCRkD8gRFx1 6JVVM0pLHchRDdUroLizrnGzXTpIt7TbgjhV+aVxgka1t1Mp5SaueXE0S1PT2zK5FxZJ 8opQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713464402; x=1714069202; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eG3q+zpUjWVOdPOZkaSjqo0usEFxFJPlILtnK4zyysA=; b=gCZkSoNFD/GFj2u5Aouc9bGyGr5qPaK9HKbXsRkSz1zb5ag4S0BNIQ8g/cYk3SMP9X +BBu7zL0ljqiRnAw3a1eza78fR48LTGvnvKkDPxGzaBRj+WkOKS1j505BItwMr4HY0fZ sR7KxMQdgytqKf3XM0ohKxsDMUfac4NEniYMmVg7Q82d3Y78Cs1vDs8Q5rLjJu909H91 97M0URenQPf1j9QDmv0C++Fu34JGEYHogQ/hnW0XrFkgzd4dkWR1OBPUNJ1MrKPJEBgr FjwDsIW/hpj8iuI45+zX19TWhe1b3DX9lLi2DzD9/T57nEtcp8p41ABmTbIEofsLRgXD VPXQ== X-Forwarded-Encrypted: i=1; AJvYcCUSA31CYn4ewsSJA0dWcKkPICzFVbnAiTcWuwfL43KnXx60rJqolWHX31Cy/hlhuPrYoI+kaY8r7CDLq1vlQVwZ1vykfK8puDv7r4WX2LLEbXFfLC0= X-Gm-Message-State: AOJu0Yz9jarsLNvhi1GinyDghjuV/N2I4lfvPmBL+ICZA5FPVV6DRA05 4S1W9lAjDhwWmREw6cNm8lpVpXWYldLAg4agc9CJUKyc/wtcJw266eCl9oBZzWlseQN3mLfSMCG dplaxyBJh0x6W60TTYRuISIFj2OI= X-Google-Smtp-Source: AGHT+IHalOQ/s3NxiyYDgT5G+ca4oEPzuDrE48u3GmuLSNbZCinbhI/Pfbda9fQysbueYW+MPNlitEcynwqbQEQ4c54= X-Received: by 2002:a05:6512:3b1e:b0:515:9185:652f with SMTP id f30-20020a0565123b1e00b005159185652fmr2480035lfv.33.1713464401599; Thu, 18 Apr 2024 11:20:01 -0700 (PDT) MIME-Version: 1.0 References: <20240414175300.956243-1-aren@peacevolution.org> <20240414175716.958831-1-aren@peacevolution.org> <20240414175716.958831-2-aren@peacevolution.org> In-Reply-To: From: Andy Shevchenko Date: Thu, 18 Apr 2024 21:19:24 +0300 Message-ID: Subject: Re: [PATCH 2/4] iio: light: stk3310: Implement vdd supply and power it off during suspend To: Aren Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Liam Girdwood , Mark Brown , Ondrej Jirman , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , linux-iio@vger.kernel.org, phone-devel@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Willow Barraco X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240418_112009_589630_F99D5792 X-CRM114-Status: GOOD ( 23.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBcHIgMTgsIDIwMjQgYXQgODo1MOKAr1BNIEFyZW4gPGFyZW5AcGVhY2V2b2x1dGlv bi5vcmc+IHdyb3RlOgo+IE9uIFRodSwgQXByIDE4LCAyMDI0IGF0IDA2OjU2OjA5UE0gKzAzMDAs IEFuZHkgU2hldmNoZW5rbyB3cm90ZToKPiA+IE9uIFRodSwgQXByIDE4LCAyMDI0IGF0IDY6MDbi gK9QTSBBcmVuIDxhcmVuQHBlYWNldm9sdXRpb24ub3JnPiB3cm90ZToKPiA+ID4gT24gTW9uLCBB cHIgMTUsIDIwMjQgYXQgMDU6MDQ6NTNQTSArMDMwMCwgQW5keSBTaGV2Y2hlbmtvIHdyb3RlOgo+ ID4gPiA+IE9uIFN1biwgQXByIDE0LCAyMDI0IGF0IDg6NTfigK9QTSBBcmVuIE1veW5paGFuIDxh cmVuQHBlYWNldm9sdXRpb24ub3JnPiB3cm90ZToKCi4uLgoKPiA+ID4gPiBJIGZvcmdvdCB0byBj aGVjayB0aGUgb3JkZXIgb2YgZnJlZWluZyByZXNvdXJjZXMsIGJlIHN1cmUgeW91IGhhdmUgbm8K PiA+ID4gPiBkZXZtXyooKSByZWxlYXNlcyBoYXBwZW5pbmcgYmVmb3JlIHRoaXMgY2FsbC4KPiA+ ID4KPiA+ID4gSWYgSSB1bmRlcnN0YW5kIHdoYXQgeW91J3JlIHNheWluZywgdGhpcyBzaG91bGQg YmUgZmluZS4gVGhlIGRyaXZlciBqdXN0Cj4gPiA+IHVzZXMgZGV2bSB0byBjbGVhbiB1cCBhY3F1 aXJlZCByZXNvdXJjZXMgYWZ0ZXIgcmVtb3ZlIGlzIGNhbGxlZC4gT3IgYW0gSQo+ID4gPiBtaXNz aW5nIHNvbWV0aGluZyBhbmQgcmVzb3VyY2VzIGNvdWxkIGJlIGZyZWVkIGJlZm9yZSBjYWxsaW5n Cj4gPiA+IHN0azMzMTBfcmVtb3ZlPwo+ID4KPiA+IEknbSBub3Qgb2JqZWN0aW5nIHRvIHRoYXQu IFRoZSBwb2ludCBoZXJlIGlzIHRoYXQgdGhlIHJlc291cmNlcyBzaG91bGQKPiA+IGJlIGZyZWVk IGluIHRoZSByZXZlcnNlZCBvcmRlci4gZGV2bS1hbGxvY2F0ZWQgcmVzb3VyY2VzIGFyZSBkZWZl cnJlZAo+ID4gdG8gYmUgZnJlZWQgYWZ0ZXIgdGhlIGV4cGxpY2l0IGRyaXZlciAtPnJlbW92ZSgp IGNhbGxiYWNrLiBBdCB0aGUgZW5kCj4gPiBpdCBzaG91bGQgbm90IGludGVybGVhdmUgd2l0aCBl YWNoIG90aGVyLCBpLm8udy4gaXQgc2hvdWxkIGJlCj4gPiBwcm9iZTogZGV2bSBmb2xsb3dlZCBi eSBub24tZGV2bQo+ID4gcmVtb3ZlOiBub24tZGV2bSBvbmx5Lgo+Cj4gSSB0aGluayB3aGF0IHlv dSdyZSBkZXNjcmliaW5nIGlzIGFscmVhZHkgdGhlIGNhc2UsIHdpdGggdGhlIGV4Y2VwdGlvbgo+ IG9mIHBhcnRzIG9mIHRoZSBwcm9iZSBmdW5jdGlvbiBub3QgY2hhbmdlZCBpbiB0aGlzIHBhdGNo IG1peGluZwo+IGFjcXVpcmluZyByZXNvdXJjZXMgdGhyb3VnaCBkZXZtIHdpdGggY29uZmlndXJp bmcgdGhlIGRldmljZS4KCk9rYXksIHRoZW4gd2UgYXJlIGZpbmUhCgo+IEkgaG9wZSBJJ20gbm90 IGJlaW5nIGRlbnNlLCB0aGFua3MgZm9yIHRoZSBjbGFyaWZpY2F0aW9uCgotLSAKV2l0aCBCZXN0 IFJlZ2FyZHMsCkFuZHkgU2hldmNoZW5rbwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=