From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1A6116D4C0; Thu, 18 Apr 2024 15:56:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713455810; cv=none; b=qZPtc5QQB9KNOeIpV6MFqsAKGWuqtGIf8Mn14Jq45hgWR0jfg0p7ftScnufpVYHPaaZptDze2LXvXrO1rCe1BJsYfuJm/a7r40BJxEKuw+brm76ckZeiI6ngaySS5/0cS1QPO7sQVJEpmM/7Z96QxYH3tcK8KP7F/LOIiIVbFeI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713455810; c=relaxed/simple; bh=aBUT2+pQDzYwiVZKUr+Rvc3cYxV7V4n7dBGY3Vt9cNM=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=dxU5bt75kgLHZzrf338bXiHz3YasJfvsje+B2MHB5NEJGhEzTyPXSzwMTR6InmdS/1WJEYkIQVSeNojuYjxcn/ZcNLoM/bEX+rkZzk/U/psSYg41v3hxNRZ9VCZ9npZJLJ9Gzw2YIwpZOW1lXlptsJ1BBSif0BSrFJpC8S2uyL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YNp3qgbJ; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YNp3qgbJ" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-518a56cdbcfso1698772e87.2; Thu, 18 Apr 2024 08:56:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713455807; x=1714060607; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yVAgtcipfkcWMHjlW6nU5upWM2mMxhSXqMN6JngOSHk=; b=YNp3qgbJrbjjBWuirX0TRgGuMKJqG6tJzt4WupmJYKCTK52NTWYZSAP4lMn47lGdGb Ix6KiGEKGdscZ9pUGRYS7hYxAsFn2AfUb9f10fVVXB6L1Sbf7AdZNU7EdCaVWYZ++JOi zaenZ9OflDADMvtqCFkyFXoDur6MyLaGI1s8R3m52Rr/wXJ+0jgWSPAUd5r5RMCj6ABV q9Ex9HQRSBQ04jVY0pHtfhO3J7+94dwMpRdNyY7ThIC2MUg2iZuxG71/jca8XW3LmD8D zfK/6HaVFRl/tT3KpyU6xPNE+urxfzW/BQOMrocNU/1NQx6rb2E9mWd33bg1X7rI2w7S 20pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713455807; x=1714060607; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yVAgtcipfkcWMHjlW6nU5upWM2mMxhSXqMN6JngOSHk=; b=wiwpgrULwyy9w7ALnutQLw+RqJou65g7ogP24sj7DYqtVBxS+4IJHrgfaUNQz7yC9d 6rNrJNVzxxfnapriaEF6KDHAvuYK/bWcXojzvIF4eB20OqMeka9rRnQMzL56zYEit7W9 vApcbJIgqUqITLyJ9EWNjid0VtI75zU6dC0DwkOZL2cZVvMeQY8AeFcwVAErKNNGBOX/ x84+NADKDTjLULI9b/ASWzjE0pXh9QiFcvDegfblX9JZh9XStrV/S3veoW777UZ7q0WM qbhKAbYP6pIQk+yfen1aDlTD5QgrRUmW+hvPt0ot6JTZT89qbHSf0MUnci1bnkVuvcdB 2IOQ== X-Forwarded-Encrypted: i=1; AJvYcCXQ+dSxK7wXtO/IXUt0d1I2NkApT0TgGDt/z6bea2eOQflBZJoYlQeqpgYATJoILUQW+jL6RYb8o53FO8arGKZy0aQ5TU6iSxBAJB4Itorwt6cr8P0Dqgka2gxZL0kw+jwUNZO7tskmpDOU/pzNr/n3rG64ycE7C5f0UwR/BUZGcTT8IL4ra3QuiOd/RrT3eprKllsyTXvSCavSpaDnub84 X-Gm-Message-State: AOJu0YxLvm1D+bGd9fBt9FX9PlTyYgYJop4k3UDwJIwESt/FILNGFRHe AP0MX2jyiR0kJnZ0k9NeSkuLHahHsC4pmJm71Ps5iGV82Goedr2bw2UgUorNHjq+kmDTwQvcow3 6Rsxu/4mEZ8imtnrfOPspKnMDZFg= X-Google-Smtp-Source: AGHT+IG1UvVvPMawq0PN1G95h2KMXcAMXcVnwWBMLVJAP/s7QKISoICSyXIA62E97yFHemf7G8s5MxQ9F1kvhWxIZAo= X-Received: by 2002:a2e:8383:0:b0:2da:b1fc:8095 with SMTP id x3-20020a2e8383000000b002dab1fc8095mr2163555ljg.7.1713455806891; Thu, 18 Apr 2024 08:56:46 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240414175300.956243-1-aren@peacevolution.org> <20240414175716.958831-1-aren@peacevolution.org> <20240414175716.958831-2-aren@peacevolution.org> In-Reply-To: From: Andy Shevchenko Date: Thu, 18 Apr 2024 18:56:09 +0300 Message-ID: Subject: Re: [PATCH 2/4] iio: light: stk3310: Implement vdd supply and power it off during suspend To: Aren Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Liam Girdwood , Mark Brown , Ondrej Jirman , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , linux-iio@vger.kernel.org, phone-devel@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Willow Barraco Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Apr 18, 2024 at 6:06=E2=80=AFPM Aren wrote= : > On Mon, Apr 15, 2024 at 05:04:53PM +0300, Andy Shevchenko wrote: > > On Sun, Apr 14, 2024 at 8:57=E2=80=AFPM Aren Moynihan wrote: ... > > > stk3310_set_state(iio_priv(indio_dev), STK3310_STATE_STANDBY)= ; > > > + if (data->vdd_reg) > > > + regulator_disable(data->vdd_reg); > > > > I forgot to check the order of freeing resources, be sure you have no > > devm_*() releases happening before this call. > > If I understand what you're saying, this should be fine. The driver just > uses devm to clean up acquired resources after remove is called. Or am I > missing something and resources could be freed before calling > stk3310_remove? I'm not objecting to that. The point here is that the resources should be freed in the reversed order. devm-allocated resources are deferred to be freed after the explicit driver ->remove() callback. At the end it should not interleave with each other, i.o.w. it should be probe: devm followed by non-devm remove: non-devm only. --=20 With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C77D2C04FF8 for ; Thu, 18 Apr 2024 15:57:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9r/5F41SphJQklY5AqqDa1OoUmqxJckDAElTKye/5d8=; b=i8idKjT+oF8v6D dIEMlmgEck6cKZEqV3hL2Hair5tAu5+TdM3RHE2NCXpcPlaE+pD64Yg8nMAhHZfH3fQEBfcQUir6z 3+gSRRFPcQXD7UGfu7cfR31aKueSZR23vpH/eQ1Pv+zMtIPdgpT63D/0AJCuVD0ZkdDuPNDAREpca Le2h0BoOt2O6wX6L85vS2BQ2l3R+/tiJYPScvDrFbUs4KvxkA/Sg5ITUtQ9nRDgznIUApEnwzXZWa 3m/B4KonEBtikXrVGUEaGLR21GBVorqAM3Aj05+1REEpXIxYRV8C5yF4Mzoslgb2GXsxtYBmP8O75 +Kg1WeJGoxLMVo9lkYIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxU87-00000002uGU-3zxd; Thu, 18 Apr 2024 15:56:56 +0000 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxU82-00000002uFA-3b8w for linux-arm-kernel@lists.infradead.org; Thu, 18 Apr 2024 15:56:52 +0000 Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2db2f6cb312so20111261fa.2 for ; Thu, 18 Apr 2024 08:56:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713455807; x=1714060607; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yVAgtcipfkcWMHjlW6nU5upWM2mMxhSXqMN6JngOSHk=; b=VFtD87z3ChvO6H6c8DY1/LjYA6FIVRaQTtzAOcOFZ6ajxfKCsx3BV/0eml08BiwA7u N941LI9JzWWPH7BJNH9eLNzazI/z/0jla9JeVjKSuJkQBE5rv0zvqcbPn+hUSe01Tu92 DbRkoX8On0STTxbVY0RiuALzG4ckgjgSG7SUjx0w3bB56oL0acC1OEwT6gpRmGdniL7t XsJ6jRnqVgu5fy0Ob53BbBNMQEzKdZnzhiIrxM8YnPquhXV4r10w87dZdHhCttu3o9mT utK/5nWfqbO3+TQFeiWnmgMZVeZ4a0c2b8bt3WrcnvzFpMuh+so1FcwAbf6pZ7OQDg3y W7NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713455807; x=1714060607; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yVAgtcipfkcWMHjlW6nU5upWM2mMxhSXqMN6JngOSHk=; b=r1BQ4agfr5DWEoD1SqtE2kgNYfcXI8K+VvwcIN7U3y+iM9Gqd9pHw3ey7x/+n4Zem4 CgyLwSFQ/mGKuveL+PEPJte3f1TekXaE9EaXJyVdjamFd2w5DmGI77ek5LXMttP1yoMK otvrEHpg/v/GMvBBSeWtbbliY7XaSBFrPoVWijBfd+mOrctwgOiNCSbmq+yVlHFqRgtP GZSv1fyU/VKKdB3+C1U7Yx7+WcChQizd1sEJCHitMVSVoPA+kG/ZCTcuFCiquaHuC5Z7 9dpgmysb+rRyClEhdKXPhmQRmjA+M0x1DH6w5A+2+ltqwWtT7gLyn5WsOTHq7sJIA6Bs n0aA== X-Forwarded-Encrypted: i=1; AJvYcCXQALFs/kvqigFdTATZlIqvg/j7kb98+3cMXiejMeOpmg2OgZu4aYqyMJ3psUzP4lHgKFHoiCxyF2MuhiX7pQimUaa4JvGkUtncSPsl7PQ1HCCMLKY= X-Gm-Message-State: AOJu0YwA+053xKyfg7uQlsHeiDHV3Hzj7sxTydFRejHXrU3TvJ10QNIJ d/jX2HzvMVGuGLcEqB+hixt26LFnI4E1tE0eXxZdyFjwtGIPkHhRF66KxvZIzwPJnz/1RjCkwPU 547E0QlyQCF4++IYmseoGKQNEyME= X-Google-Smtp-Source: AGHT+IG1UvVvPMawq0PN1G95h2KMXcAMXcVnwWBMLVJAP/s7QKISoICSyXIA62E97yFHemf7G8s5MxQ9F1kvhWxIZAo= X-Received: by 2002:a2e:8383:0:b0:2da:b1fc:8095 with SMTP id x3-20020a2e8383000000b002dab1fc8095mr2163555ljg.7.1713455806891; Thu, 18 Apr 2024 08:56:46 -0700 (PDT) MIME-Version: 1.0 References: <20240414175300.956243-1-aren@peacevolution.org> <20240414175716.958831-1-aren@peacevolution.org> <20240414175716.958831-2-aren@peacevolution.org> In-Reply-To: From: Andy Shevchenko Date: Thu, 18 Apr 2024 18:56:09 +0300 Message-ID: Subject: Re: [PATCH 2/4] iio: light: stk3310: Implement vdd supply and power it off during suspend To: Aren Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Liam Girdwood , Mark Brown , Ondrej Jirman , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , linux-iio@vger.kernel.org, phone-devel@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Willow Barraco X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240418_085650_940377_DD4E0CE1 X-CRM114-Status: GOOD ( 18.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBcHIgMTgsIDIwMjQgYXQgNjowNuKAr1BNIEFyZW4gPGFyZW5AcGVhY2V2b2x1dGlv bi5vcmc+IHdyb3RlOgo+IE9uIE1vbiwgQXByIDE1LCAyMDI0IGF0IDA1OjA0OjUzUE0gKzAzMDAs IEFuZHkgU2hldmNoZW5rbyB3cm90ZToKPiA+IE9uIFN1biwgQXByIDE0LCAyMDI0IGF0IDg6NTfi gK9QTSBBcmVuIE1veW5paGFuIDxhcmVuQHBlYWNldm9sdXRpb24ub3JnPiB3cm90ZToKCi4uLgoK PiA+ID4gICAgICAgICBzdGszMzEwX3NldF9zdGF0ZShpaW9fcHJpdihpbmRpb19kZXYpLCBTVEsz MzEwX1NUQVRFX1NUQU5EQlkpOwo+ID4gPiArICAgICAgIGlmIChkYXRhLT52ZGRfcmVnKQo+ID4g PiArICAgICAgICAgICAgICAgcmVndWxhdG9yX2Rpc2FibGUoZGF0YS0+dmRkX3JlZyk7Cj4gPgo+ ID4gSSBmb3Jnb3QgdG8gY2hlY2sgdGhlIG9yZGVyIG9mIGZyZWVpbmcgcmVzb3VyY2VzLCBiZSBz dXJlIHlvdSBoYXZlIG5vCj4gPiBkZXZtXyooKSByZWxlYXNlcyBoYXBwZW5pbmcgYmVmb3JlIHRo aXMgY2FsbC4KPgo+IElmIEkgdW5kZXJzdGFuZCB3aGF0IHlvdSdyZSBzYXlpbmcsIHRoaXMgc2hv dWxkIGJlIGZpbmUuIFRoZSBkcml2ZXIganVzdAo+IHVzZXMgZGV2bSB0byBjbGVhbiB1cCBhY3F1 aXJlZCByZXNvdXJjZXMgYWZ0ZXIgcmVtb3ZlIGlzIGNhbGxlZC4gT3IgYW0gSQo+IG1pc3Npbmcg c29tZXRoaW5nIGFuZCByZXNvdXJjZXMgY291bGQgYmUgZnJlZWQgYmVmb3JlIGNhbGxpbmcKPiBz dGszMzEwX3JlbW92ZT8KCkknbSBub3Qgb2JqZWN0aW5nIHRvIHRoYXQuIFRoZSBwb2ludCBoZXJl IGlzIHRoYXQgdGhlIHJlc291cmNlcyBzaG91bGQKYmUgZnJlZWQgaW4gdGhlIHJldmVyc2VkIG9y ZGVyLiBkZXZtLWFsbG9jYXRlZCByZXNvdXJjZXMgYXJlIGRlZmVycmVkCnRvIGJlIGZyZWVkIGFm dGVyIHRoZSBleHBsaWNpdCBkcml2ZXIgLT5yZW1vdmUoKSBjYWxsYmFjay4gQXQgdGhlIGVuZApp dCBzaG91bGQgbm90IGludGVybGVhdmUgd2l0aCBlYWNoIG90aGVyLCBpLm8udy4gaXQgc2hvdWxk IGJlCnByb2JlOiBkZXZtIGZvbGxvd2VkIGJ5IG5vbi1kZXZtCnJlbW92ZTogbm9uLWRldm0gb25s eS4KCi0tIApXaXRoIEJlc3QgUmVnYXJkcywKQW5keSBTaGV2Y2hlbmtvCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==