From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D32F4D110; Fri, 19 Apr 2024 15:54:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713542094; cv=none; b=GZogLUkbWZcpLeaYCu7dfl1IEws30okDqJwNaU1pp7V+DgVj4YBgsqv/RPhtwYtPw5bV2b/Nn4pLREx6cc3bN+fw4xG10uJ8tnh+oOjUolqTcfQRpBgObGixqBZT6AIEKttgLE51HihqyJ00shVlAOzhmjNufP60kXBctAXZGR0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713542094; c=relaxed/simple; bh=PNzXHy/tRctT7iPO4Hxb0l/pQDROtMOUfttALn8mdWw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=NxcRdP1wmiWhup38lOTDE3rtLqTkgnEcNdlkKrxU3XlK8e7aJv4HecJH0mc8Bxx5Af4JmSE1ubVAdaZy7kCyqAIMDUtojakWCSoJoDRGu5bnxAYCdtBzFfXq11r6W0izBzshyRYr1JSWDC/WvdPZZEuDToj32vSeKp5fiA8HsEY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fByrY0sH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fByrY0sH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB14EC4AF0C; Fri, 19 Apr 2024 15:54:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713542093; bh=PNzXHy/tRctT7iPO4Hxb0l/pQDROtMOUfttALn8mdWw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=fByrY0sH7ehrB3/T0K5Y9m7KyxBgkDIAjJKJuL060ZMwVeA4sxNa1GRVnnFs7o9P/ SDdNCkMFupB33Yh4SqtQQRDg1TlSaSNl85qqrhlrbsWngFTomx7MtHK/VLSFjgeKVE WNXe0s/Zd7ZSyO8H9gkYMP5F2v3IZpievZBQF2TWpbBzXIh05HyDtTK2ztWOy1AyUk 8uKc4i1XerG3TPen7GqtNdAuJI8XdGlZHRUBtPaskIQyoqsVYLmOl4HnlPuLJecHlE WlI2arE63IBCyRuPBGezgCucj+RhNyvFxP1+bhxs9GMQJQgOXAjn2wix5rZL/xXKdE HGfwsw/94YlBg== Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-51abd580902so740582e87.1; Fri, 19 Apr 2024 08:54:53 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXa3apZAcErtrAYm9kCGGH7b5EHxRQGYbrJdPt05jNB+QXG51rb9gkY1tsQrNt8RIsyv415Yc2kTkhWK6mvhIfP97KTLuf4OQhlJIfy9j3E6yYK6wMTqPbXrQcJnOZa8KHbuXuaHGgvOy5ettOjdr6e+C8ZgUL4AiwpNGcL5Zk9iaH61JAultjYsHw/QYjziVYXelXMlZcu3djtASeL6kKnKJR5LpIPOYNdE+QKoeI+H7VcR+Ygx1k/5gQKkkgQ7GRCovyM+s6COMyQfaucZ48T3H+01PZVowPAZ780i598z0os5XzdDz1+MZK2s2XrfWaTlE+sNa4aMiZYbusgEBxKB9U8gByesml/d8A2CvGFWajSsp7F0FWM4zzqmiSpzPn1xpQqSYWGOPBl/tpTCVrYNpASlRZVnL9I0ucaU0BHZmwJDWnmOslBrqI= X-Gm-Message-State: AOJu0YwzwSIXOL1lwLx1RpSeVcmnS/tsXUdOv0hyQs698d7F4H3OCX/O ZSd4XS6q9+YHuUbcrvH55H1Uk1J9BYzXCfERuBEYxgLVjoCoHEKs3DU7SnnmHu3MgsXH4FvTMln XD27rqGH3DMHNgjDUSYdCoUz5GJE= X-Google-Smtp-Source: AGHT+IGasMltj1XTiWxWNEYkPSMxwP63y2jyTt8tLpdHn26unpYTPPkYdRp/dT6gEwD6NrNiKXUtIlL7PF9cDNubUq4= X-Received: by 2002:ac2:5f9b:0:b0:519:ab33:7459 with SMTP id r27-20020ac25f9b000000b00519ab337459mr752898lfe.30.1713542091952; Fri, 19 Apr 2024 08:54:51 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240411160051.2093261-1-rppt@kernel.org> <20240411160051.2093261-6-rppt@kernel.org> <20240415075241.GF40213@noisy.programming.kicks-ass.net> In-Reply-To: From: Song Liu Date: Fri, 19 Apr 2024 08:54:40 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free() To: Mike Rapoport Cc: Mark Rutland , Peter Zijlstra , linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , Bjorn Topel , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Apr 18, 2024 at 11:56=E2=80=AFPM Mike Rapoport wr= ote: > > On Thu, Apr 18, 2024 at 02:01:22PM -0700, Song Liu wrote: > > On Thu, Apr 18, 2024 at 10:54=E2=80=AFAM Mike Rapoport wrote: > > > > > > On Thu, Apr 18, 2024 at 09:13:27AM -0700, Song Liu wrote: > > > > On Thu, Apr 18, 2024 at 8:37=E2=80=AFAM Mike Rapoport wrote: > > > > > > > > > > > > > > I'm looking at execmem_types more as definition of the consum= ers, maybe I > > > > > > > should have named the enum execmem_consumer at the first plac= e. > > > > > > > > > > > > I think looking at execmem_type from consumers' point of view a= dds > > > > > > unnecessary complexity. IIUC, for most (if not all) archs, ftra= ce, kprobe, > > > > > > and bpf (and maybe also module text) all have the same requirem= ents. > > > > > > Did I miss something? > > > > > > > > > > It's enough to have one architecture with different constrains fo= r kprobes > > > > > and bpf to warrant a type for each. > > > > > > > > AFAICT, some of these constraints can be changed without too much w= ork. > > > > > > But why? > > > I honestly don't understand what are you trying to optimize here. A f= ew > > > lines of initialization in execmem_info? > > > > IIUC, having separate EXECMEM_BPF and EXECMEM_KPROBE makes it > > harder for bpf and kprobe to share the same ROX page. In many use cases= , > > a 2MiB page (assuming x86_64) is enough for all BPF, kprobe, ftrace, an= d > > module text. It is not efficient if we have to allocate separate pages = for each > > of these use cases. If this is not a problem, the current approach work= s. > > The caching of large ROX pages does not need to be per type. > > In the POC I've posted for caching of large ROX pages on x86 [1], the cac= he is > global and to make kprobes and bpf use it it's enough to set a flag in > execmem_info. > > [1] https://lore.kernel.org/all/20240411160526.2093408-1-rppt@kernel.org For the ROX to work, we need different users (module text, kprobe, etc.) to= have the same execmem_range. From [1]: static void *execmem_cache_alloc(struct execmem_range *range, size_t size) { ... p =3D __execmem_cache_alloc(size); if (p) return p; err =3D execmem_cache_populate(range, size); ... } We are calling __execmem_cache_alloc() without range. For this to work, we can only call execmem_cache_alloc() with one execmem_range. Did I miss something? Thanks, Song From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF32EC04FF6 for ; Fri, 19 Apr 2024 15:55:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LaDx9PxC/zOxd/vYY2GkGrdT5jmp4yNP5qtXqo9noIw=; b=uRvVhdeTv/gg+L uzcjt9f1MQdm8RgO5sSUs27hHLBc5nV90hiATNxHDmlthL7954Fejm5hrW2BdWxVzrysIIHZ63XIM FJVZotBGyomB5JDoPr0RXFQkJfmIFx7vSAfJmFjZ7Wr5+h1Pwl5ZokGWfgzwa8t+b6QE55kdBUWUv Wrl1M8MEh3ObSAq6ka+kaigG9sPy6NQJbREOTrbXwWQTflVCYAOP1aclLdJFg4N+Slbk0M3qyPMtn cixmwH+BG6D3wOkO9AlFTFCZTfRSf2+liOh0x5Ni6gmQzM22tDAaQB1zBKPDMN5cYCg0Y2aVsWaDd VcCimmP6PamOULEHJ3oQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxqaA-00000006GRL-0ihj; Fri, 19 Apr 2024 15:55:22 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxqa5-00000006GPB-0FZx; Fri, 19 Apr 2024 15:55:19 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1730CCE1AF8; Fri, 19 Apr 2024 15:55:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A421C32782; Fri, 19 Apr 2024 15:55:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713542114; bh=PNzXHy/tRctT7iPO4Hxb0l/pQDROtMOUfttALn8mdWw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=pqf8XrEo/ZXtoYY6s3PyoZrVaUFPmoHxFRVaIVD+cv3s9s0b57yKCkZBfgw3J/DFY ItFu/AL8+h/o6KzZv3W/jgdaahJ+fBSkuBMaq6Fa9gIV+jIx0BRXS0xUN7/X5dBPCS CtUI7XjfYrMseAEBlWGp1/BlZfgiFr+70fAxlZPMxdU8CUsp8cqjeiGh7fSLDtYeJ4 ci293wBMZSj5XVodFvDDRPQI2WnRMIxx356QO12oxl9Vr7bTlPCN/kbkpDTGdnUTk0 OJtvbGt6roHNq6+muZAwUQgB2hXjVyHoavfSajpvVRjHUvmn/YdlEKZxa/rSjatbO9 x3piRqi1B5HPQ== Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a5224dfa9adso386573966b.0; Fri, 19 Apr 2024 08:55:14 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUbSEaOLTvYn1+6epyB4GTZd83L9TITCRIWq9ot0baEDDmJsBnKZ9Zos794cqIJPVZshVAw55QC/eGcEy4mA02gR7px4EP9/Fw1U9Aof0ldjdmzrPAvVyvWkFUhPvV7mHOupbR08mfwUJQNee4jF1GgjWpTS9I= X-Gm-Message-State: AOJu0Yx8ExfrD7t4udsoJTo3gMikdNHpwvdKvZVqU2Xv6PFA5IzBF1NQ 2xCiFgUOqnXHoyRb9UiQJEJVfZrcpqDm+RaUdzKp2EYo7HCAQCbeF7Q6t9fQttkMkpSxIwPZrwe nLQT6eyDKBxYdfCUf0C+wBhrjXmo= X-Google-Smtp-Source: AGHT+IGasMltj1XTiWxWNEYkPSMxwP63y2jyTt8tLpdHn26unpYTPPkYdRp/dT6gEwD6NrNiKXUtIlL7PF9cDNubUq4= X-Received: by 2002:ac2:5f9b:0:b0:519:ab33:7459 with SMTP id r27-20020ac25f9b000000b00519ab337459mr752898lfe.30.1713542091952; Fri, 19 Apr 2024 08:54:51 -0700 (PDT) MIME-Version: 1.0 References: <20240411160051.2093261-1-rppt@kernel.org> <20240411160051.2093261-6-rppt@kernel.org> <20240415075241.GF40213@noisy.programming.kicks-ass.net> In-Reply-To: From: Song Liu Date: Fri, 19 Apr 2024 08:54:40 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free() To: Mike Rapoport Cc: Mark Rutland , Peter Zijlstra , linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , Bjorn Topel , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240419_085517_471956_DF5D2C9F X-CRM114-Status: GOOD ( 23.89 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBcHIgMTgsIDIwMjQgYXQgMTE6NTbigK9QTSBNaWtlIFJhcG9wb3J0IDxycHB0QGtl cm5lbC5vcmc+IHdyb3RlOgo+Cj4gT24gVGh1LCBBcHIgMTgsIDIwMjQgYXQgMDI6MDE6MjJQTSAt MDcwMCwgU29uZyBMaXUgd3JvdGU6Cj4gPiBPbiBUaHUsIEFwciAxOCwgMjAyNCBhdCAxMDo1NOKA r0FNIE1pa2UgUmFwb3BvcnQgPHJwcHRAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPiA+Cj4gPiA+IE9u IFRodSwgQXByIDE4LCAyMDI0IGF0IDA5OjEzOjI3QU0gLTA3MDAsIFNvbmcgTGl1IHdyb3RlOgo+ ID4gPiA+IE9uIFRodSwgQXByIDE4LCAyMDI0IGF0IDg6MzfigK9BTSBNaWtlIFJhcG9wb3J0IDxy cHB0QGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gSSdtIGxv b2tpbmcgYXQgZXhlY21lbV90eXBlcyBtb3JlIGFzIGRlZmluaXRpb24gb2YgdGhlIGNvbnN1bWVy cywgbWF5YmUgSQo+ID4gPiA+ID4gPiA+IHNob3VsZCBoYXZlIG5hbWVkIHRoZSBlbnVtIGV4ZWNt ZW1fY29uc3VtZXIgYXQgdGhlIGZpcnN0IHBsYWNlLgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBJ IHRoaW5rIGxvb2tpbmcgYXQgZXhlY21lbV90eXBlIGZyb20gY29uc3VtZXJzJyBwb2ludCBvZiB2 aWV3IGFkZHMKPiA+ID4gPiA+ID4gdW5uZWNlc3NhcnkgY29tcGxleGl0eS4gSUlVQywgZm9yIG1v c3QgKGlmIG5vdCBhbGwpIGFyY2hzLCBmdHJhY2UsIGtwcm9iZSwKPiA+ID4gPiA+ID4gYW5kIGJw ZiAoYW5kIG1heWJlIGFsc28gbW9kdWxlIHRleHQpIGFsbCBoYXZlIHRoZSBzYW1lIHJlcXVpcmVt ZW50cy4KPiA+ID4gPiA+ID4gRGlkIEkgbWlzcyBzb21ldGhpbmc/Cj4gPiA+ID4gPgo+ID4gPiA+ ID4gSXQncyBlbm91Z2ggdG8gaGF2ZSBvbmUgYXJjaGl0ZWN0dXJlIHdpdGggZGlmZmVyZW50IGNv bnN0cmFpbnMgZm9yIGtwcm9iZXMKPiA+ID4gPiA+IGFuZCBicGYgdG8gd2FycmFudCBhIHR5cGUg Zm9yIGVhY2guCj4gPiA+ID4KPiA+ID4gPiBBRkFJQ1QsIHNvbWUgb2YgdGhlc2UgY29uc3RyYWlu dHMgY2FuIGJlIGNoYW5nZWQgd2l0aG91dCB0b28gbXVjaCB3b3JrLgo+ID4gPgo+ID4gPiBCdXQg d2h5Pwo+ID4gPiBJIGhvbmVzdGx5IGRvbid0IHVuZGVyc3RhbmQgd2hhdCBhcmUgeW91IHRyeWlu ZyB0byBvcHRpbWl6ZSBoZXJlLiBBIGZldwo+ID4gPiBsaW5lcyBvZiBpbml0aWFsaXphdGlvbiBp biBleGVjbWVtX2luZm8/Cj4gPgo+ID4gSUlVQywgaGF2aW5nIHNlcGFyYXRlIEVYRUNNRU1fQlBG IGFuZCBFWEVDTUVNX0tQUk9CRSBtYWtlcyBpdAo+ID4gaGFyZGVyIGZvciBicGYgYW5kIGtwcm9i ZSB0byBzaGFyZSB0aGUgc2FtZSBST1ggcGFnZS4gSW4gbWFueSB1c2UgY2FzZXMsCj4gPiBhIDJN aUIgcGFnZSAoYXNzdW1pbmcgeDg2XzY0KSBpcyBlbm91Z2ggZm9yIGFsbCBCUEYsIGtwcm9iZSwg ZnRyYWNlLCBhbmQKPiA+IG1vZHVsZSB0ZXh0LiBJdCBpcyBub3QgZWZmaWNpZW50IGlmIHdlIGhh dmUgdG8gYWxsb2NhdGUgc2VwYXJhdGUgcGFnZXMgZm9yIGVhY2gKPiA+IG9mIHRoZXNlIHVzZSBj YXNlcy4gSWYgdGhpcyBpcyBub3QgYSBwcm9ibGVtLCB0aGUgY3VycmVudCBhcHByb2FjaCB3b3Jr cy4KPgo+IFRoZSBjYWNoaW5nIG9mIGxhcmdlIFJPWCBwYWdlcyBkb2VzIG5vdCBuZWVkIHRvIGJl IHBlciB0eXBlLgo+Cj4gSW4gdGhlIFBPQyBJJ3ZlIHBvc3RlZCBmb3IgY2FjaGluZyBvZiBsYXJn ZSBST1ggcGFnZXMgb24geDg2IFsxXSwgdGhlIGNhY2hlIGlzCj4gZ2xvYmFsIGFuZCB0byBtYWtl IGtwcm9iZXMgYW5kIGJwZiB1c2UgaXQgaXQncyBlbm91Z2ggdG8gc2V0IGEgZmxhZyBpbgo+IGV4 ZWNtZW1faW5mby4KPgo+IFsxXSBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvMjAyNDA0MTEx NjA1MjYuMjA5MzQwOC0xLXJwcHRAa2VybmVsLm9yZwoKRm9yIHRoZSBST1ggdG8gd29yaywgd2Ug bmVlZCBkaWZmZXJlbnQgdXNlcnMgKG1vZHVsZSB0ZXh0LCBrcHJvYmUsIGV0Yy4pIHRvIGhhdmUK dGhlIHNhbWUgZXhlY21lbV9yYW5nZS4gRnJvbSBbMV06CgpzdGF0aWMgdm9pZCAqZXhlY21lbV9j YWNoZV9hbGxvYyhzdHJ1Y3QgZXhlY21lbV9yYW5nZSAqcmFuZ2UsIHNpemVfdCBzaXplKQp7Ci4u LgogICAgICAgcCA9IF9fZXhlY21lbV9jYWNoZV9hbGxvYyhzaXplKTsKICAgICAgIGlmIChwKQog ICAgICAgICAgICAgICByZXR1cm4gcDsKICAgICAgZXJyID0gZXhlY21lbV9jYWNoZV9wb3B1bGF0 ZShyYW5nZSwgc2l6ZSk7Ci4uLgp9CgpXZSBhcmUgY2FsbGluZyBfX2V4ZWNtZW1fY2FjaGVfYWxs b2MoKSB3aXRob3V0IHJhbmdlLiBGb3IgdGhpcyB0byB3b3JrLAp3ZSBjYW4gb25seSBjYWxsIGV4 ZWNtZW1fY2FjaGVfYWxsb2MoKSB3aXRoIG9uZSBleGVjbWVtX3JhbmdlLgoKRGlkIEkgbWlzcyBz b21ldGhpbmc/CgpUaGFua3MsClNvbmcKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89583C4345F for ; Fri, 19 Apr 2024 15:55:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pTB+F01BQL0qz17gA92CThPkXBMULV55UB9cF+Xaz3Y=; b=FnHYdzwReeSffF ZMLB0j4XOw+BF/a5TDLpzBnsrIjphnDpeMnS9/fiwdfmxwDToczGABEbkHkE/uX9NGR7n69oJ+KuP P6+iXnJjQmnJxBSlgtfBSiIcwm+p1yq/N9NwCSaced6H+oFEpTrKcVPi4HZDP8W7TpuYbFmtPvvMS liG/0q3EMsfKH2SqttmT8YJrScjhsqFiCzSK7LtAk9olOpnyTPZseBrASN1sXTCloJ3OWXDk5wo/4 qdny+8XtF8yXIfj2A/Subzuakh7L+tGTQCDZ8NkghntCZ7pntmrOq5OgsR95Oh4JmfISAH4I3kC/D No8D6B18KiR0/njwqlhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxqa9-00000006GQv-1ZUi; Fri, 19 Apr 2024 15:55:21 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxqa5-00000006GPB-0FZx; Fri, 19 Apr 2024 15:55:19 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1730CCE1AF8; Fri, 19 Apr 2024 15:55:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A421C32782; Fri, 19 Apr 2024 15:55:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713542114; bh=PNzXHy/tRctT7iPO4Hxb0l/pQDROtMOUfttALn8mdWw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=pqf8XrEo/ZXtoYY6s3PyoZrVaUFPmoHxFRVaIVD+cv3s9s0b57yKCkZBfgw3J/DFY ItFu/AL8+h/o6KzZv3W/jgdaahJ+fBSkuBMaq6Fa9gIV+jIx0BRXS0xUN7/X5dBPCS CtUI7XjfYrMseAEBlWGp1/BlZfgiFr+70fAxlZPMxdU8CUsp8cqjeiGh7fSLDtYeJ4 ci293wBMZSj5XVodFvDDRPQI2WnRMIxx356QO12oxl9Vr7bTlPCN/kbkpDTGdnUTk0 OJtvbGt6roHNq6+muZAwUQgB2hXjVyHoavfSajpvVRjHUvmn/YdlEKZxa/rSjatbO9 x3piRqi1B5HPQ== Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a5224dfa9adso386573966b.0; Fri, 19 Apr 2024 08:55:14 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUbSEaOLTvYn1+6epyB4GTZd83L9TITCRIWq9ot0baEDDmJsBnKZ9Zos794cqIJPVZshVAw55QC/eGcEy4mA02gR7px4EP9/Fw1U9Aof0ldjdmzrPAvVyvWkFUhPvV7mHOupbR08mfwUJQNee4jF1GgjWpTS9I= X-Gm-Message-State: AOJu0Yx8ExfrD7t4udsoJTo3gMikdNHpwvdKvZVqU2Xv6PFA5IzBF1NQ 2xCiFgUOqnXHoyRb9UiQJEJVfZrcpqDm+RaUdzKp2EYo7HCAQCbeF7Q6t9fQttkMkpSxIwPZrwe nLQT6eyDKBxYdfCUf0C+wBhrjXmo= X-Google-Smtp-Source: AGHT+IGasMltj1XTiWxWNEYkPSMxwP63y2jyTt8tLpdHn26unpYTPPkYdRp/dT6gEwD6NrNiKXUtIlL7PF9cDNubUq4= X-Received: by 2002:ac2:5f9b:0:b0:519:ab33:7459 with SMTP id r27-20020ac25f9b000000b00519ab337459mr752898lfe.30.1713542091952; Fri, 19 Apr 2024 08:54:51 -0700 (PDT) MIME-Version: 1.0 References: <20240411160051.2093261-1-rppt@kernel.org> <20240411160051.2093261-6-rppt@kernel.org> <20240415075241.GF40213@noisy.programming.kicks-ass.net> In-Reply-To: From: Song Liu Date: Fri, 19 Apr 2024 08:54:40 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free() To: Mike Rapoport Cc: Mark Rutland , Peter Zijlstra , linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , Bjorn Topel , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240419_085517_471956_DF5D2C9F X-CRM114-Status: GOOD ( 23.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBcHIgMTgsIDIwMjQgYXQgMTE6NTbigK9QTSBNaWtlIFJhcG9wb3J0IDxycHB0QGtl cm5lbC5vcmc+IHdyb3RlOgo+Cj4gT24gVGh1LCBBcHIgMTgsIDIwMjQgYXQgMDI6MDE6MjJQTSAt MDcwMCwgU29uZyBMaXUgd3JvdGU6Cj4gPiBPbiBUaHUsIEFwciAxOCwgMjAyNCBhdCAxMDo1NOKA r0FNIE1pa2UgUmFwb3BvcnQgPHJwcHRAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPiA+Cj4gPiA+IE9u IFRodSwgQXByIDE4LCAyMDI0IGF0IDA5OjEzOjI3QU0gLTA3MDAsIFNvbmcgTGl1IHdyb3RlOgo+ ID4gPiA+IE9uIFRodSwgQXByIDE4LCAyMDI0IGF0IDg6MzfigK9BTSBNaWtlIFJhcG9wb3J0IDxy cHB0QGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gSSdtIGxv b2tpbmcgYXQgZXhlY21lbV90eXBlcyBtb3JlIGFzIGRlZmluaXRpb24gb2YgdGhlIGNvbnN1bWVy cywgbWF5YmUgSQo+ID4gPiA+ID4gPiA+IHNob3VsZCBoYXZlIG5hbWVkIHRoZSBlbnVtIGV4ZWNt ZW1fY29uc3VtZXIgYXQgdGhlIGZpcnN0IHBsYWNlLgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBJ IHRoaW5rIGxvb2tpbmcgYXQgZXhlY21lbV90eXBlIGZyb20gY29uc3VtZXJzJyBwb2ludCBvZiB2 aWV3IGFkZHMKPiA+ID4gPiA+ID4gdW5uZWNlc3NhcnkgY29tcGxleGl0eS4gSUlVQywgZm9yIG1v c3QgKGlmIG5vdCBhbGwpIGFyY2hzLCBmdHJhY2UsIGtwcm9iZSwKPiA+ID4gPiA+ID4gYW5kIGJw ZiAoYW5kIG1heWJlIGFsc28gbW9kdWxlIHRleHQpIGFsbCBoYXZlIHRoZSBzYW1lIHJlcXVpcmVt ZW50cy4KPiA+ID4gPiA+ID4gRGlkIEkgbWlzcyBzb21ldGhpbmc/Cj4gPiA+ID4gPgo+ID4gPiA+ ID4gSXQncyBlbm91Z2ggdG8gaGF2ZSBvbmUgYXJjaGl0ZWN0dXJlIHdpdGggZGlmZmVyZW50IGNv bnN0cmFpbnMgZm9yIGtwcm9iZXMKPiA+ID4gPiA+IGFuZCBicGYgdG8gd2FycmFudCBhIHR5cGUg Zm9yIGVhY2guCj4gPiA+ID4KPiA+ID4gPiBBRkFJQ1QsIHNvbWUgb2YgdGhlc2UgY29uc3RyYWlu dHMgY2FuIGJlIGNoYW5nZWQgd2l0aG91dCB0b28gbXVjaCB3b3JrLgo+ID4gPgo+ID4gPiBCdXQg d2h5Pwo+ID4gPiBJIGhvbmVzdGx5IGRvbid0IHVuZGVyc3RhbmQgd2hhdCBhcmUgeW91IHRyeWlu ZyB0byBvcHRpbWl6ZSBoZXJlLiBBIGZldwo+ID4gPiBsaW5lcyBvZiBpbml0aWFsaXphdGlvbiBp biBleGVjbWVtX2luZm8/Cj4gPgo+ID4gSUlVQywgaGF2aW5nIHNlcGFyYXRlIEVYRUNNRU1fQlBG IGFuZCBFWEVDTUVNX0tQUk9CRSBtYWtlcyBpdAo+ID4gaGFyZGVyIGZvciBicGYgYW5kIGtwcm9i ZSB0byBzaGFyZSB0aGUgc2FtZSBST1ggcGFnZS4gSW4gbWFueSB1c2UgY2FzZXMsCj4gPiBhIDJN aUIgcGFnZSAoYXNzdW1pbmcgeDg2XzY0KSBpcyBlbm91Z2ggZm9yIGFsbCBCUEYsIGtwcm9iZSwg ZnRyYWNlLCBhbmQKPiA+IG1vZHVsZSB0ZXh0LiBJdCBpcyBub3QgZWZmaWNpZW50IGlmIHdlIGhh dmUgdG8gYWxsb2NhdGUgc2VwYXJhdGUgcGFnZXMgZm9yIGVhY2gKPiA+IG9mIHRoZXNlIHVzZSBj YXNlcy4gSWYgdGhpcyBpcyBub3QgYSBwcm9ibGVtLCB0aGUgY3VycmVudCBhcHByb2FjaCB3b3Jr cy4KPgo+IFRoZSBjYWNoaW5nIG9mIGxhcmdlIFJPWCBwYWdlcyBkb2VzIG5vdCBuZWVkIHRvIGJl IHBlciB0eXBlLgo+Cj4gSW4gdGhlIFBPQyBJJ3ZlIHBvc3RlZCBmb3IgY2FjaGluZyBvZiBsYXJn ZSBST1ggcGFnZXMgb24geDg2IFsxXSwgdGhlIGNhY2hlIGlzCj4gZ2xvYmFsIGFuZCB0byBtYWtl IGtwcm9iZXMgYW5kIGJwZiB1c2UgaXQgaXQncyBlbm91Z2ggdG8gc2V0IGEgZmxhZyBpbgo+IGV4 ZWNtZW1faW5mby4KPgo+IFsxXSBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvMjAyNDA0MTEx NjA1MjYuMjA5MzQwOC0xLXJwcHRAa2VybmVsLm9yZwoKRm9yIHRoZSBST1ggdG8gd29yaywgd2Ug bmVlZCBkaWZmZXJlbnQgdXNlcnMgKG1vZHVsZSB0ZXh0LCBrcHJvYmUsIGV0Yy4pIHRvIGhhdmUK dGhlIHNhbWUgZXhlY21lbV9yYW5nZS4gRnJvbSBbMV06CgpzdGF0aWMgdm9pZCAqZXhlY21lbV9j YWNoZV9hbGxvYyhzdHJ1Y3QgZXhlY21lbV9yYW5nZSAqcmFuZ2UsIHNpemVfdCBzaXplKQp7Ci4u LgogICAgICAgcCA9IF9fZXhlY21lbV9jYWNoZV9hbGxvYyhzaXplKTsKICAgICAgIGlmIChwKQog ICAgICAgICAgICAgICByZXR1cm4gcDsKICAgICAgZXJyID0gZXhlY21lbV9jYWNoZV9wb3B1bGF0 ZShyYW5nZSwgc2l6ZSk7Ci4uLgp9CgpXZSBhcmUgY2FsbGluZyBfX2V4ZWNtZW1fY2FjaGVfYWxs b2MoKSB3aXRob3V0IHJhbmdlLiBGb3IgdGhpcyB0byB3b3JrLAp3ZSBjYW4gb25seSBjYWxsIGV4 ZWNtZW1fY2FjaGVfYWxsb2MoKSB3aXRoIG9uZSBleGVjbWVtX3JhbmdlLgoKRGlkIEkgbWlzcyBz b21ldGhpbmc/CgpUaGFua3MsClNvbmcKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK