From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4608712FB05; Fri, 19 Apr 2024 17:03:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713546219; cv=none; b=nsMz7ChFXQUquMH/1LJKq3fciYWxhRA0ojHrmOV2zgTnLwgDSI0uP3hI7whCDzM4lKcWELNsxkiG1+OSwAe9W2bB2tcaIZ3x1bAP9WILtbK3eH43ra+5gZZcbmjef9ZEjunkP+6Yr4ESfrCzPz0zhhRmFW47WgGlxNBIr4aoa34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713546219; c=relaxed/simple; bh=jFxi5qZrScF2xjH3z+fMU0rA+S3WPw/R5/k/PlfLlD4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M4ek9+vpT8JzKWf48sYDBD4TxWUGYKv1hvrhUh3Nxip5z2b4Fob52CcB8CoHsXPt/W9HDsthfVmv2LjwHOndiQcFEbyBDywszlnNn/inRk2Nv3mrWehTUbqJpLdaW7CA7ZT0ICC3p1ge+5Moq7+VQFeIAPBt3ijBXdevda2RjWA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RUL9Opqg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RUL9Opqg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20D36C3277B; Fri, 19 Apr 2024 17:03:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713546218; bh=jFxi5qZrScF2xjH3z+fMU0rA+S3WPw/R5/k/PlfLlD4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RUL9Opqg9lVQKyIEyIuq2xjKwlBEmIHBH/IVoveA6aP2JLQi0uzPvTDRn7OmSzfgD nIb4g/5o2RBtfUp3FCsBZLo4UMhQBN8itmVTPuHB1vCt7tnCtqGOlM7w17hYv3aiWy FPRpIYW/h0QBF2/1gYcg2KSSl6cBIyHw8P1BRp78GQ/1rnAZNqj1HgINRQQE2y6kx8 pa/lP0BVFbrI+oqwHSJpzLJUH1OONwzfgc8jyKWmKgwbnoS/jGKAA+PE+NrL1eKBBr VPLO+D3Fy9QluAkUMgIaLcYTb9+hJ5Az7wIHrpBlSplLPGXqXzT9s0UFhk3C1grs7n akOPXTz5YdCXA== Date: Fri, 19 Apr 2024 20:02:17 +0300 From: Mike Rapoport To: Song Liu Cc: Mark Rutland , Peter Zijlstra , linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , Bjorn Topel , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free() Message-ID: References: <20240415075241.GF40213@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Apr 19, 2024 at 08:54:40AM -0700, Song Liu wrote: > On Thu, Apr 18, 2024 at 11:56 PM Mike Rapoport wrote: > > > > On Thu, Apr 18, 2024 at 02:01:22PM -0700, Song Liu wrote: > > > On Thu, Apr 18, 2024 at 10:54 AM Mike Rapoport wrote: > > > > > > > > On Thu, Apr 18, 2024 at 09:13:27AM -0700, Song Liu wrote: > > > > > On Thu, Apr 18, 2024 at 8:37 AM Mike Rapoport wrote: > > > > > > > > > > > > > > > > I'm looking at execmem_types more as definition of the consumers, maybe I > > > > > > > > should have named the enum execmem_consumer at the first place. > > > > > > > > > > > > > > I think looking at execmem_type from consumers' point of view adds > > > > > > > unnecessary complexity. IIUC, for most (if not all) archs, ftrace, kprobe, > > > > > > > and bpf (and maybe also module text) all have the same requirements. > > > > > > > Did I miss something? > > > > > > > > > > > > It's enough to have one architecture with different constrains for kprobes > > > > > > and bpf to warrant a type for each. > > > > > > > > > > AFAICT, some of these constraints can be changed without too much work. > > > > > > > > But why? > > > > I honestly don't understand what are you trying to optimize here. A few > > > > lines of initialization in execmem_info? > > > > > > IIUC, having separate EXECMEM_BPF and EXECMEM_KPROBE makes it > > > harder for bpf and kprobe to share the same ROX page. In many use cases, > > > a 2MiB page (assuming x86_64) is enough for all BPF, kprobe, ftrace, and > > > module text. It is not efficient if we have to allocate separate pages for each > > > of these use cases. If this is not a problem, the current approach works. > > > > The caching of large ROX pages does not need to be per type. > > > > In the POC I've posted for caching of large ROX pages on x86 [1], the cache is > > global and to make kprobes and bpf use it it's enough to set a flag in > > execmem_info. > > > > [1] https://lore.kernel.org/all/20240411160526.2093408-1-rppt@kernel.org > > For the ROX to work, we need different users (module text, kprobe, etc.) to have > the same execmem_range. From [1]: > > static void *execmem_cache_alloc(struct execmem_range *range, size_t size) > { > ... > p = __execmem_cache_alloc(size); > if (p) > return p; > err = execmem_cache_populate(range, size); > ... > } > > We are calling __execmem_cache_alloc() without range. For this to work, > we can only call execmem_cache_alloc() with one execmem_range. Actually, on x86 this will "just work" because everything shares the same address space :) The 2M pages in the cache will be in the modules space, so __execmem_cache_alloc() will always return memory from that address space. For other architectures this indeed needs to be fixed with passing the range to __execmem_cache_alloc() and limiting search in the cache for that range. > Did I miss something? > > Thanks, > Song -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97609C4345F for ; Fri, 19 Apr 2024 17:03:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1PK2Wdhi7nZDY88DDfveaHKwQtHZfqkd1Jb9WuYzSXA=; b=wu+VSvnSUASg3Y 5zO38rjdUIe0F8mLTNJ+42H7+B+2ws5LVXnGiYpKRdLAUAxFrVEdQ36/akzU96w1N7Oqp3E3/xy4q UcpObvCanpMBgY7FhatpWF7T25xYtB9bF7T9X0w/8VTB4GDwp3jBaSqk+DKxQMUMZfvOgGsqxcaXt aVhfe1ztt9WrlWFjqBG+vKUDIRDoU76tbZ8EGppfSaJWaUpMQr1uxFBewCXQrfYgd2PNDO+h87yNq RgFT59rSeej5nwWBfYXgnYAW3941wVRsozAIiSvXnPgN+CLAdoC7687n3vOeQ/88cAzsd/VwLw057 cOrzAiJ8L1eBtUcyM1TQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxreM-00000006Twz-0Kxj; Fri, 19 Apr 2024 17:03:46 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxreH-00000006TtB-12zr; Fri, 19 Apr 2024 17:03:43 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2F75061A85; Fri, 19 Apr 2024 17:03:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20D36C3277B; Fri, 19 Apr 2024 17:03:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713546218; bh=jFxi5qZrScF2xjH3z+fMU0rA+S3WPw/R5/k/PlfLlD4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RUL9Opqg9lVQKyIEyIuq2xjKwlBEmIHBH/IVoveA6aP2JLQi0uzPvTDRn7OmSzfgD nIb4g/5o2RBtfUp3FCsBZLo4UMhQBN8itmVTPuHB1vCt7tnCtqGOlM7w17hYv3aiWy FPRpIYW/h0QBF2/1gYcg2KSSl6cBIyHw8P1BRp78GQ/1rnAZNqj1HgINRQQE2y6kx8 pa/lP0BVFbrI+oqwHSJpzLJUH1OONwzfgc8jyKWmKgwbnoS/jGKAA+PE+NrL1eKBBr VPLO+D3Fy9QluAkUMgIaLcYTb9+hJ5Az7wIHrpBlSplLPGXqXzT9s0UFhk3C1grs7n akOPXTz5YdCXA== Date: Fri, 19 Apr 2024 20:02:17 +0300 From: Mike Rapoport To: Song Liu Cc: Mark Rutland , Peter Zijlstra , linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , Bjorn Topel , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free() Message-ID: References: <20240415075241.GF40213@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240419_100341_432801_32C3DF35 X-CRM114-Status: GOOD ( 30.40 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gRnJpLCBBcHIgMTksIDIwMjQgYXQgMDg6NTQ6NDBBTSAtMDcwMCwgU29uZyBMaXUgd3JvdGU6 Cj4gT24gVGh1LCBBcHIgMTgsIDIwMjQgYXQgMTE6NTbigK9QTSBNaWtlIFJhcG9wb3J0IDxycHB0 QGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4KPiA+IE9uIFRodSwgQXByIDE4LCAyMDI0IGF0IDAyOjAx OjIyUE0gLTA3MDAsIFNvbmcgTGl1IHdyb3RlOgo+ID4gPiBPbiBUaHUsIEFwciAxOCwgMjAyNCBh dCAxMDo1NOKAr0FNIE1pa2UgUmFwb3BvcnQgPHJwcHRAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPiA+ ID4KPiA+ID4gPiBPbiBUaHUsIEFwciAxOCwgMjAyNCBhdCAwOToxMzoyN0FNIC0wNzAwLCBTb25n IExpdSB3cm90ZToKPiA+ID4gPiA+IE9uIFRodSwgQXByIDE4LCAyMDI0IGF0IDg6MzfigK9BTSBN aWtlIFJhcG9wb3J0IDxycHB0QGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4gPiA+ID4gPiA+ID4KPiA+ ID4gPiA+ID4gPiA+IEknbSBsb29raW5nIGF0IGV4ZWNtZW1fdHlwZXMgbW9yZSBhcyBkZWZpbml0 aW9uIG9mIHRoZSBjb25zdW1lcnMsIG1heWJlIEkKPiA+ID4gPiA+ID4gPiA+IHNob3VsZCBoYXZl IG5hbWVkIHRoZSBlbnVtIGV4ZWNtZW1fY29uc3VtZXIgYXQgdGhlIGZpcnN0IHBsYWNlLgo+ID4g PiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gSSB0aGluayBsb29raW5nIGF0IGV4ZWNtZW1fdHlwZSBm cm9tIGNvbnN1bWVycycgcG9pbnQgb2YgdmlldyBhZGRzCj4gPiA+ID4gPiA+ID4gdW5uZWNlc3Nh cnkgY29tcGxleGl0eS4gSUlVQywgZm9yIG1vc3QgKGlmIG5vdCBhbGwpIGFyY2hzLCBmdHJhY2Us IGtwcm9iZSwKPiA+ID4gPiA+ID4gPiBhbmQgYnBmIChhbmQgbWF5YmUgYWxzbyBtb2R1bGUgdGV4 dCkgYWxsIGhhdmUgdGhlIHNhbWUgcmVxdWlyZW1lbnRzLgo+ID4gPiA+ID4gPiA+IERpZCBJIG1p c3Mgc29tZXRoaW5nPwo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBJdCdzIGVub3VnaCB0byBoYXZl IG9uZSBhcmNoaXRlY3R1cmUgd2l0aCBkaWZmZXJlbnQgY29uc3RyYWlucyBmb3Iga3Byb2Jlcwo+ ID4gPiA+ID4gPiBhbmQgYnBmIHRvIHdhcnJhbnQgYSB0eXBlIGZvciBlYWNoLgo+ID4gPiA+ID4K PiA+ID4gPiA+IEFGQUlDVCwgc29tZSBvZiB0aGVzZSBjb25zdHJhaW50cyBjYW4gYmUgY2hhbmdl ZCB3aXRob3V0IHRvbyBtdWNoIHdvcmsuCj4gPiA+ID4KPiA+ID4gPiBCdXQgd2h5Pwo+ID4gPiA+ IEkgaG9uZXN0bHkgZG9uJ3QgdW5kZXJzdGFuZCB3aGF0IGFyZSB5b3UgdHJ5aW5nIHRvIG9wdGlt aXplIGhlcmUuIEEgZmV3Cj4gPiA+ID4gbGluZXMgb2YgaW5pdGlhbGl6YXRpb24gaW4gZXhlY21l bV9pbmZvPwo+ID4gPgo+ID4gPiBJSVVDLCBoYXZpbmcgc2VwYXJhdGUgRVhFQ01FTV9CUEYgYW5k IEVYRUNNRU1fS1BST0JFIG1ha2VzIGl0Cj4gPiA+IGhhcmRlciBmb3IgYnBmIGFuZCBrcHJvYmUg dG8gc2hhcmUgdGhlIHNhbWUgUk9YIHBhZ2UuIEluIG1hbnkgdXNlIGNhc2VzLAo+ID4gPiBhIDJN aUIgcGFnZSAoYXNzdW1pbmcgeDg2XzY0KSBpcyBlbm91Z2ggZm9yIGFsbCBCUEYsIGtwcm9iZSwg ZnRyYWNlLCBhbmQKPiA+ID4gbW9kdWxlIHRleHQuIEl0IGlzIG5vdCBlZmZpY2llbnQgaWYgd2Ug aGF2ZSB0byBhbGxvY2F0ZSBzZXBhcmF0ZSBwYWdlcyBmb3IgZWFjaAo+ID4gPiBvZiB0aGVzZSB1 c2UgY2FzZXMuIElmIHRoaXMgaXMgbm90IGEgcHJvYmxlbSwgdGhlIGN1cnJlbnQgYXBwcm9hY2gg d29ya3MuCj4gPgo+ID4gVGhlIGNhY2hpbmcgb2YgbGFyZ2UgUk9YIHBhZ2VzIGRvZXMgbm90IG5l ZWQgdG8gYmUgcGVyIHR5cGUuCj4gPgo+ID4gSW4gdGhlIFBPQyBJJ3ZlIHBvc3RlZCBmb3IgY2Fj aGluZyBvZiBsYXJnZSBST1ggcGFnZXMgb24geDg2IFsxXSwgdGhlIGNhY2hlIGlzCj4gPiBnbG9i YWwgYW5kIHRvIG1ha2Uga3Byb2JlcyBhbmQgYnBmIHVzZSBpdCBpdCdzIGVub3VnaCB0byBzZXQg YSBmbGFnIGluCj4gPiBleGVjbWVtX2luZm8uCj4gPgo+ID4gWzFdIGh0dHBzOi8vbG9yZS5rZXJu ZWwub3JnL2FsbC8yMDI0MDQxMTE2MDUyNi4yMDkzNDA4LTEtcnBwdEBrZXJuZWwub3JnCj4gCj4g Rm9yIHRoZSBST1ggdG8gd29yaywgd2UgbmVlZCBkaWZmZXJlbnQgdXNlcnMgKG1vZHVsZSB0ZXh0 LCBrcHJvYmUsIGV0Yy4pIHRvIGhhdmUKPiB0aGUgc2FtZSBleGVjbWVtX3JhbmdlLiBGcm9tIFsx XToKPiAKPiBzdGF0aWMgdm9pZCAqZXhlY21lbV9jYWNoZV9hbGxvYyhzdHJ1Y3QgZXhlY21lbV9y YW5nZSAqcmFuZ2UsIHNpemVfdCBzaXplKQo+IHsKPiAuLi4KPiAgICAgICAgcCA9IF9fZXhlY21l bV9jYWNoZV9hbGxvYyhzaXplKTsKPiAgICAgICAgaWYgKHApCj4gICAgICAgICAgICAgICAgcmV0 dXJuIHA7Cj4gICAgICAgZXJyID0gZXhlY21lbV9jYWNoZV9wb3B1bGF0ZShyYW5nZSwgc2l6ZSk7 Cj4gLi4uCj4gfQo+IAo+IFdlIGFyZSBjYWxsaW5nIF9fZXhlY21lbV9jYWNoZV9hbGxvYygpIHdp dGhvdXQgcmFuZ2UuIEZvciB0aGlzIHRvIHdvcmssCj4gd2UgY2FuIG9ubHkgY2FsbCBleGVjbWVt X2NhY2hlX2FsbG9jKCkgd2l0aCBvbmUgZXhlY21lbV9yYW5nZS4KCkFjdHVhbGx5LCBvbiB4ODYg dGhpcyB3aWxsICJqdXN0IHdvcmsiIGJlY2F1c2UgZXZlcnl0aGluZyBzaGFyZXMgdGhlIHNhbWUK YWRkcmVzcyBzcGFjZSA6KQoKVGhlIDJNIHBhZ2VzIGluIHRoZSBjYWNoZSB3aWxsIGJlIGluIHRo ZSBtb2R1bGVzIHNwYWNlLCBzbwpfX2V4ZWNtZW1fY2FjaGVfYWxsb2MoKSB3aWxsIGFsd2F5cyBy ZXR1cm4gbWVtb3J5IGZyb20gdGhhdCBhZGRyZXNzIHNwYWNlLgoKRm9yIG90aGVyIGFyY2hpdGVj dHVyZXMgdGhpcyBpbmRlZWQgbmVlZHMgdG8gYmUgZml4ZWQgd2l0aCBwYXNzaW5nIHRoZQpyYW5n ZSB0byBfX2V4ZWNtZW1fY2FjaGVfYWxsb2MoKSBhbmQgbGltaXRpbmcgc2VhcmNoIGluIHRoZSBj YWNoZSBmb3IgdGhhdApyYW5nZS4KIAo+IERpZCBJIG1pc3Mgc29tZXRoaW5nPwo+IAo+IFRoYW5r cywKPiBTb25nCgotLSAKU2luY2VyZWx5IHlvdXJzLApNaWtlLgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0Cmxp bnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3B68C071FD for ; Fri, 19 Apr 2024 17:03:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0D00jhCXzmP853Ra3Z8M4USHPgEja00BM5n3U3Ye6O4=; b=jNJtcj40WjGJWh 9juI6YNhs209ZX99URL+93bF3GO21QJk+xVm2aHE0Hs3ZdhaekMMSK7WGnD5oB1CrZ/n9SLD8Vesi bhalKY7Q4513whdOR4dvNwT3tNiVEMmGMqnYZnZaP2LVLgCIhZBdjcuNPSv0eghVCfbqh/Y6C9jYD bLVsfCVTXT9Wqg4qkKjRpQ/FPh/BIOjexjgbbccj2DyaD/Ts7lINVq2zxN7bIw3/J2knCEzDLKWRP Wv3qzD0vCyDrQk2vUBmVmPdc/FVlZgZIe+NCJTpQw3r/hcF4SL1NTGW7UmkNUA4UPTb6uyoaHiZ0M MrwnJ6DYXtLX6T0tTHWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxreL-00000006Two-1tdb; Fri, 19 Apr 2024 17:03:45 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxreH-00000006TtB-12zr; Fri, 19 Apr 2024 17:03:43 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2F75061A85; Fri, 19 Apr 2024 17:03:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20D36C3277B; Fri, 19 Apr 2024 17:03:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713546218; bh=jFxi5qZrScF2xjH3z+fMU0rA+S3WPw/R5/k/PlfLlD4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RUL9Opqg9lVQKyIEyIuq2xjKwlBEmIHBH/IVoveA6aP2JLQi0uzPvTDRn7OmSzfgD nIb4g/5o2RBtfUp3FCsBZLo4UMhQBN8itmVTPuHB1vCt7tnCtqGOlM7w17hYv3aiWy FPRpIYW/h0QBF2/1gYcg2KSSl6cBIyHw8P1BRp78GQ/1rnAZNqj1HgINRQQE2y6kx8 pa/lP0BVFbrI+oqwHSJpzLJUH1OONwzfgc8jyKWmKgwbnoS/jGKAA+PE+NrL1eKBBr VPLO+D3Fy9QluAkUMgIaLcYTb9+hJ5Az7wIHrpBlSplLPGXqXzT9s0UFhk3C1grs7n akOPXTz5YdCXA== Date: Fri, 19 Apr 2024 20:02:17 +0300 From: Mike Rapoport To: Song Liu Cc: Mark Rutland , Peter Zijlstra , linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , Bjorn Topel , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free() Message-ID: References: <20240415075241.GF40213@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240419_100341_432801_32C3DF35 X-CRM114-Status: GOOD ( 30.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBBcHIgMTksIDIwMjQgYXQgMDg6NTQ6NDBBTSAtMDcwMCwgU29uZyBMaXUgd3JvdGU6 Cj4gT24gVGh1LCBBcHIgMTgsIDIwMjQgYXQgMTE6NTbigK9QTSBNaWtlIFJhcG9wb3J0IDxycHB0 QGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4KPiA+IE9uIFRodSwgQXByIDE4LCAyMDI0IGF0IDAyOjAx OjIyUE0gLTA3MDAsIFNvbmcgTGl1IHdyb3RlOgo+ID4gPiBPbiBUaHUsIEFwciAxOCwgMjAyNCBh dCAxMDo1NOKAr0FNIE1pa2UgUmFwb3BvcnQgPHJwcHRAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPiA+ ID4KPiA+ID4gPiBPbiBUaHUsIEFwciAxOCwgMjAyNCBhdCAwOToxMzoyN0FNIC0wNzAwLCBTb25n IExpdSB3cm90ZToKPiA+ID4gPiA+IE9uIFRodSwgQXByIDE4LCAyMDI0IGF0IDg6MzfigK9BTSBN aWtlIFJhcG9wb3J0IDxycHB0QGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4gPiA+ID4gPiA+ID4KPiA+ ID4gPiA+ID4gPiA+IEknbSBsb29raW5nIGF0IGV4ZWNtZW1fdHlwZXMgbW9yZSBhcyBkZWZpbml0 aW9uIG9mIHRoZSBjb25zdW1lcnMsIG1heWJlIEkKPiA+ID4gPiA+ID4gPiA+IHNob3VsZCBoYXZl IG5hbWVkIHRoZSBlbnVtIGV4ZWNtZW1fY29uc3VtZXIgYXQgdGhlIGZpcnN0IHBsYWNlLgo+ID4g PiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gSSB0aGluayBsb29raW5nIGF0IGV4ZWNtZW1fdHlwZSBm cm9tIGNvbnN1bWVycycgcG9pbnQgb2YgdmlldyBhZGRzCj4gPiA+ID4gPiA+ID4gdW5uZWNlc3Nh cnkgY29tcGxleGl0eS4gSUlVQywgZm9yIG1vc3QgKGlmIG5vdCBhbGwpIGFyY2hzLCBmdHJhY2Us IGtwcm9iZSwKPiA+ID4gPiA+ID4gPiBhbmQgYnBmIChhbmQgbWF5YmUgYWxzbyBtb2R1bGUgdGV4 dCkgYWxsIGhhdmUgdGhlIHNhbWUgcmVxdWlyZW1lbnRzLgo+ID4gPiA+ID4gPiA+IERpZCBJIG1p c3Mgc29tZXRoaW5nPwo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBJdCdzIGVub3VnaCB0byBoYXZl IG9uZSBhcmNoaXRlY3R1cmUgd2l0aCBkaWZmZXJlbnQgY29uc3RyYWlucyBmb3Iga3Byb2Jlcwo+ ID4gPiA+ID4gPiBhbmQgYnBmIHRvIHdhcnJhbnQgYSB0eXBlIGZvciBlYWNoLgo+ID4gPiA+ID4K PiA+ID4gPiA+IEFGQUlDVCwgc29tZSBvZiB0aGVzZSBjb25zdHJhaW50cyBjYW4gYmUgY2hhbmdl ZCB3aXRob3V0IHRvbyBtdWNoIHdvcmsuCj4gPiA+ID4KPiA+ID4gPiBCdXQgd2h5Pwo+ID4gPiA+ IEkgaG9uZXN0bHkgZG9uJ3QgdW5kZXJzdGFuZCB3aGF0IGFyZSB5b3UgdHJ5aW5nIHRvIG9wdGlt aXplIGhlcmUuIEEgZmV3Cj4gPiA+ID4gbGluZXMgb2YgaW5pdGlhbGl6YXRpb24gaW4gZXhlY21l bV9pbmZvPwo+ID4gPgo+ID4gPiBJSVVDLCBoYXZpbmcgc2VwYXJhdGUgRVhFQ01FTV9CUEYgYW5k IEVYRUNNRU1fS1BST0JFIG1ha2VzIGl0Cj4gPiA+IGhhcmRlciBmb3IgYnBmIGFuZCBrcHJvYmUg dG8gc2hhcmUgdGhlIHNhbWUgUk9YIHBhZ2UuIEluIG1hbnkgdXNlIGNhc2VzLAo+ID4gPiBhIDJN aUIgcGFnZSAoYXNzdW1pbmcgeDg2XzY0KSBpcyBlbm91Z2ggZm9yIGFsbCBCUEYsIGtwcm9iZSwg ZnRyYWNlLCBhbmQKPiA+ID4gbW9kdWxlIHRleHQuIEl0IGlzIG5vdCBlZmZpY2llbnQgaWYgd2Ug aGF2ZSB0byBhbGxvY2F0ZSBzZXBhcmF0ZSBwYWdlcyBmb3IgZWFjaAo+ID4gPiBvZiB0aGVzZSB1 c2UgY2FzZXMuIElmIHRoaXMgaXMgbm90IGEgcHJvYmxlbSwgdGhlIGN1cnJlbnQgYXBwcm9hY2gg d29ya3MuCj4gPgo+ID4gVGhlIGNhY2hpbmcgb2YgbGFyZ2UgUk9YIHBhZ2VzIGRvZXMgbm90IG5l ZWQgdG8gYmUgcGVyIHR5cGUuCj4gPgo+ID4gSW4gdGhlIFBPQyBJJ3ZlIHBvc3RlZCBmb3IgY2Fj aGluZyBvZiBsYXJnZSBST1ggcGFnZXMgb24geDg2IFsxXSwgdGhlIGNhY2hlIGlzCj4gPiBnbG9i YWwgYW5kIHRvIG1ha2Uga3Byb2JlcyBhbmQgYnBmIHVzZSBpdCBpdCdzIGVub3VnaCB0byBzZXQg YSBmbGFnIGluCj4gPiBleGVjbWVtX2luZm8uCj4gPgo+ID4gWzFdIGh0dHBzOi8vbG9yZS5rZXJu ZWwub3JnL2FsbC8yMDI0MDQxMTE2MDUyNi4yMDkzNDA4LTEtcnBwdEBrZXJuZWwub3JnCj4gCj4g Rm9yIHRoZSBST1ggdG8gd29yaywgd2UgbmVlZCBkaWZmZXJlbnQgdXNlcnMgKG1vZHVsZSB0ZXh0 LCBrcHJvYmUsIGV0Yy4pIHRvIGhhdmUKPiB0aGUgc2FtZSBleGVjbWVtX3JhbmdlLiBGcm9tIFsx XToKPiAKPiBzdGF0aWMgdm9pZCAqZXhlY21lbV9jYWNoZV9hbGxvYyhzdHJ1Y3QgZXhlY21lbV9y YW5nZSAqcmFuZ2UsIHNpemVfdCBzaXplKQo+IHsKPiAuLi4KPiAgICAgICAgcCA9IF9fZXhlY21l bV9jYWNoZV9hbGxvYyhzaXplKTsKPiAgICAgICAgaWYgKHApCj4gICAgICAgICAgICAgICAgcmV0 dXJuIHA7Cj4gICAgICAgZXJyID0gZXhlY21lbV9jYWNoZV9wb3B1bGF0ZShyYW5nZSwgc2l6ZSk7 Cj4gLi4uCj4gfQo+IAo+IFdlIGFyZSBjYWxsaW5nIF9fZXhlY21lbV9jYWNoZV9hbGxvYygpIHdp dGhvdXQgcmFuZ2UuIEZvciB0aGlzIHRvIHdvcmssCj4gd2UgY2FuIG9ubHkgY2FsbCBleGVjbWVt X2NhY2hlX2FsbG9jKCkgd2l0aCBvbmUgZXhlY21lbV9yYW5nZS4KCkFjdHVhbGx5LCBvbiB4ODYg dGhpcyB3aWxsICJqdXN0IHdvcmsiIGJlY2F1c2UgZXZlcnl0aGluZyBzaGFyZXMgdGhlIHNhbWUK YWRkcmVzcyBzcGFjZSA6KQoKVGhlIDJNIHBhZ2VzIGluIHRoZSBjYWNoZSB3aWxsIGJlIGluIHRo ZSBtb2R1bGVzIHNwYWNlLCBzbwpfX2V4ZWNtZW1fY2FjaGVfYWxsb2MoKSB3aWxsIGFsd2F5cyBy ZXR1cm4gbWVtb3J5IGZyb20gdGhhdCBhZGRyZXNzIHNwYWNlLgoKRm9yIG90aGVyIGFyY2hpdGVj dHVyZXMgdGhpcyBpbmRlZWQgbmVlZHMgdG8gYmUgZml4ZWQgd2l0aCBwYXNzaW5nIHRoZQpyYW5n ZSB0byBfX2V4ZWNtZW1fY2FjaGVfYWxsb2MoKSBhbmQgbGltaXRpbmcgc2VhcmNoIGluIHRoZSBj YWNoZSBmb3IgdGhhdApyYW5nZS4KIAo+IERpZCBJIG1pc3Mgc29tZXRoaW5nPwo+IAo+IFRoYW5r cywKPiBTb25nCgotLSAKU2luY2VyZWx5IHlvdXJzLApNaWtlLgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=