From: Tor Vic <torvic9@mailbox.org>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Cc: Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] wifi: iwlwifi: mvm: fix link ID management
Date: Wed, 24 Apr 2024 14:26:30 +0200 [thread overview]
Message-ID: <d13260ee-e9f5-49fc-b8ea-78c9424c460e@mailbox.org> (raw)
In-Reply-To: <20240420154435.dce72db5d5e3.Ic40b454b24f1c7b380a1eedf67455d9cf2f58541@changeid>
On 4/20/24 15:44, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> On older (pre-MLD API) devices, we started also calling
> iwl_mvm_set_link_mapping()/iwl_mvm_unset_link_mapping(),
> but of course not also iwl_mvm_remove_link(). Since the
> link ID was only released in iwl_mvm_remove_link() this
> causes us to run out of FW link IDs very quickly. Fix
> it by releasing the link ID correctly.
>
> Fixes: a8b5d4809b50 ("wifi: iwlwifi: mvm: Configure the link mapping for non-MLD FW")
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> drivers/net/wireless/intel/iwlwifi/mvm/link.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/link.c b/drivers/net/wireless/intel/iwlwifi/mvm/link.c
> index 9f69e04594e4..fe5bba8561d0 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/link.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/link.c
> @@ -279,6 +279,7 @@ int iwl_mvm_unset_link_mapping(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
>
> RCU_INIT_POINTER(mvm->link_id_to_link_conf[link_info->fw_link_id],
> NULL);
> + iwl_mvm_release_fw_link_id(mvm, link_info->fw_link_id);
> return 0;
> }
>
> @@ -296,7 +297,6 @@ int iwl_mvm_remove_link(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
> return 0;
>
> cmd.link_id = cpu_to_le32(link_info->fw_link_id);
> - iwl_mvm_release_fw_link_id(mvm, link_info->fw_link_id);
> link_info->fw_link_id = IWL_MVM_FW_LINK_ID_INVALID;
> cmd.spec_link_id = link_conf->link_id;
> cmd.phy_id = cpu_to_le32(FW_CTXT_INVALID);
Hi,
this patch fixes the issue on my old ThinkPad with
Network controller: Intel Corporation Wireless 8265 / 8275 (rev 78)
Tested-by: Tor Vic <torvic9@mailbox.org>
prev parent reply other threads:[~2024-04-24 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 13:44 [PATCH] wifi: iwlwifi: mvm: fix link ID management Johannes Berg
2024-04-24 12:26 ` Tor Vic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d13260ee-e9f5-49fc-b8ea-78c9424c460e@mailbox.org \
--to=torvic9@mailbox.org \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.