From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from a.peacevolution.org (a.peacevolution.org [206.189.193.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F32D3168B06; Thu, 18 Apr 2024 17:50:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=206.189.193.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713462658; cv=none; b=QF6xlZwM0wlt36le8IEhSSCjMF5MEHDK1tKtnslE98zQbogJB3f3SHrGhoMdwchm+nFBidncFUfI+3ET/QXhvGMldzTYULptHdMRwCQTZEYvmKIE6tTl4qT10i3bfPocrlR3oJTEzymHmQIpIoOU5No3c5ZDB42L2CFwzxYkjXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713462658; c=relaxed/simple; bh=rNe8Fy7Y8K2hLaFXzMJJFlHwm2uFh2o7gtVK7iibMas=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pi+rUf/bPmCQ5HVbtgTSotIG1D2NFTpy2LMzVFJ40gy5iVFsrt7vIFK+Pt2/ARRbfEZkF+RkJcv3AnkXre81X+jVFkw3hpZIzKLvF+Fz9anA7gUQpQIdgsmrdSCSloO4mMWOkIDi28z+LJUgEXxQch8KvsN8hMlD07W8fPqbB10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org; spf=pass smtp.mailfrom=peacevolution.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b=dR1AH/e9; arc=none smtp.client-ip=206.189.193.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peacevolution.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b="dR1AH/e9" Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by a.peacevolution.org (Postfix) with ESMTPA id 56A0444E48; Thu, 18 Apr 2024 17:50:54 +0000 (UTC) Date: Thu, 18 Apr 2024 13:50:52 -0400 From: Aren To: Andy Shevchenko Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Liam Girdwood , Mark Brown , Ondrej Jirman , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , linux-iio@vger.kernel.org, phone-devel@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Willow Barraco Subject: Re: [PATCH 2/4] iio: light: stk3310: Implement vdd supply and power it off during suspend Message-ID: References: <20240414175300.956243-1-aren@peacevolution.org> <20240414175716.958831-1-aren@peacevolution.org> <20240414175716.958831-2-aren@peacevolution.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spamd-Bar: / Authentication-Results: auth=pass smtp.auth=aren@peacevolution.org smtp.mailfrom=aren@peacevolution.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peacevolution.org; s=dkim; t=1713462655; h=from:subject:date:message-id:to:cc:mime-version:content-type:content-transfer-encoding:in-reply-to:references; bh=CpuYA2U5zadpTrpInLy8Sg85CTz03F2QsvGOdLrnGeA=; b=dR1AH/e9KzKYSyF/GUm1Q6nVED2/EsOuZ8Eg5UhDFIPVJCfWquLu9qcFxv4fT5yrlV+xzm ojtYymcNuCN6xCcAxKJDRHfnSRZQX8u4hFFQQCvSlHIUfPI4922XfZoe92YYAWUBmUogiU w+yBRCWIPEw/51bWz81gYO3NGCwo6XU= On Thu, Apr 18, 2024 at 06:56:09PM +0300, Andy Shevchenko wrote: > On Thu, Apr 18, 2024 at 6:06 PM Aren wrote: > > On Mon, Apr 15, 2024 at 05:04:53PM +0300, Andy Shevchenko wrote: > > > On Sun, Apr 14, 2024 at 8:57 PM Aren Moynihan wrote: > > ... > > > > > stk3310_set_state(iio_priv(indio_dev), STK3310_STATE_STANDBY); > > > > + if (data->vdd_reg) > > > > + regulator_disable(data->vdd_reg); > > > > > > I forgot to check the order of freeing resources, be sure you have no > > > devm_*() releases happening before this call. > > > > If I understand what you're saying, this should be fine. The driver just > > uses devm to clean up acquired resources after remove is called. Or am I > > missing something and resources could be freed before calling > > stk3310_remove? > > I'm not objecting to that. The point here is that the resources should > be freed in the reversed order. devm-allocated resources are deferred > to be freed after the explicit driver ->remove() callback. At the end > it should not interleave with each other, i.o.w. it should be > probe: devm followed by non-devm > remove: non-devm only. I think what you're describing is already the case, with the exception of parts of the probe function not changed in this patch mixing acquiring resources through devm with configuring the device. I hope I'm not being dense, thanks for the clarification - Aren From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70D82C4345F for ; Thu, 18 Apr 2024 17:51:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8kFLtniAoQrxHQ95/SeR76lH0F4lzk921IpeiuvnD8k=; b=hh0JN3pH7G2dC0 LmNZ0MqVVRUiCrWYpjzeVubNcMyXoFJScQw/9TosogLZ5Ly/lVpI9aSIGo8AdK5Vzz/Azy2tZCuzC 3zANw3bRNvHFyr6TVksWUl8fW+0EVNtdwDiwV4xMsRHJ0ejVjVnTspD2y0eyo+6yNsb1wVMAhaj4d Dxzfou86oHUb1Rh1wtb9S5Oc2hVNYfqQdn5wBXcOPlv8bnTju/rKN9BstzStQPITMm/rRLermrkNX l/lcNwuNdhAao68sHArL/aidM5A/Ou0/zWzUZAK+F15r1VhFa1EObZ4ifeHNJySGq1a8QHE97h/ZU SQuPuTAxJQ2r4cUpzNkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxVuW-00000003Fp1-32HD; Thu, 18 Apr 2024 17:51:00 +0000 Received: from a.peacevolution.org ([206.189.193.133]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxVuT-00000003FoY-42DY for linux-arm-kernel@lists.infradead.org; Thu, 18 Apr 2024 17:50:59 +0000 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by a.peacevolution.org (Postfix) with ESMTPA id 56A0444E48; Thu, 18 Apr 2024 17:50:54 +0000 (UTC) Date: Thu, 18 Apr 2024 13:50:52 -0400 From: Aren To: Andy Shevchenko Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Liam Girdwood , Mark Brown , Ondrej Jirman , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , linux-iio@vger.kernel.org, phone-devel@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Willow Barraco Subject: Re: [PATCH 2/4] iio: light: stk3310: Implement vdd supply and power it off during suspend Message-ID: References: <20240414175300.956243-1-aren@peacevolution.org> <20240414175716.958831-1-aren@peacevolution.org> <20240414175716.958831-2-aren@peacevolution.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spamd-Bar: / Authentication-Results: auth=pass smtp.auth=aren@peacevolution.org smtp.mailfrom=aren@peacevolution.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peacevolution.org; s=dkim; t=1713462655; h=from:subject:date:message-id:to:cc:mime-version:content-type:content-transfer-encoding:in-reply-to:references; bh=CpuYA2U5zadpTrpInLy8Sg85CTz03F2QsvGOdLrnGeA=; b=dR1AH/e9KzKYSyF/GUm1Q6nVED2/EsOuZ8Eg5UhDFIPVJCfWquLu9qcFxv4fT5yrlV+xzm ojtYymcNuCN6xCcAxKJDRHfnSRZQX8u4hFFQQCvSlHIUfPI4922XfZoe92YYAWUBmUogiU w+yBRCWIPEw/51bWz81gYO3NGCwo6XU= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240418_105058_097846_082AF2B0 X-CRM114-Status: GOOD ( 22.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBcHIgMTgsIDIwMjQgYXQgMDY6NTY6MDlQTSArMDMwMCwgQW5keSBTaGV2Y2hlbmtv IHdyb3RlOgo+IE9uIFRodSwgQXByIDE4LCAyMDI0IGF0IDY6MDbigK9QTSBBcmVuIDxhcmVuQHBl YWNldm9sdXRpb24ub3JnPiB3cm90ZToKPiA+IE9uIE1vbiwgQXByIDE1LCAyMDI0IGF0IDA1OjA0 OjUzUE0gKzAzMDAsIEFuZHkgU2hldmNoZW5rbyB3cm90ZToKPiA+ID4gT24gU3VuLCBBcHIgMTQs IDIwMjQgYXQgODo1N+KAr1BNIEFyZW4gTW95bmloYW4gPGFyZW5AcGVhY2V2b2x1dGlvbi5vcmc+ IHdyb3RlOgo+IAo+IC4uLgo+IAo+ID4gPiA+ICAgICAgICAgc3RrMzMxMF9zZXRfc3RhdGUoaWlv X3ByaXYoaW5kaW9fZGV2KSwgU1RLMzMxMF9TVEFURV9TVEFOREJZKTsKPiA+ID4gPiArICAgICAg IGlmIChkYXRhLT52ZGRfcmVnKQo+ID4gPiA+ICsgICAgICAgICAgICAgICByZWd1bGF0b3JfZGlz YWJsZShkYXRhLT52ZGRfcmVnKTsKPiA+ID4KPiA+ID4gSSBmb3Jnb3QgdG8gY2hlY2sgdGhlIG9y ZGVyIG9mIGZyZWVpbmcgcmVzb3VyY2VzLCBiZSBzdXJlIHlvdSBoYXZlIG5vCj4gPiA+IGRldm1f KigpIHJlbGVhc2VzIGhhcHBlbmluZyBiZWZvcmUgdGhpcyBjYWxsLgo+ID4KPiA+IElmIEkgdW5k ZXJzdGFuZCB3aGF0IHlvdSdyZSBzYXlpbmcsIHRoaXMgc2hvdWxkIGJlIGZpbmUuIFRoZSBkcml2 ZXIganVzdAo+ID4gdXNlcyBkZXZtIHRvIGNsZWFuIHVwIGFjcXVpcmVkIHJlc291cmNlcyBhZnRl ciByZW1vdmUgaXMgY2FsbGVkLiBPciBhbSBJCj4gPiBtaXNzaW5nIHNvbWV0aGluZyBhbmQgcmVz b3VyY2VzIGNvdWxkIGJlIGZyZWVkIGJlZm9yZSBjYWxsaW5nCj4gPiBzdGszMzEwX3JlbW92ZT8K PiAKPiBJJ20gbm90IG9iamVjdGluZyB0byB0aGF0LiBUaGUgcG9pbnQgaGVyZSBpcyB0aGF0IHRo ZSByZXNvdXJjZXMgc2hvdWxkCj4gYmUgZnJlZWQgaW4gdGhlIHJldmVyc2VkIG9yZGVyLiBkZXZt LWFsbG9jYXRlZCByZXNvdXJjZXMgYXJlIGRlZmVycmVkCj4gdG8gYmUgZnJlZWQgYWZ0ZXIgdGhl IGV4cGxpY2l0IGRyaXZlciAtPnJlbW92ZSgpIGNhbGxiYWNrLiBBdCB0aGUgZW5kCj4gaXQgc2hv dWxkIG5vdCBpbnRlcmxlYXZlIHdpdGggZWFjaCBvdGhlciwgaS5vLncuIGl0IHNob3VsZCBiZQo+ IHByb2JlOiBkZXZtIGZvbGxvd2VkIGJ5IG5vbi1kZXZtCj4gcmVtb3ZlOiBub24tZGV2bSBvbmx5 LgoKSSB0aGluayB3aGF0IHlvdSdyZSBkZXNjcmliaW5nIGlzIGFscmVhZHkgdGhlIGNhc2UsIHdp dGggdGhlIGV4Y2VwdGlvbgpvZiBwYXJ0cyBvZiB0aGUgcHJvYmUgZnVuY3Rpb24gbm90IGNoYW5n ZWQgaW4gdGhpcyBwYXRjaCBtaXhpbmcKYWNxdWlyaW5nIHJlc291cmNlcyB0aHJvdWdoIGRldm0g d2l0aCBjb25maWd1cmluZyB0aGUgZGV2aWNlLgoKSSBob3BlIEknbSBub3QgYmVpbmcgZGVuc2Us IHRoYW5rcyBmb3IgdGhlIGNsYXJpZmljYXRpb24KIC0gQXJlbgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=