From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from a.peacevolution.org (a.peacevolution.org [206.189.193.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4947E16ABFA; Thu, 18 Apr 2024 15:06:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=206.189.193.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713452809; cv=none; b=lF0vhN1uF/y15BC/Q0BAqUs45o9B4xnMT95jy7lU1x6TwMt9nuWDIlrvHF2bhLOq09FKBNULqKpitaX4+zeWq0OhaZdhlAQhEecOq9yPbn/GfjbnkC/DaQSto+CrBXzahFbnnLEAQblV/eQnMEF1cqZMBrljKJTGL4MzFH9yJEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713452809; c=relaxed/simple; bh=oGcY+BupHlocn3xxw4/g576DsNISjK2nsy9HQ+Z9ZzE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Bbq0bPi8qHN5Rokyzg9yawWN1O5mwHyfmcBT1nxIq1Bk+l01L7z+k5VvV4XlsZpoIv3uRMh+xx6lE0v+QdwSA1DVxvkg++8JAFxuehvPU+wMljkWacPBZNV8VEUjirqDZdHJZ0eHF9tunRozgIlkgiw4jI9MRpdJlLImNgSRK9A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org; spf=pass smtp.mailfrom=peacevolution.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b=p6RTzvLK; arc=none smtp.client-ip=206.189.193.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peacevolution.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b="p6RTzvLK" Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by a.peacevolution.org (Postfix) with ESMTPA id 732C7479B3; Thu, 18 Apr 2024 15:06:35 +0000 (UTC) Date: Thu, 18 Apr 2024 11:06:32 -0400 From: Aren To: Andy Shevchenko Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Liam Girdwood , Mark Brown , Ondrej Jirman , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , linux-iio@vger.kernel.org, phone-devel@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Willow Barraco Subject: Re: [PATCH 2/4] iio: light: stk3310: Implement vdd supply and power it off during suspend Message-ID: References: <20240414175300.956243-1-aren@peacevolution.org> <20240414175716.958831-1-aren@peacevolution.org> <20240414175716.958831-2-aren@peacevolution.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spamd-Bar: / Authentication-Results: auth=pass smtp.auth=aren@peacevolution.org smtp.mailfrom=aren@peacevolution.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peacevolution.org; s=dkim; t=1713452796; h=from:subject:date:message-id:to:cc:mime-version:content-type:content-transfer-encoding:in-reply-to:references; bh=VCd0NHg7beAhJoKEm/QgbRTnUak2JYtg99vMXKxsa0M=; b=p6RTzvLKnixYbPyShowQRtk19eTobmvfGZGGbbHynE1W98DtGm0Vh5jeKHhResC5i2ODzI QmnANwv6xJ5A5/etHiIwvwPYQc8XhSBcelf2FJGftSilB6sfgJ4ltbihnMVY+IUz+N9HFF voTKduELX/t3TDY4UpOiD+UwsPnkvag= On Mon, Apr 15, 2024 at 05:04:53PM +0300, Andy Shevchenko wrote: > On Sun, Apr 14, 2024 at 8:57 PM Aren Moynihan wrote: > > > > From: Ondrej Jirman > > > > VDD power input can be used to completely power off the chip during > > system suspend. Do so if available. > > ... > > > #include > > #include > > #include > > > +#include > > Move it to be ordered and add a blank line to separate iio/*.h group. > > ... > > > + data->vdd_reg = devm_regulator_get_optional(&client->dev, "vdd"); > > + if (IS_ERR(data->vdd_reg)) { > > + ret = PTR_ERR(data->vdd_reg); > > + if (ret == -ENODEV) > > + data->vdd_reg = NULL; > > > + else > > Redundant 'else' when you follow the pattern "check for error condition first". > > > + return dev_err_probe(&client->dev, ret, > > + "get regulator vdd failed\n"); > > + } > > ... > > > + if (data->vdd_reg) { > > + ret = regulator_enable(data->vdd_reg); > > + if (ret) > > + return dev_err_probe(&client->dev, ret, > > + "regulator vdd enable failed\n"); > > + > > + usleep_range(1000, 2000); > > fsleep() > > > + } > > ... > > > stk3310_set_state(iio_priv(indio_dev), STK3310_STATE_STANDBY); > > + if (data->vdd_reg) > > + regulator_disable(data->vdd_reg); > > I forgot to check the order of freeing resources, be sure you have no > devm_*() releases happening before this call. If I understand what you're saying, this should be fine. The driver just uses devm to clean up acquired resources after remove is called. Or am I missing something and resources could be freed before calling stk3310_remove? > ... > > > + usleep_range(1000, 2000); > > fsleep() Everything else makes sense, I'll include those in v2 along with a patch to switch stk3310_init to dev_err_probe. Thanks for taking the time to review - Aren From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FE60C04FF8 for ; Thu, 18 Apr 2024 15:07:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zqSdjdNiw+9bzfEg1KZd+RJObQlZ652Off9S7TvENSE=; b=HAmOXnkLg8eTCm umeoJ/tz+W+gBHWoUrJmpfl7yjMBDKtKITgbDe4znVdbT6NyTWJagD+vQvk8BDhM7m3ESNpj1IPhP Njho6yS8kMWql25YNuIOYeT5cWxCZksu1HdNzAzmDyJL741Nvrotr9kKu2HeVOOkwwAxL5OuKEB5L XG7hACJRi1tcwvfhIRJO/hkG6Nvi2Jd8N/jeJNqjmnsH8veaaGSXeZ208cbwbmz2ZtcHNSOryEvSN d2ctfJ9kUqGKvXJ3mA9ZIuTWkhJwHAoZapoPcUzZGI0KKhtRp+Ie9Yosw7nzXlzTd4EwwNXGgYtKf 9Nc0DCT5Yf7qPmw1AfRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxTLg-00000002jmE-2MiT; Thu, 18 Apr 2024 15:06:52 +0000 Received: from a.peacevolution.org ([206.189.193.133]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxTLX-00000002jj1-1X92 for linux-arm-kernel@lists.infradead.org; Thu, 18 Apr 2024 15:06:51 +0000 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by a.peacevolution.org (Postfix) with ESMTPA id 732C7479B3; Thu, 18 Apr 2024 15:06:35 +0000 (UTC) Date: Thu, 18 Apr 2024 11:06:32 -0400 From: Aren To: Andy Shevchenko Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Liam Girdwood , Mark Brown , Ondrej Jirman , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , linux-iio@vger.kernel.org, phone-devel@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Willow Barraco Subject: Re: [PATCH 2/4] iio: light: stk3310: Implement vdd supply and power it off during suspend Message-ID: References: <20240414175300.956243-1-aren@peacevolution.org> <20240414175716.958831-1-aren@peacevolution.org> <20240414175716.958831-2-aren@peacevolution.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spamd-Bar: / Authentication-Results: auth=pass smtp.auth=aren@peacevolution.org smtp.mailfrom=aren@peacevolution.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peacevolution.org; s=dkim; t=1713452796; h=from:subject:date:message-id:to:cc:mime-version:content-type:content-transfer-encoding:in-reply-to:references; bh=VCd0NHg7beAhJoKEm/QgbRTnUak2JYtg99vMXKxsa0M=; b=p6RTzvLKnixYbPyShowQRtk19eTobmvfGZGGbbHynE1W98DtGm0Vh5jeKHhResC5i2ODzI QmnANwv6xJ5A5/etHiIwvwPYQc8XhSBcelf2FJGftSilB6sfgJ4ltbihnMVY+IUz+N9HFF voTKduELX/t3TDY4UpOiD+UwsPnkvag= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240418_080643_566232_4EA73A27 X-CRM114-Status: GOOD ( 18.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBcHIgMTUsIDIwMjQgYXQgMDU6MDQ6NTNQTSArMDMwMCwgQW5keSBTaGV2Y2hlbmtv IHdyb3RlOgo+IE9uIFN1biwgQXByIDE0LCAyMDI0IGF0IDg6NTfigK9QTSBBcmVuIE1veW5paGFu IDxhcmVuQHBlYWNldm9sdXRpb24ub3JnPiB3cm90ZToKPiA+Cj4gPiBGcm9tOiBPbmRyZWogSmly bWFuIDxtZWdpQHhmZi5jej4KPiA+Cj4gPiBWREQgcG93ZXIgaW5wdXQgY2FuIGJlIHVzZWQgdG8g Y29tcGxldGVseSBwb3dlciBvZmYgdGhlIGNoaXAgZHVyaW5nCj4gPiBzeXN0ZW0gc3VzcGVuZC4g RG8gc28gaWYgYXZhaWxhYmxlLgo+IAo+IC4uLgo+IAo+ID4gICNpbmNsdWRlIDxsaW51eC9paW8v ZXZlbnRzLmg+Cj4gPiAgI2luY2x1ZGUgPGxpbnV4L2lpby9paW8uaD4KPiA+ICAjaW5jbHVkZSA8 bGludXgvaWlvL3N5c2ZzLmg+Cj4gCj4gPiArI2luY2x1ZGUgPGxpbnV4L3JlZ3VsYXRvci9jb25z dW1lci5oPgo+IAo+IE1vdmUgaXQgdG8gYmUgb3JkZXJlZCBhbmQgYWRkIGEgYmxhbmsgbGluZSB0 byBzZXBhcmF0ZSBpaW8vKi5oIGdyb3VwLgo+IAo+IC4uLgo+IAo+ID4gKyAgICAgICBkYXRhLT52 ZGRfcmVnID0gZGV2bV9yZWd1bGF0b3JfZ2V0X29wdGlvbmFsKCZjbGllbnQtPmRldiwgInZkZCIp Owo+ID4gKyAgICAgICBpZiAoSVNfRVJSKGRhdGEtPnZkZF9yZWcpKSB7Cj4gPiArICAgICAgICAg ICAgICAgcmV0ID0gUFRSX0VSUihkYXRhLT52ZGRfcmVnKTsKPiA+ICsgICAgICAgICAgICAgICBp ZiAocmV0ID09IC1FTk9ERVYpCj4gPiArICAgICAgICAgICAgICAgICAgICAgICBkYXRhLT52ZGRf cmVnID0gTlVMTDsKPiAKPiA+ICsgICAgICAgICAgICAgICBlbHNlCj4gCj4gUmVkdW5kYW50ICdl bHNlJyB3aGVuIHlvdSBmb2xsb3cgdGhlIHBhdHRlcm4gImNoZWNrIGZvciBlcnJvciBjb25kaXRp b24gZmlyc3QiLgo+IAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGRldl9lcnJf cHJvYmUoJmNsaWVudC0+ZGV2LCByZXQsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAiZ2V0IHJlZ3VsYXRvciB2ZGQgZmFpbGVkXG4iKTsKPiA+ICsgICAg ICAgfQo+IAo+IC4uLgo+IAo+ID4gKyAgICAgICBpZiAoZGF0YS0+dmRkX3JlZykgewo+ID4gKyAg ICAgICAgICAgICAgIHJldCA9IHJlZ3VsYXRvcl9lbmFibGUoZGF0YS0+dmRkX3JlZyk7Cj4gPiAr ICAgICAgICAgICAgICAgaWYgKHJldCkKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIHJldHVy biBkZXZfZXJyX3Byb2JlKCZjbGllbnQtPmRldiwgcmV0LAo+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgInJlZ3VsYXRvciB2ZGQgZW5hYmxlIGZhaWxlZFxu Iik7Cj4gPiArCj4gPiArICAgICAgICAgICAgICAgdXNsZWVwX3JhbmdlKDEwMDAsIDIwMDApOwo+ IAo+IGZzbGVlcCgpCj4gCj4gPiArICAgICAgIH0KPiAKPiAuLi4KPiAKPiA+ICAgICAgICAgc3Rr MzMxMF9zZXRfc3RhdGUoaWlvX3ByaXYoaW5kaW9fZGV2KSwgU1RLMzMxMF9TVEFURV9TVEFOREJZ KTsKPiA+ICsgICAgICAgaWYgKGRhdGEtPnZkZF9yZWcpCj4gPiArICAgICAgICAgICAgICAgcmVn dWxhdG9yX2Rpc2FibGUoZGF0YS0+dmRkX3JlZyk7Cj4gCj4gSSBmb3Jnb3QgdG8gY2hlY2sgdGhl IG9yZGVyIG9mIGZyZWVpbmcgcmVzb3VyY2VzLCBiZSBzdXJlIHlvdSBoYXZlIG5vCj4gZGV2bV8q KCkgcmVsZWFzZXMgaGFwcGVuaW5nIGJlZm9yZSB0aGlzIGNhbGwuCgpJZiBJIHVuZGVyc3RhbmQg d2hhdCB5b3UncmUgc2F5aW5nLCB0aGlzIHNob3VsZCBiZSBmaW5lLiBUaGUgZHJpdmVyIGp1c3QK dXNlcyBkZXZtIHRvIGNsZWFuIHVwIGFjcXVpcmVkIHJlc291cmNlcyBhZnRlciByZW1vdmUgaXMg Y2FsbGVkLiBPciBhbSBJCm1pc3Npbmcgc29tZXRoaW5nIGFuZCByZXNvdXJjZXMgY291bGQgYmUg ZnJlZWQgYmVmb3JlIGNhbGxpbmcKc3RrMzMxMF9yZW1vdmU/Cgo+IC4uLgo+IAo+ID4gKyAgICAg ICAgICAgICAgIHVzbGVlcF9yYW5nZSgxMDAwLCAyMDAwKTsKPiAKPiBmc2xlZXAoKQoKRXZlcnl0 aGluZyBlbHNlIG1ha2VzIHNlbnNlLCBJJ2xsIGluY2x1ZGUgdGhvc2UgaW4gdjIgYWxvbmcgd2l0 aCBhIHBhdGNoCnRvIHN3aXRjaCBzdGszMzEwX2luaXQgdG8gZGV2X2Vycl9wcm9iZS4KClRoYW5r cyBmb3IgdGFraW5nIHRoZSB0aW1lIHRvIHJldmlldwogLSBBcmVuCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==