* [PATCH] wifi: brcmsmac: ampdu: remove unused cb_del_ampdu_pars struct
@ 2024-04-25 9:22 Christophe JAILLET
2024-04-25 11:47 ` Arend van Spriel
2024-04-26 10:36 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2024-04-25 9:22 UTC (permalink / raw
To: Arend van Spriel, Kalle Valo
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-wireless,
brcm80211, brcm80211-dev-list.pdl
struct cb_del_ampdu_pars was added in the initial commit 5b435de0d7868
("net: wireless: add brcm80211 drivers") and its only usage was removed in
commit e041f65d5f00 ("brcmsmac: Remove internal tx queue").
Remove the structure definition now. This saves a few lines of code.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only
---
drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c
index e859075db716..c3376f887114 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c
@@ -143,12 +143,6 @@ struct ampdu_info {
struct brcms_fifo_info fifo_tb[NUM_FFPLD_FIFO];
};
-/* used for flushing ampdu packets */
-struct cb_del_ampdu_pars {
- struct ieee80211_sta *sta;
- u16 tid;
-};
-
static void brcms_c_scb_ampdu_update_max_txlen(struct ampdu_info *ampdu, u8 dur)
{
u32 rate, mcs;
--
2.44.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] wifi: brcmsmac: ampdu: remove unused cb_del_ampdu_pars struct
2024-04-25 9:22 [PATCH] wifi: brcmsmac: ampdu: remove unused cb_del_ampdu_pars struct Christophe JAILLET
@ 2024-04-25 11:47 ` Arend van Spriel
2024-04-26 10:36 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Arend van Spriel @ 2024-04-25 11:47 UTC (permalink / raw
To: Christophe JAILLET, Kalle Valo
Cc: linux-kernel, kernel-janitors, linux-wireless, brcm80211,
brcm80211-dev-list.pdl
[-- Attachment #1: Type: text/plain, Size: 630 bytes --]
On 4/25/2024 11:22 AM, Christophe JAILLET wrote:
> struct cb_del_ampdu_pars was added in the initial commit 5b435de0d7868
> ("net: wireless: add brcm80211 drivers") and its only usage was removed in
> commit e041f65d5f00 ("brcmsmac: Remove internal tx queue").
>
> Remove the structure definition now. This saves a few lines of code.
Thanks. Looks good to me.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested only
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c | 6 ------
> 1 file changed, 6 deletions(-)
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wifi: brcmsmac: ampdu: remove unused cb_del_ampdu_pars struct
2024-04-25 9:22 [PATCH] wifi: brcmsmac: ampdu: remove unused cb_del_ampdu_pars struct Christophe JAILLET
2024-04-25 11:47 ` Arend van Spriel
@ 2024-04-26 10:36 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2024-04-26 10:36 UTC (permalink / raw
To: Christophe JAILLET
Cc: Arend van Spriel, linux-kernel, kernel-janitors,
Christophe JAILLET, linux-wireless, brcm80211,
brcm80211-dev-list.pdl
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> struct cb_del_ampdu_pars was added in the initial commit 5b435de0d7868
> ("net: wireless: add brcm80211 drivers") and its only usage was removed in
> commit e041f65d5f00 ("brcmsmac: Remove internal tx queue").
>
> Remove the structure definition now. This saves a few lines of code.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Patch applied to wireless-next.git, thanks.
931c98463082 wifi: brcmsmac: ampdu: remove unused cb_del_ampdu_pars struct
--
https://patchwork.kernel.org/project/linux-wireless/patch/fa3b190b6e9cba65ecc36fc93121c6ed8704f704.1714036681.git.christophe.jaillet@wanadoo.fr/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-26 10:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-25 9:22 [PATCH] wifi: brcmsmac: ampdu: remove unused cb_del_ampdu_pars struct Christophe JAILLET
2024-04-25 11:47 ` Arend van Spriel
2024-04-26 10:36 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).