* [bluez/bluez] f78e63: shared/bap: clean up requests for a stream before ...
@ 2024-04-16 15:32 Pauli Virtanen
0 siblings, 0 replies; only message in thread
From: Pauli Virtanen @ 2024-04-16 15:32 UTC (permalink / raw
To: linux-bluetooth
Branch: refs/heads/master
Home: https://github.com/bluez/bluez
Commit: f78e639f810cb9b7469ad55af0af1dc930ac8502
https://github.com/bluez/bluez/commit/f78e639f810cb9b7469ad55af0af1dc930ac8502
Author: Pauli Virtanen <pav@iki.fi>
Date: 2024-04-16 (Tue, 16 Apr 2024)
Changed paths:
M src/shared/bap.c
Log Message:
-----------
shared/bap: clean up requests for a stream before freeing it
Cancel stream's queued requests before freeing the stream.
As the callbacks may do some cleanup on error, be sure to call them
before removing the requests.
Fixes:
=======================================================================
ERROR: AddressSanitizer: heap-use-after-free on address 0x60d000013430
READ of size 8 at 0x60d000013430 thread T0
#0 0x89cb9f in stream_stop_complete src/shared/bap.c:1211
#1 0x89c997 in bap_req_complete src/shared/bap.c:1192
#2 0x8a105f in bap_process_queue src/shared/bap.c:1474
#3 0x93c93f in timeout_callback src/shared/timeout-glib.c:25
...
freed by thread T0 here:
#1 0x89b744 in bap_stream_free src/shared/bap.c:1105
#2 0x89bac8 in bap_stream_detach src/shared/bap.c:1122
#3 0x89dbfc in bap_stream_state_changed src/shared/bap.c:1261
#4 0x8a2169 in bap_ucast_set_state src/shared/bap.c:1554
#5 0x89e0d5 in stream_set_state src/shared/bap.c:1291
#6 0x8a78b6 in bap_ucast_release src/shared/bap.c:1927
#7 0x8d45bb in bt_bap_stream_release src/shared/bap.c:5516
#8 0x8ba63f in remove_streams src/shared/bap.c:3538
#9 0x7f23d0 in queue_foreach src/shared/queue.c:207
#10 0x8bb875 in bt_bap_remove_pac src/shared/bap.c:3593
#11 0x47416c in media_endpoint_destroy profiles/audio/media.c:185
=======================================================================
Commit: d3a6a6459cbda91693106fb8d43de319b334a3a4
https://github.com/bluez/bluez/commit/d3a6a6459cbda91693106fb8d43de319b334a3a4
Author: Pauli Virtanen <pav@iki.fi>
Date: 2024-04-16 (Tue, 16 Apr 2024)
Changed paths:
M profiles/audio/bap.c
Log Message:
-----------
bap: cancel stream operation before freeing setup
Before freeing setup, cancel any ongoing stream operations, and indicate
failure for pending DBus replies.
Fixes:
=======================================================================
ERROR: AddressSanitizer: heap-use-after-free on address 0x60d000004758
WRITE of size 4 at 0x60d000004758 thread T0
#0 0x557159 in qos_cb profiles/audio/bap.c:753
#1 0x89c38f in bap_req_complete src/shared/bap.c:1191
#2 0x8cb7fc in bap_req_detach src/shared/bap.c:4789
#3 0x8cb9bb in bt_bap_detach src/shared/bap.c:4801
#4 0x571e25 in bap_disconnect profiles/audio/bap.c:3011
...
freed by thread T0 here:
#1 0x558f2b in setup_free profiles/audio/bap.c:890
#2 0x7f34e8 in queue_remove_all src/shared/queue.c:341
#3 0x7f0105 in queue_destroy src/shared/queue.c:60
#4 0x55cdc8 in ep_free profiles/audio/bap.c:1167
=======================================================================
Commit: b411b98bf4f51c18c77626f786a4f2b8cdc28982
https://github.com/bluez/bluez/commit/b411b98bf4f51c18c77626f786a4f2b8cdc28982
Author: Pauli Virtanen <pav@iki.fi>
Date: 2024-04-16 (Tue, 16 Apr 2024)
Changed paths:
M src/set.c
M src/set.h
Log Message:
-----------
set: don't modify input sirk key in btd_set_add_device()
Currently, btd_set_add_device decrypts the sirk in-place, modifying the
key passed to it.
This causes store_sirk() later on to save the wrong (decrypted) key
value, resulting to invalid duplicate device set.
It also allows devices->sirk list to contain same set multiple times,
which crashes later on as sirks-set are assumed to be 1-to-1 in
btd_set_add/remove_device().
Fixes:
=======================================================================
ERROR: AddressSanitizer: heap-use-after-free on address 0x60600001c068
READ of size 8 at 0x60600001c068 thread T0
#0 0x762721 in btd_set_remove_device src/set.c:347
#1 0x7341e7 in remove_sirk_info src/device.c:7145
#2 0x7f2cee in queue_foreach src/shared/queue.c:207
#3 0x734499 in btd_device_unref src/device.c:7159
#4 0x719f65 in device_remove src/device.c:4788
#5 0x682382 in adapter_remove src/adapter.c:6959
...
0x60600001c068 is located 40 bytes inside of 56-byte region [0x60600001c040,0x60600001c078)
freed by thread T0 here:
#1 0x7605a6 in set_free src/set.c:170
#2 0x7d4eff in remove_interface gdbus/object.c:660
#3 0x7dcbb3 in g_dbus_unregister_interface gdbus/object.c:1394
#4 0x762990 in btd_set_remove_device src/set.c:362
#5 0x7341e7 in remove_sirk_info src/device.c:7145
#6 0x7f2cee in queue_foreach src/shared/queue.c:207
#7 0x734499 in btd_device_unref src/device.c:7159
#8 0x719f65 in device_remove src/device.c:4788
#9 0x682382 in adapter_remove src/adapter.c:6959
...
previously allocated by thread T0 here:
#1 0x7f5429 in util_malloc src/shared/util.c:46
#2 0x7605f1 in set_new src/set.c:178
#3 0x7625b9 in btd_set_add_device src/set.c:324
#4 0x6f8fc8 in add_set src/device.c:1916
#5 0x7f2cee in queue_foreach src/shared/queue.c:207
#6 0x6f982c in device_set_ltk src/device.c:1940
#7 0x667b97 in load_ltks src/adapter.c:4478
...
=======================================================================
Compare: https://github.com/bluez/bluez/compare/b94f1be656f3...b411b98bf4f5
To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-04-16 15:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-16 15:32 [bluez/bluez] f78e63: shared/bap: clean up requests for a stream before Pauli Virtanen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).