From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: Conor Dooley <conor@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: media: renesas,isp: Add binding for V4M
Date: Mon, 27 May 2024 19:54:02 +0200 [thread overview]
Message-ID: <20240527175402.GI1900917@fsdn.se> (raw)
In-Reply-To: <20240527-causal-flyable-c34004c298bf@spud>
Hi Conor,
Thanks for your feedback.
On 2024-05-27 17:36:23 +0100, Conor Dooley wrote:
> On Mon, May 27, 2024 at 03:19:45PM +0200, Niklas Söderlund wrote:
> > Document support for the ISP module in the Renesas V4M (r8a779h0) SoC.
> >
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
> Should be with:
> https://lore.kernel.org/all/20240527132513.1684232-1-niklas.soderlund+renesas@ragnatech.se/
I posted the bindings separate from the driver with the intention that
once they are accepted I can upstream the driver and the DT for the
device using it in parallel. The V4L2 subsystem is at times overloaded
and in the past waiting for both driver and binding to be accepted as a
whole unit have delayed entablement of SoC features unneeded for one or
more releases.
>
> No mention of why this can't just fall back to an existing device here
> or in the driver. Why not?
For better or worse that is how all Renesas devices are handled, one new
device compatible for each device. This have worked well as each device
usually have a quirk or extra future that is enabled later.
>
> > ---
> > Documentation/devicetree/bindings/media/renesas,isp.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/renesas,isp.yaml b/Documentation/devicetree/bindings/media/renesas,isp.yaml
> > index 33650a1ea034..d335d5595429 100644
> > --- a/Documentation/devicetree/bindings/media/renesas,isp.yaml
> > +++ b/Documentation/devicetree/bindings/media/renesas,isp.yaml
> > @@ -22,6 +22,7 @@ properties:
> > - enum:
> > - renesas,r8a779a0-isp # V3U
> > - renesas,r8a779g0-isp # V4H
> > + - renesas,r8a779h0-isp # V4M
> > reg:
> > maxItems: 1
> >
> > --
> > 2.45.1
> >
--
Kind Regards,
Niklas Söderlund
next prev parent reply other threads:[~2024-05-27 17:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 13:19 [PATCH] dt-bindings: media: renesas,isp: Add binding for V4M Niklas Söderlund
2024-05-27 16:36 ` Conor Dooley
2024-05-27 17:54 ` Niklas Söderlund [this message]
2024-05-27 18:07 ` Conor Dooley
2024-06-04 7:38 ` Geert Uytterhoeven
2024-06-04 9:18 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240527175402.GI1900917@fsdn.se \
--to=niklas.soderlund+renesas@ragnatech.se \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).