From: git@luigi311.com
To: linux-media@vger.kernel.org
Cc: dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com,
mchehab@kernel.org, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com,
sakari.ailus@linux.intel.com, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, pavel@ucw.cz,
phone-devel@vger.kernel.org, Luis Garcia <git@luigi311.com>
Subject: [PATCH v6 14/23] media: i2c: imx258: Issue reset before starting streaming
Date: Sun, 2 Jun 2024 14:13:36 -0600 [thread overview]
Message-ID: <20240602201345.328737-15-git@luigi311.com> (raw)
In-Reply-To: <20240602201345.328737-1-git@luigi311.com>
From: Dave Stevenson <dave.stevenson@raspberrypi.com>
Whilst not documented, register 0x0103 bit 0 is the soft
reset for the sensor, so send it before trying to configure
the sensor.
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Luis Garcia <git@luigi311.com>
Reviewed-by: Pavel Machek <pavel@ucw.cz>
---
drivers/media/i2c/imx258.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c
index c1a2c2406aaa..9c83ba1232fa 100644
--- a/drivers/media/i2c/imx258.c
+++ b/drivers/media/i2c/imx258.c
@@ -20,6 +20,8 @@
#define IMX258_MODE_STANDBY 0x00
#define IMX258_MODE_STREAMING 0x01
+#define IMX258_REG_RESET 0x0103
+
/* Chip ID */
#define IMX258_REG_CHIP_ID 0x0016
#define IMX258_CHIP_ID 0x0258
@@ -1052,6 +1054,16 @@ static int imx258_start_streaming(struct imx258 *imx258)
const struct imx258_link_freq_config *link_freq_cfg;
int ret, link_freq_index;
+ ret = imx258_write_reg(imx258, IMX258_REG_RESET, IMX258_REG_VALUE_08BIT,
+ 0x01);
+ if (ret) {
+ dev_err(&client->dev, "%s failed to reset sensor\n", __func__);
+ return ret;
+ }
+
+ /* 12ms is required from poweron to standby */
+ fsleep(12000);
+
/* Setup PLL */
link_freq_index = imx258->cur_mode->link_freq_index;
link_freq_cfg = &imx258->link_freq_configs[link_freq_index];
--
2.44.0
next prev parent reply other threads:[~2024-06-02 20:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-02 20:13 [PATCH v6 00/23] imx258 improvement series git
2024-06-02 20:13 ` [PATCH v6 01/23] media: i2c: imx258: Remove unused defines git
2024-06-02 20:13 ` [PATCH v6 02/23] media: i2c: imx258: Make image geometry meet sensor requirements git
2024-06-02 20:13 ` [PATCH v6 03/23] media: i2c: imx258: Disable digital cropping on binned modes git
2024-06-02 20:13 ` [PATCH v6 04/23] media: i2c: imx258: Remove redundant I2C writes git
2024-06-02 20:13 ` [PATCH v6 05/23] media: i2c: imx258: Add regulator control git
2024-06-02 20:13 ` [PATCH v6 06/23] media: i2c: imx258: Make V4L2_CID_VBLANK configurable git
2024-06-02 20:13 ` [PATCH v6 07/23] media: i2c: imx258: Split out common registers from the mode based ones git
2024-06-02 20:13 ` [PATCH v6 08/23] media: i2c: imx258: Add support for 24MHz clock git
2024-06-02 20:13 ` [PATCH v6 09/23] media: i2c: imx258: Add support for running on 2 CSI data lanes git
2024-06-02 20:13 ` [PATCH v6 10/23] media: i2c: imx258: Follow normal V4L2 behaviours for clipping exposure git
2024-06-02 20:13 ` [PATCH v6 11/23] media: i2c: imx258: Add get_selection for pixel array information git
2024-06-02 20:13 ` [PATCH v6 12/23] media: i2c: imx258: Allow configuration of clock lane behaviour git
2024-06-02 20:13 ` [PATCH v6 13/23] media: i2c: imx258: Correct max FRM_LENGTH_LINES value git
2024-06-02 20:13 ` git [this message]
2024-06-02 20:13 ` [PATCH v6 15/23] media: i2c: imx258: Set pixel_rate range to the same as the value git
2024-06-02 20:13 ` [PATCH v6 16/23] media: i2c: imx258: Support faster pixel rate on binned modes git
2024-06-02 20:13 ` [PATCH v6 17/23] dt-bindings: media: imx258: Rename to include vendor prefix git
2024-06-02 20:13 ` [PATCH v6 18/23] dt-bindings: media: imx258: Add alternate compatible strings git
2024-06-02 20:13 ` [PATCH v6 19/23] media: i2c: imx258: Change register settings for variants of the sensor git
2024-06-02 20:13 ` [PATCH v6 20/23] media: i2c: imx258: Make HFLIP and VFLIP controls writable git
2024-06-02 20:13 ` [PATCH v6 21/23] media: i2c: imx258: Add support for reset gpio git
2024-06-02 20:13 ` [PATCH v6 22/23] media: i2c: imx258: Use v4l2_link_freq_to_bitmap helper git
2024-06-02 20:13 ` [PATCH v6 23/23] media: i2c: imx258: Convert to new CCI register access helpers git
2024-06-03 7:07 ` [PATCH v6 00/23] imx258 improvement series Luis Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240602201345.328737-15-git@luigi311.com \
--to=git@luigi311.com \
--cc=conor+dt@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pavel@ucw.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).