* [PATCH] dt-bindings: media: renesas,isp: Add binding for V4M
@ 2024-05-27 13:19 Niklas Söderlund
2024-05-27 16:36 ` Conor Dooley
2024-06-04 7:38 ` Geert Uytterhoeven
0 siblings, 2 replies; 6+ messages in thread
From: Niklas Söderlund @ 2024-05-27 13:19 UTC (permalink / raw
To: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Geert Uytterhoeven, linux-media, devicetree
Cc: linux-renesas-soc, Niklas Söderlund
Document support for the ISP module in the Renesas V4M (r8a779h0) SoC.
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
Documentation/devicetree/bindings/media/renesas,isp.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/renesas,isp.yaml b/Documentation/devicetree/bindings/media/renesas,isp.yaml
index 33650a1ea034..d335d5595429 100644
--- a/Documentation/devicetree/bindings/media/renesas,isp.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,isp.yaml
@@ -22,6 +22,7 @@ properties:
- enum:
- renesas,r8a779a0-isp # V3U
- renesas,r8a779g0-isp # V4H
+ - renesas,r8a779h0-isp # V4M
reg:
maxItems: 1
--
2.45.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: media: renesas,isp: Add binding for V4M
2024-05-27 13:19 [PATCH] dt-bindings: media: renesas,isp: Add binding for V4M Niklas Söderlund
@ 2024-05-27 16:36 ` Conor Dooley
2024-05-27 17:54 ` Niklas Söderlund
2024-06-04 7:38 ` Geert Uytterhoeven
1 sibling, 1 reply; 6+ messages in thread
From: Conor Dooley @ 2024-05-27 16:36 UTC (permalink / raw
To: Niklas Söderlund
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Geert Uytterhoeven, linux-media, devicetree,
linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]
On Mon, May 27, 2024 at 03:19:45PM +0200, Niklas Söderlund wrote:
> Document support for the ISP module in the Renesas V4M (r8a779h0) SoC.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Should be with:
https://lore.kernel.org/all/20240527132513.1684232-1-niklas.soderlund+renesas@ragnatech.se/
No mention of why this can't just fall back to an existing device here
or in the driver. Why not?
> ---
> Documentation/devicetree/bindings/media/renesas,isp.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,isp.yaml b/Documentation/devicetree/bindings/media/renesas,isp.yaml
> index 33650a1ea034..d335d5595429 100644
> --- a/Documentation/devicetree/bindings/media/renesas,isp.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,isp.yaml
> @@ -22,6 +22,7 @@ properties:
> - enum:
> - renesas,r8a779a0-isp # V3U
> - renesas,r8a779g0-isp # V4H
> + - renesas,r8a779h0-isp # V4M
> reg:
> maxItems: 1
>
> --
> 2.45.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: media: renesas,isp: Add binding for V4M
2024-05-27 16:36 ` Conor Dooley
@ 2024-05-27 17:54 ` Niklas Söderlund
2024-05-27 18:07 ` Conor Dooley
0 siblings, 1 reply; 6+ messages in thread
From: Niklas Söderlund @ 2024-05-27 17:54 UTC (permalink / raw
To: Conor Dooley
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Geert Uytterhoeven, linux-media, devicetree,
linux-renesas-soc
Hi Conor,
Thanks for your feedback.
On 2024-05-27 17:36:23 +0100, Conor Dooley wrote:
> On Mon, May 27, 2024 at 03:19:45PM +0200, Niklas Söderlund wrote:
> > Document support for the ISP module in the Renesas V4M (r8a779h0) SoC.
> >
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
> Should be with:
> https://lore.kernel.org/all/20240527132513.1684232-1-niklas.soderlund+renesas@ragnatech.se/
I posted the bindings separate from the driver with the intention that
once they are accepted I can upstream the driver and the DT for the
device using it in parallel. The V4L2 subsystem is at times overloaded
and in the past waiting for both driver and binding to be accepted as a
whole unit have delayed entablement of SoC features unneeded for one or
more releases.
>
> No mention of why this can't just fall back to an existing device here
> or in the driver. Why not?
For better or worse that is how all Renesas devices are handled, one new
device compatible for each device. This have worked well as each device
usually have a quirk or extra future that is enabled later.
>
> > ---
> > Documentation/devicetree/bindings/media/renesas,isp.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/renesas,isp.yaml b/Documentation/devicetree/bindings/media/renesas,isp.yaml
> > index 33650a1ea034..d335d5595429 100644
> > --- a/Documentation/devicetree/bindings/media/renesas,isp.yaml
> > +++ b/Documentation/devicetree/bindings/media/renesas,isp.yaml
> > @@ -22,6 +22,7 @@ properties:
> > - enum:
> > - renesas,r8a779a0-isp # V3U
> > - renesas,r8a779g0-isp # V4H
> > + - renesas,r8a779h0-isp # V4M
> > reg:
> > maxItems: 1
> >
> > --
> > 2.45.1
> >
--
Kind Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: media: renesas,isp: Add binding for V4M
2024-05-27 17:54 ` Niklas Söderlund
@ 2024-05-27 18:07 ` Conor Dooley
0 siblings, 0 replies; 6+ messages in thread
From: Conor Dooley @ 2024-05-27 18:07 UTC (permalink / raw
To: Niklas Söderlund
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Geert Uytterhoeven, linux-media, devicetree,
linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 2006 bytes --]
On Mon, May 27, 2024 at 07:54:02PM +0200, Niklas Söderlund wrote:
> Hi Conor,
>
> Thanks for your feedback.
>
> On 2024-05-27 17:36:23 +0100, Conor Dooley wrote:
> > On Mon, May 27, 2024 at 03:19:45PM +0200, Niklas Söderlund wrote:
> > > Document support for the ISP module in the Renesas V4M (r8a779h0) SoC.
> > >
> > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> >
> > Should be with:
> > https://lore.kernel.org/all/20240527132513.1684232-1-niklas.soderlund+renesas@ragnatech.se/
>
> I posted the bindings separate from the driver with the intention that
> once they are accepted I can upstream the driver and the DT for the
> device using it in parallel. The V4L2 subsystem is at times overloaded
> and in the past waiting for both driver and binding to be accepted as a
> whole unit have delayed entablement of SoC features unneeded for one or
> more releases.
I don't really understand this argument at all. If you land the binding
but not the driver changes, you're still waiting for the driver to get
the feature functional. My understanding is that Geert takes dts patches
when bindings are applied by the subsystems, rather than wait until they
circle back to his tree a release later - so that isn't the issue either.
All it seems like you're doing to me is making my "job" reviewing
bindings harder, because I have to search on lore for your driver
patches.
> > No mention of why this can't just fall back to an existing device here
> > or in the driver. Why not?
>
> For better or worse that is how all Renesas devices are handled, one new
> device compatible for each device. This have worked well as each device
> usually have a quirk or extra future that is enabled later.
If you're worried about the media subsystem being too busy to pick up
patches with driver support, you know what's a way you can have the
driver functional without a code change?
/spoiler You guessed it, fallback compatibles!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: media: renesas,isp: Add binding for V4M
2024-05-27 13:19 [PATCH] dt-bindings: media: renesas,isp: Add binding for V4M Niklas Söderlund
2024-05-27 16:36 ` Conor Dooley
@ 2024-06-04 7:38 ` Geert Uytterhoeven
2024-06-04 9:18 ` Niklas Söderlund
1 sibling, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2024-06-04 7:38 UTC (permalink / raw
To: Niklas Söderlund
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Geert Uytterhoeven, linux-media, devicetree,
linux-renesas-soc
Hi Niklas,
On Mon, May 27, 2024 at 3:20 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> Document support for the ISP module in the Renesas V4M (r8a779h0) SoC.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Thanks for your patch!
> --- a/Documentation/devicetree/bindings/media/renesas,isp.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,isp.yaml
> @@ -22,6 +22,7 @@ properties:
> - enum:
> - renesas,r8a779a0-isp # V3U
> - renesas,r8a779g0-isp # V4H
> + - renesas,r8a779h0-isp # V4M
> reg:
> maxItems: 1
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
BTW, this binding only describes a single register block, while the
ISP seems to have two: CS and CORE (the second one is optional, as it
does not exist for the second instance of R-Car V4M)?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: media: renesas,isp: Add binding for V4M
2024-06-04 7:38 ` Geert Uytterhoeven
@ 2024-06-04 9:18 ` Niklas Söderlund
0 siblings, 0 replies; 6+ messages in thread
From: Niklas Söderlund @ 2024-06-04 9:18 UTC (permalink / raw
To: Geert Uytterhoeven
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Geert Uytterhoeven, linux-media, devicetree,
linux-renesas-soc
Hi Geert,
Thanks for your review.
On 2024-06-04 09:38:04 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Mon, May 27, 2024 at 3:20 PM Niklas Söderlund
> <niklas.soderlund+renesas@ragnatech.se> wrote:
> > Document support for the ISP module in the Renesas V4M (r8a779h0) SoC.
> >
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/media/renesas,isp.yaml
> > +++ b/Documentation/devicetree/bindings/media/renesas,isp.yaml
> > @@ -22,6 +22,7 @@ properties:
> > - enum:
> > - renesas,r8a779a0-isp # V3U
> > - renesas,r8a779g0-isp # V4H
> > + - renesas,r8a779h0-isp # V4M
> > reg:
> > maxItems: 1
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> BTW, this binding only describes a single register block, while the
> ISP seems to have two: CS and CORE (the second one is optional, as it
> does not exist for the second instance of R-Car V4M)?
Yes. The R-Car ISP have two different functions, CSI-2 Channel Selection
(CS) and a more traditional ISP block to do cool stuff to image data
(core). We only have documentation for the CS, and only that which is
needed to setup CSI-2 reception and forward data to a capture engine
(VIN), so this is all the rcar-isp driver deals with.
For the interested, difference between generations,
On Gen3 the capture pipeline is $source -> rcar-csi2 -> rcar-vin. The
CSI-2 channel selection is done from registers on the VIN master
instances but effect other VIN instances, this is one reason the
rcar-vin driver is so ugly as each VIN instance is not self contained.
While the CSI-2 VC/DT filtering is done in the rcar-csi2 driver.
On Gen4 the capture pipeline is $source -> rcar-csi2 -> rcar-isp ->
rcar-vin. And both the channel selection and VC/DT filtering is done in
the rcar-isp. IMHO this is slightly better design then on Gen3 but
created yet another ugliness in the pipeline as now Gen{1,2}, Gen3 and
Gen4 are all supported by the same set of drivers but the same function
is served by different IP blocks depending on which generation, this
makes for somewhat ugly driver code.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Kind Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-06-04 9:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-27 13:19 [PATCH] dt-bindings: media: renesas,isp: Add binding for V4M Niklas Söderlund
2024-05-27 16:36 ` Conor Dooley
2024-05-27 17:54 ` Niklas Söderlund
2024-05-27 18:07 ` Conor Dooley
2024-06-04 7:38 ` Geert Uytterhoeven
2024-06-04 9:18 ` Niklas Söderlund
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).