From: David Wei <dw@davidwei.uk>
To: Mina Almasry <almasrymina@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org
Cc: "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Donald Hunter" <donald.hunter@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Ivan Kokshaysky" <ink@jurassic.park.msu.ru>,
"Matt Turner" <mattst88@gmail.com>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Helge Deller" <deller@gmx.de>,
"Andreas Larsson" <andreas@gaisler.com>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Song Liu" <song@kernel.org>,
"Yonghong Song" <yonghong.song@linux.dev>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>,
"Stanislav Fomichev" <sdf@google.com>,
"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
"Steffen Klassert" <steffen.klassert@secunet.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"David Ahern" <dsahern@kernel.org>,
"Willem de Bruijn" <willemdebruijn.kernel@gmail.com>,
"Shuah Khan" <shuah@kernel.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Pavel Begunkov" <asml.silence@gmail.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Yunsheng Lin" <linyunsheng@huawei.com>,
"Shailend Chand" <shailend@google.com>,
"Harshitha Ramamurthy" <hramamurthy@google.com>,
"Shakeel Butt" <shakeel.butt@linux.dev>,
"Jeroen de Borst" <jeroendb@google.com>,
"Praveen Kaligineedi" <pkaligineedi@google.com>
Subject: Re: [PATCH net-next v10 01/14] netdev: add netdev_rx_queue_restart()
Date: Thu, 30 May 2024 16:51:41 -0700 [thread overview]
Message-ID: <49e4d52c-59f1-4321-9012-aabb1e8cc005@davidwei.uk> (raw)
In-Reply-To: <20240530201616.1316526-2-almasrymina@google.com>
On 2024-05-30 13:16, Mina Almasry wrote:
[...]
> +err_start_queue:
> + /* Restarting the queue with old_mem should be successful as we haven't
> + * changed any of the queue configuration, and there is not much we can
> + * do to recover from a failure here.
> + *
> + * WARN if the we fail to recover the old rx queue, and at least free
> + * old_mem so we don't also leak that.
> + */
> + if (dev->queue_mgmt_ops->ndo_queue_start(dev, old_mem, rxq_idx)) {
> + WARN(1,
> + "Failed to restart old queue in error path. RX queue %d may be unhealthy.",
> + rxq_idx);
> + dev->queue_mgmt_ops->ndo_queue_mem_free(dev, &old_mem);
This should be ->ndo_queue_mem_free(dev, old_mem).
next prev parent reply other threads:[~2024-05-30 23:51 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 20:15 [PATCH net-next v10 00/14] Device Memory TCP Mina Almasry
2024-05-30 20:16 ` [PATCH net-next v10 01/14] netdev: add netdev_rx_queue_restart() Mina Almasry
2024-05-30 23:51 ` David Wei [this message]
2024-06-03 12:52 ` Pavel Begunkov
2024-05-30 20:16 ` [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers Mina Almasry
2024-06-01 5:35 ` Christoph Hellwig
2024-06-03 14:17 ` Mina Almasry
2024-06-03 14:52 ` Pavel Begunkov
2024-06-03 15:43 ` Mina Almasry
2024-06-07 13:42 ` Pavel Begunkov
2024-06-07 14:27 ` David Ahern
2024-06-07 14:52 ` Jason Gunthorpe
2024-06-10 0:37 ` David Wei
2024-06-10 1:07 ` Pavel Begunkov
2024-06-10 12:16 ` Jason Gunthorpe
2024-06-10 12:38 ` Christian König
2024-06-10 15:41 ` Mina Almasry
2024-06-10 19:32 ` Pavel Begunkov
2024-06-10 16:22 ` Daniel Vetter
2024-06-11 6:25 ` Christoph Hellwig
2024-06-11 8:21 ` Christian König
2024-06-10 15:16 ` David Ahern
2024-06-10 19:20 ` Pavel Begunkov
2024-06-10 22:15 ` Jason Gunthorpe
2024-06-11 18:09 ` Mina Almasry
2024-06-12 12:06 ` Jason Gunthorpe
2024-06-12 15:47 ` David Ahern
2024-06-17 19:15 ` Pavel Begunkov
2024-06-11 6:26 ` Christoph Hellwig
2024-06-11 17:48 ` Mina Almasry
2024-06-07 15:42 ` Pavel Begunkov
2024-06-07 15:46 ` Pavel Begunkov
2024-06-07 16:59 ` Mina Almasry
2024-06-10 1:12 ` Pavel Begunkov
2024-06-10 0:27 ` David Wei
2024-06-05 8:24 ` Christoph Hellwig
2024-06-07 13:45 ` Pavel Begunkov
2024-06-11 6:34 ` Christoph Hellwig
2024-06-17 18:04 ` Pavel Begunkov
2024-06-18 6:43 ` Christoph Hellwig
2024-06-18 11:40 ` Pavel Begunkov
2024-06-05 8:23 ` Christoph Hellwig
2024-05-30 20:16 ` [PATCH net-next v10 03/14] net: netdev netlink api to bind dma-buf to a net device Mina Almasry
2024-05-30 20:16 ` [PATCH net-next v10 04/14] netdev: support binding dma-buf to netdevice Mina Almasry
2024-05-30 20:16 ` [PATCH net-next v10 05/14] netdev: netdevice devmem allocator Mina Almasry
2024-06-04 10:13 ` Paolo Abeni
2024-06-04 16:15 ` Steven Rostedt
2024-06-04 16:31 ` Jason Gunthorpe
2024-06-04 16:42 ` Steven Rostedt
2024-06-04 23:44 ` Andrew Lunn
2024-06-05 0:27 ` Steven Rostedt
2024-06-05 0:52 ` Andrew Lunn
2024-06-06 1:43 ` Steven Rostedt
2024-06-07 7:55 ` Niklas Schnelle
2024-05-30 20:16 ` [PATCH net-next v10 06/14] page_pool: convert to use netmem Mina Almasry
2024-06-04 10:23 ` Paolo Abeni
2024-06-06 1:48 ` Steven Rostedt
2024-06-07 12:31 ` Pavel Begunkov
2024-05-30 20:16 ` [PATCH net-next v10 07/14] page_pool: devmem support Mina Almasry
2024-05-30 20:16 ` [PATCH net-next v10 08/14] memory-provider: dmabuf devmem memory provider Mina Almasry
2024-05-30 20:16 ` [PATCH net-next v10 09/14] net: support non paged skb frags Mina Almasry
2024-05-30 20:16 ` [PATCH net-next v10 10/14] net: add support for skbs with unreadable frags Mina Almasry
2024-06-04 10:46 ` Paolo Abeni
2024-06-06 16:49 ` Mina Almasry
2024-06-06 16:58 ` Mina Almasry
2024-05-30 20:16 ` [PATCH net-next v10 11/14] tcp: RX path for devmem TCP Mina Almasry
2024-06-04 10:53 ` Paolo Abeni
2024-05-30 20:16 ` [PATCH net-next v10 12/14] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags Mina Almasry
2024-05-30 20:16 ` [PATCH net-next v10 13/14] net: add devmem TCP documentation Mina Almasry
2024-06-01 13:09 ` Bagas Sanjaya
2024-05-30 20:16 ` [PATCH net-next v10 14/14] selftests: add ncdevmem, netcat for devmem TCP Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49e4d52c-59f1-4321-9012-aabb1e8cc005@davidwei.uk \
--to=dw@davidwei.uk \
--cc=James.Bottomley@HansenPartnership.com \
--cc=almasrymina@google.com \
--cc=andreas@gaisler.com \
--cc=andrii@kernel.org \
--cc=arnd@arndb.de \
--cc=asml.silence@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=christian.koenig@amd.com \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=donald.hunter@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsahern@kernel.org \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=hramamurthy@google.com \
--cc=ilias.apalodimas@linaro.org \
--cc=ink@jurassic.park.msu.ru \
--cc=jeroendb@google.com \
--cc=jgg@ziepe.ca \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=martin.lau@linux.dev \
--cc=mathieu.desnoyers@efficios.com \
--cc=mattst88@gmail.com \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=richard.henderson@linaro.org \
--cc=rostedt@goodmis.org \
--cc=sdf@google.com \
--cc=shailend@google.com \
--cc=shakeel.butt@linux.dev \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=sumit.semwal@linaro.org \
--cc=tsbogend@alpha.franken.de \
--cc=willemdebruijn.kernel@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).