From: Sebastian Wick <sebastian.wick@redhat.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 1/3] edid-decode: build: compile with -Wno-variadic-macros
Date: Thu, 6 Jun 2024 11:42:11 +0200 [thread overview]
Message-ID: <CA+hFU4xFJErt99NUFr4bW2jhT2pU14SUa06heKy_s5qTzhUthw@mail.gmail.com> (raw)
In-Reply-To: <46bd56ac-e29b-4534-8bf9-90a5196170b4@xs4all.nl>
When building as a subproject, I get warnings:
../subprojects/edid-decode/edid-decode.h:516:23: warning: ISO C++ does
not permit named variadic macros [-Wvariadic-macros]
516 | #define warn(fmt, args...) msg(true, fmt, ##args)
I cannot tell you why this happens though. I tried to reproduce this
without a subproject by passing different compiler options and trying
different standard versions but did not manage. So, I'm not sure why
this is needed other than silencing annoying warnings in
libdisplay-info.
On Thu, Jun 6, 2024 at 8:02 AM Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote:
>
> On 05/06/2024 13:09, Sebastian Wick wrote:
> > Signed-off-by: Sebastian Wick <sebastian.wick@redhat.com>
> > ---
> > meson.build | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git ./meson.build ../meson.build
> > index ca57652..80f810f 100644
> > --- ./meson.build
> > +++ ../meson.build
> > @@ -7,6 +7,7 @@ edid_decode_args = [
> > '-Wno-missing-field-initializers',
> > '-Wno-unused-parameter',
> > '-Wimplicit-fallthrough',
> > + '-Wno-variadic-macros',
> > ]
> > edid_decode_link_args = []
> >
>
> Can you provide a proper commit log? E.g. why is this needed?
>
> Regards,
>
> Hans
>
prev parent reply other threads:[~2024-06-06 9:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 11:09 [PATCH 1/3] edid-decode: build: compile with -Wno-variadic-macros Sebastian Wick
2024-06-05 11:09 ` [PATCH 2/3] edid-decode: build: Move sources to its own variable and fix formatting Sebastian Wick
2024-06-05 11:09 ` [PATCH 3/3] edid-decode: build: Use override_find_program to help subproject usage Sebastian Wick
2024-06-06 5:51 ` [PATCH 1/3] edid-decode: build: compile with -Wno-variadic-macros Hans Verkuil
2024-06-06 9:42 ` Sebastian Wick [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+hFU4xFJErt99NUFr4bW2jhT2pU14SUa06heKy_s5qTzhUthw@mail.gmail.com \
--to=sebastian.wick@redhat.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).