From: Andy Shevchenko <andy@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Tsuchiya Yuto <kitakar@gmail.com>,
Yury Luneff <yury.lunev@gmail.com>,
Nable <nable.maininbox@googlemail.com>,
andrey.i.trufanov@gmail.com, Fabio Aiuto <fabioaiuto83@gmail.com>,
Kate Hsuan <hpa@redhat.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH 1/5] media: atomisp: Remove unused mipicsi_flag module parameter
Date: Mon, 3 Jun 2024 22:38:33 +0300 [thread overview]
Message-ID: <Zl4buULQdXlDzRku@smile.fi.intel.com> (raw)
In-Reply-To: <20240603132057.255917-1-hdegoede@redhat.com>
On Mon, Jun 03, 2024 at 03:20:53PM +0200, Hans de Goede wrote:
> The mipicsi_flag int is completely unused, remove it.
Reviewed-by: Andy Shevchenko <andy@kernel.org>
(One nit in patch 3, though. I think it's worth to address)
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-06-03 19:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 13:20 [PATCH 1/5] media: atomisp: Remove unused mipicsi_flag module parameter Hans de Goede
2024-06-03 13:20 ` [PATCH 2/5] media: atomisp: Remove firmware_name " Hans de Goede
2024-06-03 13:20 ` [PATCH 3/5] media: atomisp: Prefix firmware paths with "intel/ipu/" Hans de Goede
2024-06-03 19:36 ` Andy Shevchenko
2024-06-03 13:20 ` [PATCH 4/5] media: atomisp: Update TODO Hans de Goede
2024-06-03 13:20 ` [PATCH 5/5] media: atomisp: csi2-bridge: Add DMI quirk for OV5693 on Xiaomi Mipad2 Hans de Goede
2024-06-03 19:38 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zl4buULQdXlDzRku@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=andrey.i.trufanov@gmail.com \
--cc=fabioaiuto83@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=kitakar@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=nable.maininbox@googlemail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=yury.lunev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).