From: Carlos Llamas <cmllamas@google.com>
To: Barry Song <21cnbao@gmail.com>
Cc: linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org,
sumit.semwal@linaro.org, Brian.Starkey@arm.com,
benjamin.gaignard@collabora.com, christian.koenig@amd.com,
dri-devel@lists.freedesktop.org, jstultz@google.com,
linux-kernel@vger.kernel.org, tjmercier@google.com,
v-songbaohua@oppo.com, hailong.liu@oppo.com
Subject: Re: [PATCH] dma-buf/heaps: Correct the types of fd_flags and heap_flags
Date: Mon, 10 Jun 2024 16:43:59 +0000 [thread overview]
Message-ID: <ZmctTwAuzkObaXLi@google.com> (raw)
In-Reply-To: <20240606020213.49854-1-21cnbao@gmail.com>
On Thu, Jun 06, 2024 at 02:02:13PM +1200, Barry Song wrote:
> From: Barry Song <v-songbaohua@oppo.com>
>
> dma_heap_allocation_data defines the UAPI as follows:
>
> struct dma_heap_allocation_data {
> __u64 len;
> __u32 fd;
> __u32 fd_flags;
> __u64 heap_flags;
> };
>
> But dma heaps are casting both fd_flags and heap_flags into
> unsigned long. This patch makes dma heaps - cma heap and
> system heap have consistent types with UAPI.
>
> Signed-off-by: Barry Song <v-songbaohua@oppo.com>
> ---
Looks good to me, thanks!
Reviewed-by: Carlos Llamas <cmllamas@google.com>
next prev parent reply other threads:[~2024-06-10 16:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 2:02 [PATCH] dma-buf/heaps: Correct the types of fd_flags and heap_flags Barry Song
2024-06-06 2:37 ` John Stultz
2024-06-10 16:43 ` Carlos Llamas [this message]
2024-06-19 14:37 ` Sumit Semwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmctTwAuzkObaXLi@google.com \
--to=cmllamas@google.com \
--cc=21cnbao@gmail.com \
--cc=Brian.Starkey@arm.com \
--cc=benjamin.gaignard@collabora.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hailong.liu@oppo.com \
--cc=jstultz@google.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=tjmercier@google.com \
--cc=v-songbaohua@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).