From: Krzysztof Kozlowski <krzk@kernel.org>
To: Benjamin Mugnier <benjamin.mugnier@foss.st.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sylvain Petinot <sylvain.petinot@foss.st.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] media: vgxy61: Add legacy compatible string
Date: Tue, 11 Jun 2024 22:54:35 +0200 [thread overview]
Message-ID: <bd2aa638-e30c-4011-925b-4d922fe28f61@kernel.org> (raw)
In-Reply-To: <11cb5143-3c0e-4e7d-bcdb-6e8371bb1c0c@foss.st.com>
On 11/06/2024 15:07, Benjamin Mugnier wrote:
>
>>>
>>> Will this be ok for you ? Tell me your thoughts.
>>
>> It seems you are making some changes assuming there is some error to be
>> fixed, but there is none. Compatible is just some unique string, so the
>> original compatible, although unfortunate, is okay and must not be
>> changed. I already explained that adding new compatibles for such cases
>> is only for exceptions. Is this exception? No. You provided no rationale
>> to make it an exception.
>
> Thank you. I think I failed to provide some details :
>
> The change is motivated by a will of consistency in naming.
Consistency is a preference and not really a reason here. Could be named
"st,yellow-elephant" and it would be kind of fine...
> As you correctly mentioned in the vd56g3 series [1], bindings should be
> 'vendor,device'. This will be changed for the vd56g3 series v3 by
Yeah, but that ship has sailed. Where is the answer about all the users?
You pick pieces of my arguments and ignore some parts of it.
None of this is suitable for exception. Style or preference is not
argument for exception.
> Sylvain, but the vgxy61 binding is already badly named.
> We will then have these 2 bindings in the wild : st,vd56g3 and
> st,st-vgxy61, for very similar sensors. Hence the will to add a
> st,vgxy61 binding for consistency.
Nope.
> This also prepares the ground for new camera sensor drivers we plan to
> submit later on, and that will respect the st,device binding naming scheme.
Nope
>
> Is it the correct way to go ?
Nope, sorry.
I already said this several times in this email thread - answers here
and in other emails. Now, again.
When I said about exceptions, I really meant exceptions, e.g. something
is broken or something never worked and has to be fixed. Style or
preference is not this case. No point to keep arguing how style is
important for you.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-11 20:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 15:08 [PATCH 0/3] media: vgxy61: Remove vendor prefix from driver name Benjamin Mugnier
2024-06-10 15:08 ` [PATCH 1/3] media: vgxy61: Fix " Benjamin Mugnier
2024-06-11 6:47 ` Krzysztof Kozlowski
2024-06-10 15:08 ` [PATCH 2/3] media: vgxy61: Add legacy compatible string Benjamin Mugnier
2024-06-11 6:47 ` Krzysztof Kozlowski
2024-06-11 8:19 ` Sakari Ailus
2024-06-11 8:38 ` Krzysztof Kozlowski
2024-06-11 11:57 ` Benjamin Mugnier
2024-06-11 12:17 ` Krzysztof Kozlowski
2024-06-11 13:07 ` Benjamin Mugnier
2024-06-11 20:54 ` Krzysztof Kozlowski [this message]
2024-06-10 15:08 ` [PATCH 3/3] media: vgxy61: Add MODULE_ALIAS() Benjamin Mugnier
2024-06-11 6:48 ` Krzysztof Kozlowski
2024-06-11 8:21 ` Sakari Ailus
2024-06-11 11:57 ` Benjamin Mugnier
2024-06-11 13:11 ` Sakari Ailus
2024-06-11 13:13 ` Benjamin Mugnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd2aa638-e30c-4011-925b-4d922fe28f61@kernel.org \
--to=krzk@kernel.org \
--cc=benjamin.mugnier@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sylvain.petinot@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).