* [PATCH v1] scsi: ufs: exynos: Support module autoloading
@ 2024-04-09 20:22 Will McVicker
2024-04-09 20:32 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Will McVicker @ 2024-04-09 20:22 UTC (permalink / raw
To: Alim Akhtar, James E.J. Bottomley, Martin K. Petersen,
Krzysztof Kozlowski
Cc: Peter Griffin, andre.draszik, tudor.ambarus, Will McVicker,
kernel-team, linux-scsi, linux-arm-kernel, linux-samsung-soc,
linux-kernel
Export the module alias information using the MODULE_DEVICE_TABLE()
macro in order to support auto-loading this module for devices that
support it.
$ modinfo -F alias out/linux/drivers/ufs/host/ufs-exynos.ko
of:N*T*Ctesla,fsd-ufsC*
of:N*T*Ctesla,fsd-ufs
of:N*T*Csamsung,exynosautov9-ufs-vhC*
of:N*T*Csamsung,exynosautov9-ufs-vh
of:N*T*Csamsung,exynosautov9-ufsC*
of:N*T*Csamsung,exynosautov9-ufs
of:N*T*Csamsung,exynos7-ufsC*
of:N*T*Csamsung,exynos7-ufs
Signed-off-by: Will McVicker <willmcvicker@google.com>
---
drivers/ufs/host/ufs-exynos.c | 1 +
1 file changed, 1 insertion(+)
Note, I tested this on a Pixel 6 device with the UFS patch series in
[1]. With both this patch and [1], the ufs-exynos module autoloads on
boot.
[1] https://lore.kernel.org/all/20240404122559.898930-1-peter.griffin@linaro.org/
diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c
index 734d40f99e31..1795860a2f06 100644
--- a/drivers/ufs/host/ufs-exynos.c
+++ b/drivers/ufs/host/ufs-exynos.c
@@ -1748,6 +1748,7 @@ static const struct of_device_id exynos_ufs_of_match[] = {
.data = &fsd_ufs_drvs },
{},
};
+MODULE_DEVICE_TABLE(of, exynos_ufs_of_match);
static const struct dev_pm_ops exynos_ufs_pm_ops = {
SET_SYSTEM_SLEEP_PM_OPS(ufshcd_system_suspend, ufshcd_system_resume)
base-commit: 2c71fdf02a95b3dd425b42f28fd47fb2b1d22702
--
2.44.0.683.g7961c838ac-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1] scsi: ufs: exynos: Support module autoloading
2024-04-09 20:22 [PATCH v1] scsi: ufs: exynos: Support module autoloading Will McVicker
@ 2024-04-09 20:32 ` Krzysztof Kozlowski
2024-04-09 20:41 ` William McVicker
2024-04-12 1:56 ` Martin K. Petersen
2024-04-25 1:57 ` Martin K. Petersen
2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-09 20:32 UTC (permalink / raw
To: Will McVicker, Alim Akhtar, James E.J. Bottomley,
Martin K. Petersen
Cc: Peter Griffin, andre.draszik, tudor.ambarus, kernel-team,
linux-scsi, linux-arm-kernel, linux-samsung-soc, linux-kernel
On 09/04/2024 22:22, Will McVicker wrote:
> Export the module alias information using the MODULE_DEVICE_TABLE()
> macro in order to support auto-loading this module for devices that
> support it.
>
> $ modinfo -F alias out/linux/drivers/ufs/host/ufs-exynos.ko
> of:N*T*Ctesla,fsd-ufsC*
> of:N*T*Ctesla,fsd-ufs
> of:N*T*Csamsung,exynosautov9-ufs-vhC*
> of:N*T*Csamsung,exynosautov9-ufs-vh
> of:N*T*Csamsung,exynosautov9-ufsC*
> of:N*T*Csamsung,exynosautov9-ufs
> of:N*T*Csamsung,exynos7-ufsC*
> of:N*T*Csamsung,exynos7-ufs
That part is redundant, you just copied result of of_device_id. No need
to resend just for this.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] scsi: ufs: exynos: Support module autoloading
2024-04-09 20:32 ` Krzysztof Kozlowski
@ 2024-04-09 20:41 ` William McVicker
0 siblings, 0 replies; 5+ messages in thread
From: William McVicker @ 2024-04-09 20:41 UTC (permalink / raw
To: Krzysztof Kozlowski
Cc: Alim Akhtar, James E.J. Bottomley, Martin K. Petersen,
Peter Griffin, andre.draszik, tudor.ambarus, kernel-team,
linux-scsi, linux-arm-kernel, linux-samsung-soc, linux-kernel
On 04/09/2024, Krzysztof Kozlowski wrote:
> On 09/04/2024 22:22, Will McVicker wrote:
> > Export the module alias information using the MODULE_DEVICE_TABLE()
> > macro in order to support auto-loading this module for devices that
> > support it.
> >
> > $ modinfo -F alias out/linux/drivers/ufs/host/ufs-exynos.ko
> > of:N*T*Ctesla,fsd-ufsC*
> > of:N*T*Ctesla,fsd-ufs
> > of:N*T*Csamsung,exynosautov9-ufs-vhC*
> > of:N*T*Csamsung,exynosautov9-ufs-vh
> > of:N*T*Csamsung,exynosautov9-ufsC*
> > of:N*T*Csamsung,exynosautov9-ufs
> > of:N*T*Csamsung,exynos7-ufsC*
> > of:N*T*Csamsung,exynos7-ufs
>
> That part is redundant, you just copied result of of_device_id. No need
> to resend just for this.
Well the point of including this snippet is to show that it's working.
Without this patch, `modinfo -F alias ufs-exynos.ko` doesn't return
anything. I'm fine with not including it either way though.
Thanks,
Will
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] scsi: ufs: exynos: Support module autoloading
2024-04-09 20:22 [PATCH v1] scsi: ufs: exynos: Support module autoloading Will McVicker
2024-04-09 20:32 ` Krzysztof Kozlowski
@ 2024-04-12 1:56 ` Martin K. Petersen
2024-04-25 1:57 ` Martin K. Petersen
2 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2024-04-12 1:56 UTC (permalink / raw
To: Will McVicker
Cc: Alim Akhtar, James E.J. Bottomley, Martin K. Petersen,
Krzysztof Kozlowski, Peter Griffin, andre.draszik, tudor.ambarus,
kernel-team, linux-scsi, linux-arm-kernel, linux-samsung-soc,
linux-kernel
Will,
> Export the module alias information using the MODULE_DEVICE_TABLE()
> macro in order to support auto-loading this module for devices that
> support it.
Applied to 6.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] scsi: ufs: exynos: Support module autoloading
2024-04-09 20:22 [PATCH v1] scsi: ufs: exynos: Support module autoloading Will McVicker
2024-04-09 20:32 ` Krzysztof Kozlowski
2024-04-12 1:56 ` Martin K. Petersen
@ 2024-04-25 1:57 ` Martin K. Petersen
2 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2024-04-25 1:57 UTC (permalink / raw
To: Alim Akhtar, James E.J. Bottomley, Krzysztof Kozlowski,
Will McVicker
Cc: Martin K . Petersen, Peter Griffin, andre.draszik, tudor.ambarus,
kernel-team, linux-scsi, linux-arm-kernel, linux-samsung-soc,
linux-kernel
On Tue, 09 Apr 2024 13:22:02 -0700, Will McVicker wrote:
> Export the module alias information using the MODULE_DEVICE_TABLE()
> macro in order to support auto-loading this module for devices that
> support it.
>
> $ modinfo -F alias out/linux/drivers/ufs/host/ufs-exynos.ko
> of:N*T*Ctesla,fsd-ufsC*
> of:N*T*Ctesla,fsd-ufs
> of:N*T*Csamsung,exynosautov9-ufs-vhC*
> of:N*T*Csamsung,exynosautov9-ufs-vh
> of:N*T*Csamsung,exynosautov9-ufsC*
> of:N*T*Csamsung,exynosautov9-ufs
> of:N*T*Csamsung,exynos7-ufsC*
> of:N*T*Csamsung,exynos7-ufs
>
> [...]
Applied to 6.10/scsi-queue, thanks!
[1/1] scsi: ufs: exynos: Support module autoloading
https://git.kernel.org/mkp/scsi/c/2810702f2cbc
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-04-25 1:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-09 20:22 [PATCH v1] scsi: ufs: exynos: Support module autoloading Will McVicker
2024-04-09 20:32 ` Krzysztof Kozlowski
2024-04-09 20:41 ` William McVicker
2024-04-12 1:56 ` Martin K. Petersen
2024-04-25 1:57 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).