LKML Archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] Additional devices added to cp210x usb-to-serial driver in kernel 3.16
       [not found] <641A0889272F104D8B07278675C0C484010B1A94@hq27>
@ 2015-01-02 13:50 ` Johan Hovold
  0 siblings, 0 replies; only message in thread
From: Johan Hovold @ 2015-01-02 13:50 UTC (permalink / raw
  To: Peterson, David; +Cc: johan@kernel.org, linux-kernel@vger.kernel.org

On Mon, Dec 29, 2014 at 10:49:34PM +0000, Peterson, David wrote:
> commit 975ae8b32bc5f52a5456e42c3c3310937c6fe833
> Author: David Peterson <david.peterson@cel.com>
> Date:   Mon Dec 29 15:59:37 2014 -0600

The above does not belong in the commit message (i.e. mail body).
Please read Documentation/SubmittingPatches, and consider using "git
format-patch" (and "git send-email").

> Added virtual com port VID/PID entries for CEL USB sticks and MeshWorks devices
> Signed-off-by: David Peterson <david.peterson@cel.com>

Also run scripts/checkpatch.pl on your patch before submitting, it would
have let you now that there are whitespace issues below.

Care to fix this up and resend?

Thanks,
Johan

> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index 6c4eb3c..a6db2fc 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -120,6 +120,9 @@ static const struct usb_device_id id_table[] = {
>                { USB_DEVICE(0x10C4, 0x85F8) }, /* Virtenio Preon32 */
>                { USB_DEVICE(0x10C4, 0x8664) }, /* AC-Services CAN-IF */
>                { USB_DEVICE(0x10C4, 0x8665) }, /* AC-Services OBD-IF */
> +             { USB_DEVICE(0x10C4, 0x8856) }, /* CEL EM357 ZigBee USB Stick - LR */
> +             { USB_DEVICE(0x10C4, 0x8857) }, /* CEL EM357 ZigBee USB Stick */
> +             { USB_DEVICE(0x10C4, 0x8977) }, /* CEL MeshWorks DevKit Device */
>                { USB_DEVICE(0x10C4, 0x8875) }, /* CEL MeshConnect USB Stick */
>                { USB_DEVICE(0x10C4, 0x88A4) }, /* MMB Networks ZigBee USB Device */
>                { USB_DEVICE(0x10C4, 0x88A5) }, /* Planet Innovation Ingeni ZigBee USB Device */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-01-02 13:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <641A0889272F104D8B07278675C0C484010B1A94@hq27>
2015-01-02 13:50 ` [PATCH] Additional devices added to cp210x usb-to-serial driver in kernel 3.16 Johan Hovold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).