From: Gjorgji Rosikopulos <quic_grosikop@quicinc.com>
To: <rfoss@kernel.org>, <todor.too@gmail.com>,
<bryan.odonoghue@linaro.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <mchehab@kernel.org>
Cc: <linux-media@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<laurent.pinchart@ideasonboard.com>, <hverkuil-cisco@xs4all.nl>,
<quic_hariramp@quicinc.com>
Subject: [PATCH v3 0/8] Move camss version related defs in to resources
Date: Thu, 11 Apr 2024 15:45:35 +0300 [thread overview]
Message-ID: <20240411124543.199-1-quic_grosikop@quicinc.com> (raw)
The different resources required for different camss soc versions are
split in to two groups:
1. Camss device related. In this group are all resources described
in the device tree, clocks, regulators etc.
2. Sub-device specific resources. In the initialization
of the each sub-device, the version of camss is passed.
Based on this version the sub-device adds: hw layer support,
per pad formats, number of dma's etc.
The code for "1" group lives in camss.c. However the "2" group
is spread across all sub-device implementations including video device.
This kind of separation is not very convenient when adding new camss soc
version. The reason is that you need to add support in all sub-device
implementations.
There were some improvements in this direction where some of the
hw version related definitions were moved in to the "1". One
example is attaching of the hw operations.
This series aim to improve the things more and add additional definitions
in to the "1".
What is included:
- Remove all format definitions from camss video. The will be passed
by the parent sub-device
- Make camss generic format definition mapping, containing mbus to
v4l2 mapping, mbus bpp and other required fields used by the
sub-device and video node.
- Add per sub-device type union in the resources, different
sub-devices are using different resources, as an example: is_lite flag.
- Move camss link operation in to the resources. Currently one
function supports different topologies depending of the number
of devices. As hw version support increases this is not good
way of supporting different topologies.
- Add parent device ops in to the resources. This resolves
inter-dependencies of vfe and csid. Csid requests the clocks
regulators etc from parent device instead calling directly vfe
functions.
- Some cleanups in csid code for split the configuration of
RX and testgen and RDI.
Changes in V3:
- Incorporate missing changes in resources reported and fixed by
Bryan O'Donoghue <bryan.odonoghue@linaro.org> taken from the branch:
https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/sc8280xp-6.9-rc1-camss-resource-change-verification?ref_type=heads
- Added missing signed-off to the changes submitted by me.
Changes in V2:
- Rebased on top of sc8280xp v6.
- The change "Designate lite subdevices in resources" was dropped,
it was already merged in previous series.
Atanas Filipov (1):
media: qcom: camss: Decompose register and link operations
Milen Mitkov (2):
media: qcom: camss: Split testgen, RDI and RX for CSID 170
media: qcom: camss: Decouple VFE from CSID
Radoslav Tsvetkov (5):
media: qcom: camss: Add per sub-device type resources
media: qcom: camss: Attach formats to VFE resources
media: qcom: camss: Attach formats to CSID resources
media: qcom: camss: Attach formats to CSIPHY resources
media: qcom: camss: Move format related functions
drivers/media/platform/qcom/camss/Makefile | 1 +
.../platform/qcom/camss/camss-csid-4-1.c | 132 +---
.../platform/qcom/camss/camss-csid-4-7.c | 160 +---
.../platform/qcom/camss/camss-csid-gen2.c | 410 ++++------
.../media/platform/qcom/camss/camss-csid.c | 512 +++++++++++-
.../media/platform/qcom/camss/camss-csid.h | 32 +-
.../media/platform/qcom/camss/camss-csiphy.c | 74 +-
.../media/platform/qcom/camss/camss-csiphy.h | 23 +-
.../media/platform/qcom/camss/camss-format.c | 98 +++
.../media/platform/qcom/camss/camss-format.h | 67 ++
.../media/platform/qcom/camss/camss-vfe-17x.c | 10 +-
.../media/platform/qcom/camss/camss-vfe-4-1.c | 4 +-
.../media/platform/qcom/camss/camss-vfe-4-7.c | 6 +-
.../media/platform/qcom/camss/camss-vfe-4-8.c | 6 +-
.../platform/qcom/camss/camss-vfe-gen1.c | 8 +-
drivers/media/platform/qcom/camss/camss-vfe.c | 483 +++++++-----
drivers/media/platform/qcom/camss/camss-vfe.h | 22 +-
.../media/platform/qcom/camss/camss-video.c | 295 +------
.../media/platform/qcom/camss/camss-video.h | 5 +-
drivers/media/platform/qcom/camss/camss.c | 729 +++++++++++++-----
drivers/media/platform/qcom/camss/camss.h | 28 +-
21 files changed, 1767 insertions(+), 1338 deletions(-)
create mode 100644 drivers/media/platform/qcom/camss/camss-format.c
create mode 100644 drivers/media/platform/qcom/camss/camss-format.h
--
2.17.1
next reply other threads:[~2024-04-11 12:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 12:45 Gjorgji Rosikopulos [this message]
2024-04-11 12:45 ` [PATCH v3 1/8] media: qcom: camss: Add per sub-device type resources Gjorgji Rosikopulos
2024-05-10 18:26 ` Bryan O'Donoghue
2024-05-10 22:18 ` Bryan O'Donoghue
2024-05-13 9:55 ` Gjorgji Rosikopulos (Consultant)
2024-05-10 23:09 ` [PATCH v3.1] " Bryan O'Donoghue
2024-04-11 12:45 ` [PATCH v3 2/8] media: qcom: camss: Attach formats to VFE resources Gjorgji Rosikopulos
2024-05-10 18:27 ` Bryan O'Donoghue
2024-05-13 15:15 ` Vladimir Zapolskiy
2024-05-13 15:35 ` Gjorgji Rosikopulos (Consultant)
2024-05-13 17:36 ` Bryan O'Donoghue
2024-05-14 8:39 ` Gjorgji Rosikopulos (Consultant)
2024-04-11 12:45 ` [PATCH v3 3/8] media: qcom: camss: Attach formats to CSID resources Gjorgji Rosikopulos
2024-05-10 18:27 ` Bryan O'Donoghue
2024-04-11 12:45 ` [PATCH v3 4/8] media: qcom: camss: Attach formats to CSIPHY resources Gjorgji Rosikopulos
2024-05-10 18:28 ` Bryan O'Donoghue
2024-04-11 12:45 ` [PATCH v3 5/8] media: qcom: camss: Move format related functions Gjorgji Rosikopulos
2024-05-10 18:28 ` Bryan O'Donoghue
2024-05-13 15:39 ` Vladimir Zapolskiy
2024-05-13 16:52 ` Gjorgji Rosikopulos (Consultant)
2024-05-13 17:43 ` Bryan O'Donoghue
2024-04-11 12:45 ` [PATCH v3 6/8] media: qcom: camss: Split testgen, RDI and RX for CSID 170 Gjorgji Rosikopulos
2024-05-10 18:28 ` Bryan O'Donoghue
2024-04-11 12:45 ` [PATCH v3 7/8] media: qcom: camss: Decompose register and link operations Gjorgji Rosikopulos
2024-05-10 18:29 ` Bryan O'Donoghue
2024-04-11 12:45 ` [PATCH v3 8/8] media: qcom: camss: Decouple VFE from CSID Gjorgji Rosikopulos
2024-05-10 18:29 ` Bryan O'Donoghue
2024-05-13 15:58 ` Vladimir Zapolskiy
2024-05-13 16:26 ` Gjorgji Rosikopulos (Consultant)
2024-05-13 17:48 ` Bryan O'Donoghue
2024-05-10 18:33 ` [PATCH v3 0/8] Move camss version related defs in to resources Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240411124543.199-1-quic_grosikop@quicinc.com \
--to=quic_grosikop@quicinc.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=konrad.dybcio@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_hariramp@quicinc.com \
--cc=rfoss@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).