* [PATCH] ASoC: dt-bindings: ssm2305: convert to dt schema
@ 2024-05-11 21:47 Xiaxi Shen
2024-05-21 9:04 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Xiaxi Shen @ 2024-05-11 21:47 UTC (permalink / raw
To: devicetree, linux-kernel, linux-sound
Cc: shenxiaxi26, lgirdwood, broonie, robh, krzk+dt, conor+dt,
javier.carrasco.cruz, skhan
Convert adi,ssm2305 binding to DT schema
It passed dt_binding_check and dtbs_check. Let me know
if you think it should include something else
Signed-off-by: Xiaxi Shen <shenxiaxi26@gmail.com>
---
.../devicetree/bindings/sound/adi,ssm2305.txt | 14 --------
.../bindings/sound/adi,ssm2305.yaml | 35 +++++++++++++++++++
2 files changed, 35 insertions(+), 14 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.txt
create mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.yaml
diff --git a/Documentation/devicetree/bindings/sound/adi,ssm2305.txt b/Documentation/devicetree/bindings/sound/adi,ssm2305.txt
deleted file mode 100644
index a9c9d83c8a30..000000000000
--- a/Documentation/devicetree/bindings/sound/adi,ssm2305.txt
+++ /dev/null
@@ -1,14 +0,0 @@
-Analog Devices SSM2305 Speaker Amplifier
-========================================
-
-Required properties:
- - compatible : "adi,ssm2305"
- - shutdown-gpios : The gpio connected to the shutdown pin.
- The gpio signal is ACTIVE_LOW.
-
-Example:
-
-ssm2305: analog-amplifier {
- compatible = "adi,ssm2305";
- shutdown-gpios = <&gpio3 20 GPIO_ACTIVE_LOW>;
-};
diff --git a/Documentation/devicetree/bindings/sound/adi,ssm2305.yaml b/Documentation/devicetree/bindings/sound/adi,ssm2305.yaml
new file mode 100644
index 000000000000..8335d763bcd5
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/adi,ssm2305.yaml
@@ -0,0 +1,35 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/adi,ssm2305.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices SSM2305 Speaker Amplifier
+
+maintainers:
+ - Liam Girdwood <lgirdwood@gmail.com>
+ - Mark Brown <broonie@kernel.org>
+ - Rob Herring <robh@kernel.org>
+ - Krzysztof Kozlowski <krzk+dt@kernel.org>
+ - Conor Dooley <conor+dt@kernel.org>
+
+properties:
+ compatible:
+ const: adi,ssm2305
+
+ shutdown-gpios:
+ maxItems: 1
+ description: The gpio connected to the shutdown pin. The gpio signal is ACTIVE_LOW.
+
+required:
+ - compatible
+ - shutdown-gpios
+
+additionalProperties: false
+
+examples:
+ - |
+ analog-amplifier {
+ compatible = "adi,ssm2305";
+ shutdown-gpios = <&gpio3 20 0>;
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: dt-bindings: ssm2305: convert to dt schema
2024-05-11 21:47 [PATCH] ASoC: dt-bindings: ssm2305: convert to dt schema Xiaxi Shen
@ 2024-05-21 9:04 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2024-05-21 9:04 UTC (permalink / raw
To: Xiaxi Shen, devicetree, linux-kernel, linux-sound,
javier.carrasco.cruz, skhan
Cc: lgirdwood, broonie, robh, krzk+dt, conor+dt
On 11/05/2024 23:47, Xiaxi Shen wrote:
> Convert adi,ssm2305 binding to DT schema
>
> It passed dt_binding_check and dtbs_check. Let me know
> if you think it should include something else
That's not really related to the commit.
>
> Signed-off-by: Xiaxi Shen <shenxiaxi26@gmail.com>
> ---
> .../devicetree/bindings/sound/adi,ssm2305.txt | 14 --------
> .../bindings/sound/adi,ssm2305.yaml | 35 +++++++++++++++++++
Same comment as usual... there are no DTS users. Are we done with arm64
defconfig and arm multi_v7 undocumented compatibles? I doubt, 2 months
ago there were hundreds of them. Why touching something without users?
I was speaking about this *multiple times*. Can you update your GSoC or
mentorship guidelines to include this information?
> 2 files changed, 35 insertions(+), 14 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.txt
> create mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.yaml
>
...
> +maintainers:
> + - Liam Girdwood <lgirdwood@gmail.com>
> + - Mark Brown <broonie@kernel.org>
> + - Rob Herring <robh@kernel.org>
> + - Krzysztof Kozlowski <krzk+dt@kernel.org>
> + - Conor Dooley <conor+dt@kernel.org>
Not really, this should be someone responsible for the device. No
maintainers or recent, main contributors?
> +
> +properties:
> + compatible:
> + const: adi,ssm2305
> +
> + shutdown-gpios:
> + maxItems: 1
> + description: The gpio connected to the shutdown pin. The gpio signal is ACTIVE_LOW.
> +
> +required:
> + - compatible
> + - shutdown-gpios> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + analog-amplifier {
> + compatible = "adi,ssm2305";
> + shutdown-gpios = <&gpio3 20 0>;
Use proper define for the flag.
> + };
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-21 9:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-11 21:47 [PATCH] ASoC: dt-bindings: ssm2305: convert to dt schema Xiaxi Shen
2024-05-21 9:04 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).