From: Guenter Roeck <linux@roeck-us.net>
To: Andy Shevchenko <andy.shevchenko@gmail.com>, Armin Wolf <W_Armin@gmx.de>
Cc: mlj@danelec.com, rafael.j.wysocki@intel.com, lenb@kernel.org,
jdelvare@suse.com, linux@weissschuh.net,
ilpo.jarvinen@linux.intel.com, linux-acpi@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v7] ACPI: fan: Add hwmon support
Date: Sun, 12 May 2024 08:20:01 -0700 [thread overview]
Message-ID: <9f6ed1f0-3615-43ce-8d0a-23d1f6a23669@roeck-us.net> (raw)
In-Reply-To: <CAHp75Vd9JZxuDGYm2drSYun+h2CAU+Lb4BEFq3LnQYBKpOfyMA@mail.gmail.com>
On 5/10/24 06:30, Andy Shevchenko wrote:
> On Fri, May 10, 2024 at 1:19 AM Armin Wolf <W_Armin@gmx.de> wrote:
>>
>> Currently, the driver does only support a custom sysfs
>> interface to allow userspace to read the fan speed.
>> Add support for the standard hwmon interface so users
>> can read the fan speed with standard tools like "sensors".
>
>> Tested with a custom ACPI SSDT.
>
> This most likely fits the comment/changelog area and not the commit
> message. Also would be good to put there the link to this custom SSDT
> (like one of zillion of pastebin sites, or GitHub, or ...).
>
> I was under the impression that Guenter gave a tag, which is missing,
> but no, he just said it's okay to go. Guenter, maybe a formal
> Acked-by?
>
I said
It all seems odd, and I returning -ENODATA doesn't seem right,
but then I don't understand the specification or the logic behind it, and
I don't have the time to read and understand it. No objection from my side
against moving forward.
This isn't sufficient for anything formal. Just go ahead.
Thanks,
Guenter
prev parent reply other threads:[~2024-05-12 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 22:19 [PATCH v7] ACPI: fan: Add hwmon support Armin Wolf
2024-05-10 13:30 ` Andy Shevchenko
2024-05-12 15:20 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f6ed1f0-3615-43ce-8d0a-23d1f6a23669@roeck-us.net \
--to=linux@roeck-us.net \
--cc=W_Armin@gmx.de \
--cc=andy.shevchenko@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mlj@danelec.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).