LKML Archive mirror
 help / color / mirror / Atom feed
From: Stephen Langstaff <stephenlangstaff1@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	linux-kernel@vger.kernel.org, OlteanV@gmail.com
Subject: Re: drivers/net/dsa/dsa_loop_bdinfo.c build problems
Date: Wed, 15 May 2024 10:23:02 +0100	[thread overview]
Message-ID: <CAHx5RXC44V-qsN9QiuhKrDdGZ4ppXpT_cQz3XNAa2aQnf7Pe5Q@mail.gmail.com> (raw)
In-Reply-To: <949fcbea-23dc-44c1-9146-c358b15b9253@lunn.ch>

On Tue, May 14, 2024 at 5:17 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Tue, May 14, 2024 at 05:08:24PM +0100, Stephen Langstaff wrote:
> > If I sorted out building the dsa_loop_bdinfo.c code as a built-in do
> > you think that would solve the ordering issue?
>
> Probably.

Well, some minor progress... when dsa_loop and dsa_loop_bdinfo are
built-in to the kernel then it appears that, at least for this
configuration, the driver probe function is called:

[    0.053068] dsa_loop_bdinfo_init
[    1.509255] dsa_loop_init
[    1.513178] dsa_loop_drv_probe
[    2.633673] dsa_loop_drv_probe
...
[    3.273496] dsa_loop_drv_probe
[    3.276589] dsa_loop_get_protocol
[    3.281608] dsa-loop fixed-0:1f: skipping link registration for CPU port 5
[    3.288558]  (null): phylink: error: empty supported_interfaces
[    3.294500] error creating PHYLINK: -22
[    3.298343] dsa-loop fixed-0:1f lan1 (uninitialized): error -22
setting up PHY for tree 0, switch 0, port 0
[    3.308145]  (null): phylink: error: empty supported_interfaces
[    3.314070] error creating PHYLINK: -22
[    3.317907] dsa-loop fixed-0:1f lan2 (uninitialized): error -22
setting up PHY for tree 0, switch 0, port 1
[    3.327677]  (null): phylink: error: empty supported_interfaces
[    3.333609] error creating PHYLINK: -22
[    3.337449] dsa-loop fixed-0:1f lan3 (uninitialized): error -22
setting up PHY for tree 0, switch 0, port 2
[    3.347223]  (null): phylink: error: empty supported_interfaces
[    3.353145] error creating PHYLINK: -22
[    3.356983] dsa-loop fixed-0:1f lan4 (uninitialized): error -22
setting up PHY for tree 0, switch 0, port 3
[    3.366855] device eth0 entered promiscuous mode
[    3.371497] DSA: tree 0 setup
[    3.374474] dsa-loop fixed-0:1f: DSA mockup driver: 0x1f

The -22 error appears to be related to the issues mentioned here:
https://www.spinics.net/lists/netdev/msg922961.html so I will now try
to apply the suggested short-term fix.

  parent reply	other threads:[~2024-05-15  9:23 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-13 15:33 drivers/net/dsa/dsa_loop_bdinfo.c build problems Stephen Langstaff
2024-05-13 15:34 ` Florian Fainelli
2024-05-13 15:36   ` Stephen Langstaff
2024-05-13 15:40     ` Florian Fainelli
2024-05-13 15:45       ` Stephen Langstaff
2024-05-13 15:50         ` Florian Fainelli
2024-05-13 16:21           ` Stephen Langstaff
2024-05-13 16:54             ` Andrew Lunn
2024-05-13 17:40               ` Stephen Langstaff
2024-05-13 17:54                 ` Andrew Lunn
     [not found]                   ` <CAHx5RXCF0=Soz_k88RGvJFGrajaxn=mVnqpb99GAQ=b7XOcWiw@mail.gmail.com>
2024-05-13 19:05                     ` Florian Fainelli
2024-05-14  9:28                       ` Stephen Langstaff
2024-05-14 12:32                         ` Andrew Lunn
2024-05-14 16:08                           ` Stephen Langstaff
2024-05-14 16:17                             ` Andrew Lunn
2024-05-15  4:05                               ` Florian Fainelli
2024-05-15 19:20                                 ` Florian Fainelli
2024-05-16  2:17                                   ` Masahiro Yamada
2024-05-16  3:35                                     ` Florian Fainelli
2024-05-16  6:39                                       ` Masahiro Yamada
2024-05-15  9:23                               ` Stephen Langstaff [this message]
2024-05-15 19:26                                 ` Florian Fainelli
2024-05-16  9:27                                   ` Stephen Langstaff
  -- strict thread matches above, loose matches on Subject: below --
2024-05-13 14:43 Stephen Langstaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHx5RXC44V-qsN9QiuhKrDdGZ4ppXpT_cQz3XNAa2aQnf7Pe5Q@mail.gmail.com \
    --to=stephenlangstaff1@gmail.com \
    --cc=OlteanV@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).