From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E5381534ED for ; Mon, 13 May 2024 13:36:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715607389; cv=none; b=rCO30FEQgtXGg2VXfHHLHR039/j0jdWKoo2GxBJVc90qyLFTSUt3sRk1B/VLGMStOHOwa7OtoiqvTO+ZS7q5ZPJMRAnBn6RjE7k5q6HnxJFtzKCwc8qLYR8XDmpGItoHgCDlaMelfEsVULnEZwqs5/P30lXzpFfKh8VdWEGthpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715607389; c=relaxed/simple; bh=7xu5WctdtZR/wOb4blrphPM3O51kqNl976gHYaCXAtk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=so93zfmk7q6bdKgktlMKafp9gv32ucCWYrsqC87CvigOI8DXlklyoQtio1FIeNXFu+wFQDpQf2uHl/uABE4JxsddY1gZ0cPkY4A527xYsMAdRR9SfaXwLyc2sI0aRiFnw777N/xlGSdZCAmNrZfQGNKBSqIKCAManUGJXuAbxzc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=QwgPWrXj; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QwgPWrXj" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2e3e18c240fso46861021fa.0 for ; Mon, 13 May 2024 06:36:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715607385; x=1716212185; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ABNtOh/Z3AIwsdePLSWkzeYb78xrA+zqTZ4Vj4WEmaE=; b=QwgPWrXjlcCRjZgI5QtkUOtDZX43h4mKVAovULt/UX6v60LhlI+GFJe+/KFh8ay1Pu tes/S52KPw/2T0/82v2VX8ZRjCZKUz2zaSwADt6brXxTWu2S/MLiQ6qFZDoAw5UXbgMc A57WnfyuVdSXFKm3oMIDETgsvJqgOwPIWRDv0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715607385; x=1716212185; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ABNtOh/Z3AIwsdePLSWkzeYb78xrA+zqTZ4Vj4WEmaE=; b=sRSTH3oaoUVF+okcdBIti3swGrSE5Jj60bab9auFLoxBnu661Gxrm9VEczMDkTGVTP K8W1EJZWOe0aho8O9Iit8IRtW9Tgj5gbCcAVv458ZE5Li0LfY5mDMCuPINndRM1sIztI mFl1WZv1A3AVRcuyg48u0i5tl1yYtokJZU5PK1/mXon3pnOyxN78+6r8aJVR+KhNoLPy SiiYtSj71r0DHeP17Hswh7mOgNh1rt3EwyaL7LGT3mZGxtGuYWwwLmO1lVy39bG9JA3f qaOogLB8/bFQYJmCFzxOftPtei6UUwuaqvpN/vjT1OC7sGsPpgMhxErd0jWQ2nJvH0XA nMAg== X-Forwarded-Encrypted: i=1; AJvYcCVXwVqAPTklvl4Gzi0xHaC0Zdhfp/YT7PJvcbdhgXQt6U9nbaoK8fU30VI89tiWHXphNT1vmia10k4tUM7yKqqOzrYDjGIqweqPU5Ku X-Gm-Message-State: AOJu0YyTqy2AIYVqJajWdmoH2pexyTAIu4arxRzZ3Rtvk+qvQ5944UbI kecBj+qJ8B5i+lpUnfy9YHt7qHmBTRn4lM1IvjBiKmHnRmleUjJkFtiCvqyvx/54E96ZYecP+LS eflxJUC0= X-Google-Smtp-Source: AGHT+IFicbL8ZZmuW10bTgKQMbOVRENgMrOMXiL6Ui9p27MNt+bMVKEuzttqsyUriqBokyUoJ54w7A== X-Received: by 2002:a2e:b0db:0:b0:2d9:fb60:9afa with SMTP id 38308e7fff4ca-2e5203b41ecmr86710971fa.40.1715607385719; Mon, 13 May 2024 06:36:25 -0700 (PDT) Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com. [209.85.218.44]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5743065dd09sm4167163a12.64.2024.05.13.06.36.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 May 2024 06:36:25 -0700 (PDT) Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a59ab4f60a6so914407666b.0 for ; Mon, 13 May 2024 06:36:24 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWWzd66cmay9uYkJSrB+azJwUYJLquHWVCnfFcy3hNDxfuAheiOJXRK3GKjQaPPc6uqaVBieEkkm7JWE/RzMqqrZP4TbXaRWdsdIG9y X-Received: by 2002:adf:f8c4:0:b0:34f:5d07:ebda with SMTP id ffacd0b85a97d-3504a63111fmr10276952f8f.23.1715607363511; Mon, 13 May 2024 06:36:03 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240429-fix-cocci-v3-0-3c4865f5a4b0@chromium.org> <20240429-fix-cocci-v3-26-3c4865f5a4b0@chromium.org> <20240503112758.763d8d31@sal.lan> In-Reply-To: From: Ricardo Ribalda Date: Mon, 13 May 2024 15:35:49 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 26/26] media: dvb-frontends: tda10048: Make the range of z explicit. To: Dragan Simic , Michael Krufky Cc: Dan Carpenter , Mauro Carvalho Chehab , Martin Tuma , Laurent Pinchart , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Benjamin Mugnier , Sylvain Petinot , Stanimir Varbanov , Vikash Garodia , "Bryan O'Donoghue" , Bjorn Andersson , Konrad Dybcio , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Fri, 3 May 2024 at 16:08, Dragan Simic wrote: > > Hello Ricardo, > > On 2024-05-03 13:56, Ricardo Ribalda wrote: > > I am trying to get the DS, but > > https://www.nxp.com/acrobat_download/literature/9397/75015931.pdf is a > > dead links now. > > > > Anyone have access to the datasheet? > > It's kind of available on the link below, but for some strange reason > the download fails after downloading the first 128 KB or so. > > https://web.archive.org/web/20080907185532/https://www.nxp.com/acrobat_download/literature/9397/75015931.pdf\ Mike, by any chance do you have a copy of the DS? > > > > On Fri, 3 May 2024 at 13:55, Dan Carpenter > > wrote: > >> > >> On Fri, May 03, 2024 at 11:27:58AM +0100, Mauro Carvalho Chehab wrote: > >> > Em Mon, 29 Apr 2024 15:05:05 +0000 > >> > Ricardo Ribalda escreveu: > >> > > >> > > We do not expect the sample_freq to be over 613MHz. > >> > > > >> > > Found by cocci: > >> > > drivers/media/dvb-frontends/tda10048.c:345:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead. > >> > > > >> > > Signed-off-by: Ricardo Ribalda > >> > > --- > >> > > drivers/media/dvb-frontends/tda10048.c | 4 +++- > >> > > 1 file changed, 3 insertions(+), 1 deletion(-) > >> > > > >> > > diff --git a/drivers/media/dvb-frontends/tda10048.c b/drivers/media/dvb-frontends/tda10048.c > >> > > index 3e725cdcc66b..1886f733dbbf 100644 > >> > > --- a/drivers/media/dvb-frontends/tda10048.c > >> > > +++ b/drivers/media/dvb-frontends/tda10048.c > >> > > @@ -328,7 +328,8 @@ static int tda10048_set_wref(struct dvb_frontend *fe, u32 sample_freq_hz, > >> > > u32 bw) > >> > > { > >> > > struct tda10048_state *state = fe->demodulator_priv; > >> > > - u64 t, z; > >> > > + u32 z; > >> > > + u64 t; > >> > > > >> > > dprintk(1, "%s()\n", __func__); > >> > > > >> > > @@ -341,6 +342,7 @@ static int tda10048_set_wref(struct dvb_frontend *fe, u32 sample_freq_hz, > >> > > /* t *= 2147483648 on 32bit platforms */ > >> > > t *= (2048 * 1024); > >> > > t *= 1024; > >> > > + /* Sample frequency is under 613MHz */ > >> > > >> > Are you sure about that? Some DVB devices have very high frequency > >> > clocks, specially if they're also used for satellite, so I can't > >> > be sure by just looking at the driver's code. > >> > > >> > Also, we had already a bunch of regressions with "fixes" like this > >> > that actually broke frontend drivers. > >> > >> This patch preserves the existing behavior. The sample_freq_hz > >> variable > >> is a u32 so, in the original code, z couldn't have been more than > >> U32_MAX even though it was declared as a u64. I agree with Dan, we keep the existing behaviour. So it wont hurt to merge the code... All that said, if someone has access to the DS, I do not mind reviewing it. > >> > >> It's possible that the original code was wrong. We have seen that in > >> other places in this patchset. Adding a note about the datasheet is > >> also a good idea. > >> > >> regards, > >> dan carpenter > >> -- Ricardo Ribalda