From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: Abel Vesa <abelvesa@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Jacky Bai <ping.bai@nxp.com>,
Ye Li <ye.li@nxp.com>, Dong Aisheng <aisheng.dong@nxp.com>,
linux-clk@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Abel Vesa <abel.vesa@linaro.org>,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH v2 03/17] clk: imx: composite-7ulp: Check the PCC present bit
Date: Mon, 13 May 2024 08:54:36 +0200 [thread overview]
Message-ID: <ZkG5LGzFGWe0blJ_@pengutronix.de> (raw)
In-Reply-To: <20240510-imx-clk-v2-3-c998f315d29c@nxp.com>
On Fri, May 10, 2024 at 05:18:58PM +0800, Peng Fan (OSS) wrote:
> From: Ye Li <ye.li@nxp.com>
>
> When some module is disabled by fuse, its PCC PR bit is default 0 and
> PCC is not operational. Any write to this PCC will cause SError.
>
> Fixes: b40ba8065347 ("clk: imx: Update the compsite driver to support imx8ulp")
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
> Signed-off-by: Ye Li <ye.li@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/clk/imx/clk-composite-7ulp.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/clk/imx/clk-composite-7ulp.c b/drivers/clk/imx/clk-composite-7ulp.c
> index e208ddc51133..e70a03e7299c 100644
> --- a/drivers/clk/imx/clk-composite-7ulp.c
> +++ b/drivers/clk/imx/clk-composite-7ulp.c
> @@ -14,6 +14,7 @@
> #include "../clk-fractional-divider.h"
> #include "clk.h"
>
> +#define PCG_PR_MASK BIT(31)
> #define PCG_PCS_SHIFT 24
> #define PCG_PCS_MASK 0x7
> #define PCG_CGC_SHIFT 30
> @@ -78,6 +79,10 @@ static struct clk_hw *imx_ulp_clk_hw_composite(const char *name,
> struct clk_hw *hw;
> u32 val;
>
> + val = readl(reg);
> + if (!(val & PCG_PR_MASK))
> + return ERR_PTR(-ENODEV);
It looks like this will trigger an error message in imx_check_clk_hws()
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2024-05-13 6:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 9:18 [PATCH v2 00/17] clk: imx: misc update/fix Peng Fan (OSS)
2024-05-10 9:18 ` [PATCH v2 01/17] clk: imx: composite-8m: Enable gate clk with mcore_booted Peng Fan (OSS)
2024-05-13 6:39 ` Sascha Hauer
2024-05-13 8:31 ` Peng Fan
2024-05-10 9:18 ` [PATCH v2 02/17] clk: imx: composite-93: keep root clock on when mcore enabled Peng Fan (OSS)
2024-05-10 9:18 ` [PATCH v2 03/17] clk: imx: composite-7ulp: Check the PCC present bit Peng Fan (OSS)
2024-05-13 6:54 ` Sascha Hauer [this message]
2024-05-10 9:18 ` [PATCH v2 04/17] clk: imx: fracn-gppll: fix fractional part of PLL getting lost Peng Fan (OSS)
2024-05-10 9:19 ` [PATCH v2 05/17] clk: imx: pll14xx: Add constraint for fvco frequency Peng Fan (OSS)
2024-05-13 12:13 ` Rasmus Villemoes
2024-05-13 12:39 ` Peng Fan
2024-05-13 12:28 ` Rasmus Villemoes
2024-05-13 12:42 ` Peng Fan
2024-05-13 12:40 ` Adam Ford
2024-05-10 9:19 ` [PATCH v2 06/17] clk: imx: pll14xx: use rate_table for audio plls Peng Fan (OSS)
2024-05-13 11:49 ` Rasmus Villemoes
2024-05-13 11:56 ` Peng Fan
2024-05-10 9:19 ` [PATCH v2 07/17] clk: imx: imx8mp-audiomix: remove sdma root clock Peng Fan (OSS)
2024-05-10 9:19 ` [PATCH v2 08/17] clk: imx: imx8mp: fix clock tree update of TF-A managed clocks Peng Fan (OSS)
2024-05-13 12:26 ` Ahmad Fatoum
2024-05-10 9:19 ` [PATCH v2 09/17] clk: imx: Remove CLK_SET_PARENT_GATE for DRAM mux for i.MX7D Peng Fan (OSS)
2024-05-10 9:19 ` [PATCH v2 10/17] clk: imx: add CLK_SET_RATE_PARENT for lcdif_pixel_src " Peng Fan (OSS)
2024-05-10 9:19 ` [PATCH v2 11/17] clk: imx: imx8mn: add sai7_ipg_clk clock settings Peng Fan (OSS)
2024-05-10 9:19 ` [PATCH v2 12/17] clk: imx: imx8mm: Change the 'nand_usdhc_bus' clock to non-critical one Peng Fan (OSS)
2024-05-10 9:19 ` [PATCH v2 13/17] clk: imx: imx8qxp: Add LVDS bypass clocks Peng Fan (OSS)
2024-05-10 9:19 ` [PATCH v2 14/17] clk: imx: imx8qxp: Add clock muxes for MIPI and PHY ref clocks Peng Fan (OSS)
2024-05-10 9:19 ` [PATCH v2 15/17] clk: imx: imx8qxp: Register dc0_bypass0_clk before disp clk Peng Fan (OSS)
2024-05-10 9:19 ` [PATCH v2 16/17] clk: imx: imx8qxp: Parent should be initialized earlier than the clock Peng Fan (OSS)
2024-05-10 9:19 ` [PATCH v2 17/17] clk: imx: fracn-gppll: update rate table Peng Fan (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkG5LGzFGWe0blJ_@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=abel.vesa@linaro.org \
--cc=abelvesa@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=ping.bai@nxp.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).