From: Horia Geanta <horia.geanta@nxp.com>
To: Pankaj Gupta <pankaj.gupta@nxp.com>,
Gaurav Jain <gaurav.jain@nxp.com>, Varun Sethi <V.Sethi@nxp.com>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"davem@davemloft.net" <davem@davemloft.net>,
Iuliana Prodan <iuliana.prodan@nxp.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v3 1/2] caam: init-clk based on caam-page0-access
Date: Thu, 18 Apr 2024 14:49:52 +0000 [thread overview]
Message-ID: <a4143756-e046-473c-8507-d638c5ee0442@nxp.com> (raw)
In-Reply-To: <20240416053303.421259-2-pankaj.gupta@nxp.com>
On 4/16/2024 8:35 AM, Pankaj Gupta wrote:
> CAAM clock initializat is done based on the basis of soc specific
^ initialization
> @@ -889,17 +895,25 @@ static int caam_probe(struct platform_device *pdev)
>
> reg_access = !ctrlpriv->optee_en;
>
> - if (!imx_soc_match->data) {
> + if (imx_soc_match->data) {
This is obviously incorrect.
> dev_err(dev, "No clock data provided for i.MX SoC");
> return -EINVAL;
> }
Regards,
Horia
next prev parent reply other threads:[~2024-04-18 14:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 5:33 [PATCH v3 0/2] caam: init-clk based on caam-page0-access Pankaj Gupta
2024-04-16 5:33 ` [PATCH v3 1/2] " Pankaj Gupta
2024-04-18 14:49 ` Horia Geanta [this message]
2024-04-19 5:29 ` Pankaj Gupta
2024-05-13 6:09 ` Pankaj Gupta
2024-04-16 5:33 ` [PATCH v3 2/2] drivers: crypto: caam: i.MX8ULP donot have CAAM page0 access Pankaj Gupta
2024-04-18 14:53 ` Horia Geanta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4143756-e046-473c-8507-d638c5ee0442@nxp.com \
--to=horia.geanta@nxp.com \
--cc=V.Sethi@nxp.com \
--cc=davem@davemloft.net \
--cc=gaurav.jain@nxp.com \
--cc=herbert@gondor.apana.org.au \
--cc=iuliana.prodan@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).