* [PATCH 0/3] sh: Fix missing prototypes (part three)
@ 2024-05-13 13:20 Geert Uytterhoeven
2024-05-13 13:20 ` [PATCH 1/3] sh: of-generic: Add missing #include <asm/clock.h> Geert Uytterhoeven
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2024-05-13 13:20 UTC (permalink / raw
To: Yoshinori Sato, Rich Felker, John Paul Adrian Glaubitz,
Arnd Bergmann
Cc: linux-sh, linux-kernel, Geert Uytterhoeven
Hi all,
This patch series fixes more "no previous prototype for <foo>" warnings
when building a kernel for SuperH, namely when building j2_defconfig.
Thanks for your comments!
Geert Uytterhoeven (3):
sh: of-generic: Add missing #include <asm/clock.h>
sh: smp: Protect setup_profiling_timer() by CONFIG_PROFILING
sh: setup: Add missing forward declaration for sh_fdt_init()
arch/sh/boards/of-generic.c | 2 ++
arch/sh/include/asm/setup.h | 1 +
arch/sh/kernel/smp.c | 2 ++
3 files changed, 5 insertions(+)
--
2.34.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/3] sh: of-generic: Add missing #include <asm/clock.h>
2024-05-13 13:20 [PATCH 0/3] sh: Fix missing prototypes (part three) Geert Uytterhoeven
@ 2024-05-13 13:20 ` Geert Uytterhoeven
2024-05-13 13:20 ` [PATCH 2/3] sh: smp: Protect setup_profiling_timer() by CONFIG_PROFILING Geert Uytterhoeven
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2024-05-13 13:20 UTC (permalink / raw
To: Yoshinori Sato, Rich Felker, John Paul Adrian Glaubitz,
Arnd Bergmann
Cc: linux-sh, linux-kernel, Geert Uytterhoeven
arch/sh/boards/of-generic.c:146:20: warning: no previous prototype for 'arch_init_clk_ops' [-Wmissing-prototypes]
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/sh/boards/of-generic.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/sh/boards/of-generic.c b/arch/sh/boards/of-generic.c
index f7f3e618e85b6a52..cc88cb8908cc1d2e 100644
--- a/arch/sh/boards/of-generic.c
+++ b/arch/sh/boards/of-generic.c
@@ -10,6 +10,8 @@
#include <linux/of_fdt.h>
#include <linux/clocksource.h>
#include <linux/irqchip.h>
+
+#include <asm/clock.h>
#include <asm/machvec.h>
#include <asm/rtc.h>
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/3] sh: smp: Protect setup_profiling_timer() by CONFIG_PROFILING
2024-05-13 13:20 [PATCH 0/3] sh: Fix missing prototypes (part three) Geert Uytterhoeven
2024-05-13 13:20 ` [PATCH 1/3] sh: of-generic: Add missing #include <asm/clock.h> Geert Uytterhoeven
@ 2024-05-13 13:20 ` Geert Uytterhoeven
2024-05-13 13:20 ` [PATCH 3/3] sh: setup: Add missing forward declaration for sh_fdt_init() Geert Uytterhoeven
2024-05-13 13:30 ` [PATCH 0/3] sh: Fix missing prototypes (part three) John Paul Adrian Glaubitz
3 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2024-05-13 13:20 UTC (permalink / raw
To: Yoshinori Sato, Rich Felker, John Paul Adrian Glaubitz,
Arnd Bergmann
Cc: linux-sh, linux-kernel, Geert Uytterhoeven
arch/sh/kernel/smp.c:326:5: warning: no previous prototype for 'setup_profiling_timer' [-Wmissing-prototypes]
The function is unconditionally defined in smp.c, but conditionally
declared in <linux/profile.h>.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/sh/kernel/smp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/sh/kernel/smp.c b/arch/sh/kernel/smp.c
index b3ea50aabba3d7f2..108d808767fa9984 100644
--- a/arch/sh/kernel/smp.c
+++ b/arch/sh/kernel/smp.c
@@ -322,11 +322,13 @@ void smp_message_recv(unsigned int msg)
}
}
+#ifdef CONFIG_PROFILING
/* Not really SMP stuff ... */
int setup_profiling_timer(unsigned int multiplier)
{
return 0;
}
+#endif
#ifdef CONFIG_MMU
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/3] sh: setup: Add missing forward declaration for sh_fdt_init()
2024-05-13 13:20 [PATCH 0/3] sh: Fix missing prototypes (part three) Geert Uytterhoeven
2024-05-13 13:20 ` [PATCH 1/3] sh: of-generic: Add missing #include <asm/clock.h> Geert Uytterhoeven
2024-05-13 13:20 ` [PATCH 2/3] sh: smp: Protect setup_profiling_timer() by CONFIG_PROFILING Geert Uytterhoeven
@ 2024-05-13 13:20 ` Geert Uytterhoeven
2024-05-13 13:30 ` [PATCH 0/3] sh: Fix missing prototypes (part three) John Paul Adrian Glaubitz
3 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2024-05-13 13:20 UTC (permalink / raw
To: Yoshinori Sato, Rich Felker, John Paul Adrian Glaubitz,
Arnd Bergmann
Cc: linux-sh, linux-kernel, Geert Uytterhoeven
arch/sh/kernel/setup.c:244:12: warning: no previous prototype for 'sh_fdt_init' [-Wmissing-prototypes]
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/sh/include/asm/setup.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/sh/include/asm/setup.h b/arch/sh/include/asm/setup.h
index fc807011187fa1c0..84bb23a771f3538b 100644
--- a/arch/sh/include/asm/setup.h
+++ b/arch/sh/include/asm/setup.h
@@ -21,5 +21,6 @@
void sh_mv_setup(void);
void check_for_initrd(void);
void per_cpu_trap_init(void);
+void sh_fdt_init(phys_addr_t dt_phys);
#endif /* _SH_SETUP_H */
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 0/3] sh: Fix missing prototypes (part three)
2024-05-13 13:20 [PATCH 0/3] sh: Fix missing prototypes (part three) Geert Uytterhoeven
` (2 preceding siblings ...)
2024-05-13 13:20 ` [PATCH 3/3] sh: setup: Add missing forward declaration for sh_fdt_init() Geert Uytterhoeven
@ 2024-05-13 13:30 ` John Paul Adrian Glaubitz
3 siblings, 0 replies; 5+ messages in thread
From: John Paul Adrian Glaubitz @ 2024-05-13 13:30 UTC (permalink / raw
To: Geert Uytterhoeven, Yoshinori Sato, Rich Felker, Arnd Bergmann
Cc: linux-sh, linux-kernel
Hi Geert,
On Mon, 2024-05-13 at 15:20 +0200, Geert Uytterhoeven wrote:
> Hi all,
>
> This patch series fixes more "no previous prototype for <foo>" warnings
> when building a kernel for SuperH, namely when building j2_defconfig.
>
> Thanks for your comments!
>
> Geert Uytterhoeven (3):
> sh: of-generic: Add missing #include <asm/clock.h>
> sh: smp: Protect setup_profiling_timer() by CONFIG_PROFILING
> sh: setup: Add missing forward declaration for sh_fdt_init()
>
> arch/sh/boards/of-generic.c | 2 ++
> arch/sh/include/asm/setup.h | 1 +
> arch/sh/kernel/smp.c | 2 ++
> 3 files changed, 5 insertions(+)
Thanks a lot for fixing these. I have run into these as well and except
for patch #2 where you found the proper fix, my proposed fixes looked
exactly the same.
Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-13 13:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-13 13:20 [PATCH 0/3] sh: Fix missing prototypes (part three) Geert Uytterhoeven
2024-05-13 13:20 ` [PATCH 1/3] sh: of-generic: Add missing #include <asm/clock.h> Geert Uytterhoeven
2024-05-13 13:20 ` [PATCH 2/3] sh: smp: Protect setup_profiling_timer() by CONFIG_PROFILING Geert Uytterhoeven
2024-05-13 13:20 ` [PATCH 3/3] sh: setup: Add missing forward declaration for sh_fdt_init() Geert Uytterhoeven
2024-05-13 13:30 ` [PATCH 0/3] sh: Fix missing prototypes (part three) John Paul Adrian Glaubitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).