From: Justin Lai <justinlai0215@realtek.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"horms@kernel.org" <horms@kernel.org>,
Ping-Ke Shih <pkshih@realtek.com>,
Larry Chiu <larry.chiu@realtek.com>
Subject: RE: [PATCH net-next v18 10/13] rtase: Implement ethtool function
Date: Fri, 10 May 2024 08:12:28 +0000 [thread overview]
Message-ID: <b5c86321761f4d24921b3a4a1f02c694@realtek.com> (raw)
In-Reply-To: <20240509204047.149e226e@kernel.org>
> On Wed, 8 May 2024 20:39:42 +0800 Justin Lai wrote:
> > + data[0] = le64_to_cpu(counters->tx_packets);
> > + data[1] = le64_to_cpu(counters->rx_packets);
> > + data[2] = le64_to_cpu(counters->tx_errors);
> > + data[3] = le32_to_cpu(counters->rx_errors);
> > + data[4] = le16_to_cpu(counters->rx_missed);
> > + data[5] = le16_to_cpu(counters->align_errors);
> > + data[6] = le32_to_cpu(counters->tx_one_collision);
> > + data[7] = le32_to_cpu(counters->tx_multi_collision);
> > + data[8] = le64_to_cpu(counters->rx_unicast);
> > + data[9] = le64_to_cpu(counters->rx_broadcast);
> > + data[10] = le32_to_cpu(counters->rx_multicast);
> > + data[11] = le16_to_cpu(counters->tx_aborted);
> > + data[12] = le16_to_cpu(counters->tx_underun);
>
> Please limit stats you report in ethtool -S to just the stats for which proper
> interfaces don't exist. Don't duplicate what's already reported via
> rtase_get_stats64(), also take a look at what can be reported via various
> *_stats members of struct ethtool_ops.
OK, I will check this part and modify it.
next prev parent reply other threads:[~2024-05-10 8:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 12:39 [PATCH net-next v18 00/13] Add Realtek automotive PCIe driver Justin Lai
2024-05-08 12:39 ` [PATCH net-next v18 01/13] rtase: Add pci table supported in this module Justin Lai
2024-05-08 12:39 ` [PATCH net-next v18 02/13] rtase: Implement the .ndo_open function Justin Lai
2024-05-09 6:57 ` Ratheesh Kannoth
2024-05-09 8:58 ` Justin Lai
2024-05-09 9:09 ` Ratheesh Kannoth
2024-05-09 9:59 ` Justin Lai
2024-05-08 12:39 ` [PATCH net-next v18 03/13] rtase: Implement the rtase_down function Justin Lai
2024-05-08 12:39 ` [PATCH net-next v18 04/13] rtase: Implement the interrupt routine and rtase_poll Justin Lai
2024-05-08 12:39 ` [PATCH net-next v18 05/13] rtase: Implement hardware configuration function Justin Lai
2024-05-08 12:39 ` [PATCH net-next v18 06/13] rtase: Implement .ndo_start_xmit function Justin Lai
2024-05-10 16:40 ` Andrew Lunn
2024-05-13 3:07 ` Justin Lai
2024-05-13 3:43 ` Justin Lai
2024-05-08 12:39 ` [PATCH net-next v18 07/13] rtase: Implement a function to receive packets Justin Lai
2024-05-08 12:39 ` [PATCH net-next v18 08/13] rtase: Implement net_device_ops Justin Lai
2024-05-08 12:39 ` [PATCH net-next v18 09/13] rtase: Implement pci_driver suspend and resume function Justin Lai
2024-05-08 12:39 ` [PATCH net-next v18 10/13] rtase: Implement ethtool function Justin Lai
2024-05-10 3:40 ` Jakub Kicinski
2024-05-10 8:12 ` Justin Lai [this message]
2024-05-08 12:39 ` [PATCH net-next v18 11/13] rtase: Add a Makefile in the rtase folder Justin Lai
2024-05-08 12:39 ` [PATCH net-next v18 12/13] realtek: Update the Makefile and Kconfig in the realtek folder Justin Lai
2024-05-08 12:39 ` [PATCH net-next v18 13/13] MAINTAINERS: Add the rtase ethernet driver entry Justin Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5c86321761f4d24921b3a4a1f02c694@realtek.com \
--to=justinlai0215@realtek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=larry.chiu@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).