LKML Archive mirror
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: arnd@arndb.de, glaubitz@physik.fu-berlin.de,
	ink@jurassic.park.msu.ru, linux-alpha@vger.kernel.org,
	linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	mattst88@gmail.com, richard.henderson@linaro.org,
	torvalds@linux-foundation.org, viro@zeniv.linux.org.uk,
	Ulrich Teichert <krypton@ulrich-teichert.org>
Subject: Re: [GIT PULL] alpha: cleanups and build fixes for 6.10
Date: Sun, 12 May 2024 21:03:18 -0700	[thread overview]
Message-ID: <ec4e905b-030c-43bb-818a-f4a0299597f7@paulmck-laptop> (raw)
In-Reply-To: <99765904-3f35-4c78-998e-b444a6ab90e4@gmail.com>

On Mon, May 13, 2024 at 12:50:07PM +0900, Akira Yokosawa wrote:
> On Sun, 12 May 2024 07:44:25 -0700, Paul E. McKenney wrote:
> > On Sun, May 12, 2024 at 08:02:59AM +0200, John Paul Adrian Glaubitz wrote:
> >> On Sat, 2024-05-11 at 18:26 -0700, Paul E. McKenney wrote:
> >> > And that breaks things because it can clobber concurrent stores to
> >> > other bytes in that enclosing machine word.
> >> 
> >> But pre-EV56 Alpha has always been like this. What makes it broken
> >> all of a sudden?
> > 
> > I doubt if it was sudden.   Putting concurrently (but rarely) accessed
> > small-value quantities into single bytes is a very natural thing to do,
> > and I bet that there are quite a few places in the kernel where exactly
> > this happens.  I happen to know of a specific instance that went into
> > mainline about two years ago.
> > 
> > So why didn't the people running current mainline on pre-EV56 Alpha
> > systems notice?  One possibility is that they are upgrading their
> > kernels only occasionally.  Another possibility is that they are seeing
> > the failures, but are not tracing the obtuse failure modes back to the
> > change(s) in question.  Yet another possibility is that the resulting
> > failures are very low probability, with mean times to failure that are
> > so long that you won't notice anything on a single system.
> 
> Another possibility is that the Jensen system was booted into uni processer
> mode.  Looking at the early boot log [1] provided by Ulrich (+CCed) back in
> Sept. 2021, I see the following by running "grep -i cpu":
> 
> >> > [1] https://marc.info/?l=linux-alpha&m=163265555616841&w=2
> 
> [    0.000000] Memory: 90256K/131072K available (8897K kernel code, 9499K rwdata, \
> 2704K rodata, 312K init, 437K bss, 40816K reserved, 0K cma-reserved) [    0.000000] \
> random: get_random_u64 called from __kmem_cache_create+0x54/0x600 with crng_init=0 [  \
> 0.000000] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=1, Nodes=1 [    0.000000]
>                                                      ^^^^^^
> 
> Without any concurrent atomic updates, the "broken" atomic accesses won't
> matter, I guess.

True enough!

							Thanx, Paul

  reply	other threads:[~2024-05-13  4:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-10 21:17 [GIT PULL] asm-generic cleanups for 6.10 Arnd Bergmann
2024-05-10 21:19 ` [GIT PULL] alpha: cleanups and build fixes " Arnd Bergmann
2024-05-10 21:40   ` John Paul Adrian Glaubitz
2024-05-10 22:28     ` Paul E. McKenney
2024-05-11 18:49       ` John Paul Adrian Glaubitz
2024-05-11 19:37         ` Paul E. McKenney
2024-05-11 20:08           ` Arnd Bergmann
2024-05-12  1:26             ` Paul E. McKenney
2024-05-12  6:02               ` John Paul Adrian Glaubitz
2024-05-12 14:44                 ` Paul E. McKenney
2024-05-13  3:50                   ` Akira Yokosawa
2024-05-13  4:03                     ` Paul E. McKenney [this message]
2024-05-13  6:28                       ` Arnd Bergmann
2024-05-13  9:26                     ` John Paul Adrian Glaubitz
2024-05-13 16:52                     ` Ulrich Teichert
2024-05-13 21:44                       ` John Paul Adrian Glaubitz
2024-05-13  7:10                   ` John Paul Adrian Glaubitz
2024-05-12  6:17   ` John Paul Adrian Glaubitz
2024-05-13 16:27   ` Linus Torvalds
2024-05-13 21:42     ` John Paul Adrian Glaubitz
2024-05-31  2:53       ` Maciej W. Rozycki
2024-05-13 17:05   ` pr-tracker-bot
2024-05-13 16:11 ` [GIT PULL] asm-generic cleanups " Linus Torvalds
2024-05-13 16:36   ` Arnd Bergmann
2024-05-20 22:35 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec4e905b-030c-43bb-818a-f4a0299597f7@paulmck-laptop \
    --to=paulmck@kernel.org \
    --cc=akiyks@gmail.com \
    --cc=arnd@arndb.de \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=ink@jurassic.park.msu.ru \
    --cc=krypton@ulrich-teichert.org \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=richard.henderson@linaro.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).