* [PATCH] peci, hwmon: Switch to new Intel CPU model defines
@ 2024-05-29 17:19 Tony Luck
2024-05-29 17:32 ` Guenter Roeck
2024-06-03 13:17 ` Winiarska, Iwona
0 siblings, 2 replies; 3+ messages in thread
From: Tony Luck @ 2024-05-29 17:19 UTC (permalink / raw
To: Iwona Winiarska, Jean Delvare, Guenter Roeck
Cc: linux-hwmon, openbmc, Tony Luck, linux-kernel, patches
Update peci subsystem to use the same vendor-family-model
combined definition that core x86 code uses.
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
TIP tree applied the patches that implement the new CPU model number
macros (and a couple of dozen patches to arch/x86/ files too). So
v6.10-rc1 has all the necesary code to apply patches to other trees in
this cycle.
The previous posting of this patch[1] had a tiny bit of fuzz due to
nearby changes in drivers/peci/internal.h. This one applies cleanly
to v6.10-rc1.
Iwona, Jean, Guenter: Can you check that it still looks good. If so
apply it to your tree and kick the process in gear to have it appear in
the intel-next tree with eventual merge to Linus in next merge window.
Thanks
-Tony
[1] https://lore.kernel.org/all/20240520224620.9480-48-tony.luck@intel.com/
include/linux/peci-cpu.h | 24 ++++++++++++++++++++++++
include/linux/peci.h | 6 ++----
drivers/peci/internal.h | 6 ++----
drivers/hwmon/peci/cputemp.c | 8 ++++----
drivers/peci/core.c | 5 ++---
drivers/peci/cpu.c | 21 +++++++--------------
drivers/peci/device.c | 3 +--
7 files changed, 42 insertions(+), 31 deletions(-)
diff --git a/include/linux/peci-cpu.h b/include/linux/peci-cpu.h
index ff8ae9c26c80..601cdd086bf6 100644
--- a/include/linux/peci-cpu.h
+++ b/include/linux/peci-cpu.h
@@ -6,6 +6,30 @@
#include <linux/types.h>
+/* Copied from x86 <asm/processor.h> */
+#define X86_VENDOR_INTEL 0
+
+/* Copied from x86 <asm/cpu_device_id.h> */
+#define VFM_MODEL_BIT 0
+#define VFM_FAMILY_BIT 8
+#define VFM_VENDOR_BIT 16
+#define VFM_RSVD_BIT 24
+
+#define VFM_MODEL_MASK GENMASK(VFM_FAMILY_BIT - 1, VFM_MODEL_BIT)
+#define VFM_FAMILY_MASK GENMASK(VFM_VENDOR_BIT - 1, VFM_FAMILY_BIT)
+#define VFM_VENDOR_MASK GENMASK(VFM_RSVD_BIT - 1, VFM_VENDOR_BIT)
+
+#define VFM_MODEL(vfm) (((vfm) & VFM_MODEL_MASK) >> VFM_MODEL_BIT)
+#define VFM_FAMILY(vfm) (((vfm) & VFM_FAMILY_MASK) >> VFM_FAMILY_BIT)
+#define VFM_VENDOR(vfm) (((vfm) & VFM_VENDOR_MASK) >> VFM_VENDOR_BIT)
+
+#define VFM_MAKE(_vendor, _family, _model) ( \
+ ((_model) << VFM_MODEL_BIT) | \
+ ((_family) << VFM_FAMILY_BIT) | \
+ ((_vendor) << VFM_VENDOR_BIT) \
+)
+/* End of copied code */
+
#include "../../arch/x86/include/asm/intel-family.h"
#define PECI_PCS_PKG_ID 0 /* Package Identifier Read */
diff --git a/include/linux/peci.h b/include/linux/peci.h
index 90e241458ef6..3e0bc37591d6 100644
--- a/include/linux/peci.h
+++ b/include/linux/peci.h
@@ -59,8 +59,7 @@ static inline struct peci_controller *to_peci_controller(void *d)
* struct peci_device - PECI device
* @dev: device object to register PECI device to the device model
* @info: PECI device characteristics
- * @info.family: device family
- * @info.model: device model
+ * @info.x86_vfm: device vendor-family-model
* @info.peci_revision: PECI revision supported by the PECI device
* @info.socket_id: the socket ID represented by the PECI device
* @addr: address used on the PECI bus connected to the parent controller
@@ -73,8 +72,7 @@ static inline struct peci_controller *to_peci_controller(void *d)
struct peci_device {
struct device dev;
struct {
- u16 family;
- u8 model;
+ u32 x86_vfm;
u8 peci_revision;
u8 socket_id;
} info;
diff --git a/drivers/peci/internal.h b/drivers/peci/internal.h
index 506bafcccbbf..7a4f6eae2f90 100644
--- a/drivers/peci/internal.h
+++ b/drivers/peci/internal.h
@@ -66,13 +66,11 @@ struct peci_request *peci_xfer_ep_mmio64_readl(struct peci_device *device, u8 ba
/**
* struct peci_device_id - PECI device data to match
* @data: pointer to driver private data specific to device
- * @family: device family
- * @model: device model
+ * @x86_vfm: device vendor-family-model
*/
struct peci_device_id {
const void *data;
- u16 family;
- u8 model;
+ u32 x86_vfm;
};
extern const struct device_type peci_device_type;
diff --git a/drivers/hwmon/peci/cputemp.c b/drivers/hwmon/peci/cputemp.c
index a812c15948d9..5a682195b98f 100644
--- a/drivers/hwmon/peci/cputemp.c
+++ b/drivers/hwmon/peci/cputemp.c
@@ -360,10 +360,10 @@ static int init_core_mask(struct peci_cputemp *priv)
int ret;
/* Get the RESOLVED_CORES register value */
- switch (peci_dev->info.model) {
- case INTEL_FAM6_ICELAKE_X:
- case INTEL_FAM6_ICELAKE_D:
- case INTEL_FAM6_SAPPHIRERAPIDS_X:
+ switch (peci_dev->info.x86_vfm) {
+ case INTEL_ICELAKE_X:
+ case INTEL_ICELAKE_D:
+ case INTEL_SAPPHIRERAPIDS_X:
ret = peci_ep_pci_local_read(peci_dev, 0, reg->bus, reg->dev,
reg->func, reg->offset + 4, &data);
if (ret)
diff --git a/drivers/peci/core.c b/drivers/peci/core.c
index 8f8bda2f2a62..8ff3e5d225ae 100644
--- a/drivers/peci/core.c
+++ b/drivers/peci/core.c
@@ -163,9 +163,8 @@ EXPORT_SYMBOL_NS_GPL(devm_peci_controller_add, PECI);
static const struct peci_device_id *
peci_bus_match_device_id(const struct peci_device_id *id, struct peci_device *device)
{
- while (id->family != 0) {
- if (id->family == device->info.family &&
- id->model == device->info.model)
+ while (id->x86_vfm != 0) {
+ if (id->x86_vfm == device->info.x86_vfm)
return id;
id++;
}
diff --git a/drivers/peci/cpu.c b/drivers/peci/cpu.c
index bd990acd92b8..152bbd8e717a 100644
--- a/drivers/peci/cpu.c
+++ b/drivers/peci/cpu.c
@@ -294,38 +294,31 @@ peci_cpu_probe(struct peci_device *device, const struct peci_device_id *id)
static const struct peci_device_id peci_cpu_device_ids[] = {
{ /* Haswell Xeon */
- .family = 6,
- .model = INTEL_FAM6_HASWELL_X,
+ .x86_vfm = INTEL_HASWELL_X,
.data = "hsx",
},
{ /* Broadwell Xeon */
- .family = 6,
- .model = INTEL_FAM6_BROADWELL_X,
+ .x86_vfm = INTEL_BROADWELL_X,
.data = "bdx",
},
{ /* Broadwell Xeon D */
- .family = 6,
- .model = INTEL_FAM6_BROADWELL_D,
+ .x86_vfm = INTEL_BROADWELL_D,
.data = "bdxd",
},
{ /* Skylake Xeon */
- .family = 6,
- .model = INTEL_FAM6_SKYLAKE_X,
+ .x86_vfm = INTEL_SKYLAKE_X,
.data = "skx",
},
{ /* Icelake Xeon */
- .family = 6,
- .model = INTEL_FAM6_ICELAKE_X,
+ .x86_vfm = INTEL_ICELAKE_X,
.data = "icx",
},
{ /* Icelake Xeon D */
- .family = 6,
- .model = INTEL_FAM6_ICELAKE_D,
+ .x86_vfm = INTEL_ICELAKE_D,
.data = "icxd",
},
{ /* Sapphire Rapids Xeon */
- .family = 6,
- .model = INTEL_FAM6_SAPPHIRERAPIDS_X,
+ .x86_vfm = INTEL_SAPPHIRERAPIDS_X,
.data = "spr",
},
{ }
diff --git a/drivers/peci/device.c b/drivers/peci/device.c
index ee01f03c29b7..37ca7dd61807 100644
--- a/drivers/peci/device.c
+++ b/drivers/peci/device.c
@@ -100,8 +100,7 @@ static int peci_device_info_init(struct peci_device *device)
if (ret)
return ret;
- device->info.family = peci_x86_cpu_family(cpu_id);
- device->info.model = peci_x86_cpu_model(cpu_id);
+ device->info.x86_vfm = IFM(peci_x86_cpu_family(cpu_id), peci_x86_cpu_model(cpu_id));
ret = peci_get_revision(device, &revision);
if (ret)
--
2.45.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] peci, hwmon: Switch to new Intel CPU model defines
2024-05-29 17:19 [PATCH] peci, hwmon: Switch to new Intel CPU model defines Tony Luck
@ 2024-05-29 17:32 ` Guenter Roeck
2024-06-03 13:17 ` Winiarska, Iwona
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2024-05-29 17:32 UTC (permalink / raw
To: Tony Luck, Iwona Winiarska, Jean Delvare
Cc: linux-hwmon, openbmc, linux-kernel, patches
On 5/29/24 10:19, Tony Luck wrote:
> Update peci subsystem to use the same vendor-family-model
> combined definition that core x86 code uses.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
> TIP tree applied the patches that implement the new CPU model number
> macros (and a couple of dozen patches to arch/x86/ files too). So
> v6.10-rc1 has all the necesary code to apply patches to other trees in
> this cycle.
>
> The previous posting of this patch[1] had a tiny bit of fuzz due to
> nearby changes in drivers/peci/internal.h. This one applies cleanly
> to v6.10-rc1.
>
> Iwona, Jean, Guenter: Can you check that it still looks good. If so
> apply it to your tree and kick the process in gear to have it appear in
> the intel-next tree with eventual merge to Linus in next merge window.
>
lgtm
For hwmon:
Acked-by: Guenter Roeck <linux@roeck-us.net>
... assuming this is going to be merged through the peci tree.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] peci, hwmon: Switch to new Intel CPU model defines
2024-05-29 17:19 [PATCH] peci, hwmon: Switch to new Intel CPU model defines Tony Luck
2024-05-29 17:32 ` Guenter Roeck
@ 2024-06-03 13:17 ` Winiarska, Iwona
1 sibling, 0 replies; 3+ messages in thread
From: Winiarska, Iwona @ 2024-06-03 13:17 UTC (permalink / raw
To: linux@roeck-us.net, Luck, Tony, jdelvare@suse.com
Cc: linux-hwmon@vger.kernel.org, openbmc@lists.ozlabs.org,
patches@lists.linux.dev, linux-kernel@vger.kernel.org
On Wed, 2024-05-29 at 10:19 -0700, Tony Luck wrote:
> Update peci subsystem to use the same vendor-family-model
> combined definition that core x86 code uses.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
Reviewed-by: Iwona Winiarska <iwona.winiarska@intel.com>
> ---
> TIP tree applied the patches that implement the new CPU model number
> macros (and a couple of dozen patches to arch/x86/ files too). So
> v6.10-rc1 has all the necesary code to apply patches to other trees in
> this cycle.
>
> The previous posting of this patch[1] had a tiny bit of fuzz due to
> nearby changes in drivers/peci/internal.h. This one applies cleanly
> to v6.10-rc1.
>
> Iwona, Jean, Guenter: Can you check that it still looks good. If so
> apply it to your tree and kick the process in gear to have it appear in
> the intel-next tree with eventual merge to Linus in next merge window.
I'll apply it to peci-next and we can merge it in v6.11 cycle.
Thanks
-Iwona
>
> Thanks
>
> -Tony
>
> [1] https://lore.kernel.org/all/20240520224620.9480-48-tony.luck@intel.com/
>
> include/linux/peci-cpu.h | 24 ++++++++++++++++++++++++
> include/linux/peci.h | 6 ++----
> drivers/peci/internal.h | 6 ++----
> drivers/hwmon/peci/cputemp.c | 8 ++++----
> drivers/peci/core.c | 5 ++---
> drivers/peci/cpu.c | 21 +++++++--------------
> drivers/peci/device.c | 3 +--
> 7 files changed, 42 insertions(+), 31 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-03 13:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-29 17:19 [PATCH] peci, hwmon: Switch to new Intel CPU model defines Tony Luck
2024-05-29 17:32 ` Guenter Roeck
2024-06-03 13:17 ` Winiarska, Iwona
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).