raindrops RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: raindrops@librelist.org
Subject: [PATCH 1/3] linux_inet_diag: avoid unnecessary sockaddr initialization
Date: Sat, 13 Apr 2013 02:25:15 +0000	[thread overview]
Message-ID: <1365819917-27535-1-git-send-email-normalperson@yhbt.net> (raw)
In-Reply-To: <1365819917-27535-1-git-send-email-normalperson@yhbt.net>

This initialization was unnecessary and avoids the following
warning with -Wmissing-braces on gcc 4.7.2-5 on Debian testing:

  linux_inet_diag.c: In function ‘stats_for’:
  linux_inet_diag.c:192:8: warning: missing braces around initializer [-Wmissing-braces]
  linux_inet_diag.c:192:8: warning: (near initialization for ‘sa.ss’) [-Wmissing-braces]
 ext/raindrops/linux_inet_diag.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ext/raindrops/linux_inet_diag.c b/ext/raindrops/linux_inet_diag.c
index 89206bf..d94dafd 100644
--- a/ext/raindrops/linux_inet_diag.c
+++ b/ext/raindrops/linux_inet_diag.c
@@ -189,7 +189,7 @@ static struct listen_stats *stats_for(st_table *table, struct inet_diag_msg *r)
 	struct listen_stats *stats;
 	size_t keylen;
 	size_t portlen = sizeof("65535");
-	union any_addr sa = { 0 };
+	union any_addr sa;
 	socklen_t len = sizeof(struct sockaddr_storage);
 	int rc;

       reply	other threads:[~2013-04-13  2:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-13  2:25 Eric Wong [this message]
2013-04-13  2:25 ` [PATCH 2/3] .gitignore: add .rbx Eric Wong
2013-04-13  2:25 ` [PATCH 3/3] switch back to gemspec development dependencies Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: http://yhbt.net/raindrops/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365819917-27535-1-git-send-email-normalperson@yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=raindrops@librelist.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).