raindrops RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Ben Somers <somers.ben@gmail.com>
To: raindrops@librelist.org
Subject: Re: Raindrops::Middleware::Proxy claims to respond to #body when it does not?
Date: Thu, 17 May 2012 16:37:58 -0700	[thread overview]
Message-ID: <CAO1NZAoyva-YOH92MdCfr7H14T+17nVo9ri3zVvDceQiBcbV6w@mail.gmail.com> (raw)
In-Reply-To: 20120517231806.GA16830@dcvr.yhbt.net

>> Clearly the Raindrops::Middleware::Proxy has #respond_to? implemented
>> the way it is for a reason, but it seems awfully counterintuitive.
> I think I took the hint from Rack::BodyProxy.  The response needs to be
> proxied and call the #close method (to decrement the writer count).
> Proxying the body is the only way to get a Rack server to call #close
> (wrapping #each won't work because #to_path may be used instead)
> Without the proxy, raindrops wouldn't be able to instrument (userspace)
> time needed to write the response in a Rack-compliant fashion.

That is sensible.

Would it make sense to take a second hint from Rack::BodyProxy and add
a #method_missing to Raindrops::Middleware::Proxy that delegates to
its body? I think that's the answer to my concern about an unintuitive
#respond_to? method.



  reply	other threads:[~2012-05-17 23:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-17 19:07 Raindrops::Middleware::Proxy claims to respond to #body when it does not? Ben Somers
2012-05-17 23:18 ` Eric Wong
2012-05-17 23:37   ` Ben Somers [this message]
2012-05-18  0:07     ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: http://yhbt.net/raindrops/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAO1NZAoyva-YOH92MdCfr7H14T+17nVo9ri3zVvDceQiBcbV6w@mail.gmail.com \
    --to=somers.ben@gmail.com \
    --cc=raindrops@librelist.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).