From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 1507B1F66E for ; Tue, 1 Sep 2020 15:04:58 +0000 (UTC) Received: by mail-wr1-x42d.google.com with SMTP id e16so1940252wrm.2 for ; Tue, 01 Sep 2020 08:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopify.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=LF7mhWKyInl/YWwXQyNzHQEz9hFhriSr2rgJ3a7AplI=; b=kgnqrCjZo0Pbs/y2TiIAkxxItTijUvi0OPLxPu9KLjcK4nxiC2wKgpAIzJjREKx3UR 1zEnp2x3BgVACnRUarOEGlivDnve78VhXVQcYGENyb4AyOmZr8bPEzwLNOGL3RbPCeSO cgWOiXZLqe/gGM8G9cnzoxApPJtVQmAC63HLQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=LF7mhWKyInl/YWwXQyNzHQEz9hFhriSr2rgJ3a7AplI=; b=glGYe3d5NO0L6KbW86PQ3wIeUI6xwGCH3FJGbX4pu+I6gR37M6hRRHHDYxnrWvtTlI nRr55WbBWp3q8W+R5JuJr+RFzUKnzj3nZFEfVeGGvoyxe4uuftRTJDCZ7bMKytHm2b9r YkiNXFOpXq/OVa7TpNA5e4WY9Ya5yYQfHg2weMjP0D/Zq1+AvSkZt63Tsu8+uVzYa1sl hhMwg8b+m+nXxFL7iOTtTzvYPv5zgr9W6b1Qsym6gaKwhyd+PDX2zzIYZFFYqr8FBTuZ W/yuRtOZFpj4UhdRMHF3jGiYfFeYqxEtK2UKpkFHdednNkxY0btruRLDf2145XzGm3/G PuMA== X-Gm-Message-State: AOAM530jOkd8QklN9XKLi+1yd8FpFTtKP/AuDWRfDk9bbrbWB91sfPBH aKFQNHg5jqkDWfo3UxROtv8xuijRwV44DQ== X-Google-Smtp-Source: ABdhPJwRnW8ZpEXaXIf3nl3Owmog9cFUza8xqw0PiCMMu2E+D+rVWedtjSLOoEm1bCjczHFQKbNDjg== X-Received: by 2002:a5d:5486:: with SMTP id h6mr2369084wrv.415.1598972695129; Tue, 01 Sep 2020 08:04:55 -0700 (PDT) Received: from [192.168.0.19] (87-231-62-161.rev.numericable.fr. [87.231.62.161]) by smtp.gmail.com with ESMTPSA id c18sm2670580wrx.63.2020.09.01.08.04.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Sep 2020 08:04:54 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: [PATCH] Update ruby_version requirement to allow ruby 3.0 From: Jean Boussier In-Reply-To: <20200901144829.GA8068@dcvr> Date: Tue, 1 Sep 2020 17:04:53 +0200 Cc: unicorn-public@yhbt.net Content-Transfer-Encoding: quoted-printable Message-Id: References: <03DE8105-749D-46E8-A163-3AAEA72E6087@shopify.com> <20200901144829.GA8068@dcvr> To: Eric Wong X-Mailer: Apple Mail (2.3608.120.23.2.1) List-Id: >> I don't really see any reason to protect against newer Ruby version. >=20 > I do: Ruby does not have a good track record when it comes to > maintaining backwards compatibility. Regardless, preventing the gem installation before the version even = exists cause massive pains to people trying to do the good thing of testing = their app against ruby master. Until it is known that compatibility is broken, restricting the ruby = version causes more harm than good. Just this morning I had to submit patches to a dozen gems. > Hint: you can make maintainers' life slightly easier by adding > a "--8<--\n" line before the patch, so "git am --scissors" works :> > (the "=46rom " line is also unnecessary) Apologies, I forgot that one. I included a new version of the patch using `< 4.0`. --=20 =46rom 307ea35d87c6a45d8b4261f03793a7a74d885bb2 Mon Sep 17 00:00:00 2001 From: Jean Boussier Date: Tue, 1 Sep 2020 17:00:12 +0200 Subject: [PATCH] Update ruby_version requirement to allow ruby 3.0 Ruby just recently bump the master version to 3.0. This requirement bump is necessary to test unicorn against ruby master. --- unicorn.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/unicorn.gemspec b/unicorn.gemspec index cbe855d..f04a11b 100644 --- a/unicorn.gemspec +++ b/unicorn.gemspec @@ -28,7 +28,7 @@ # technically we need ">=3D 1.9.3", too, but avoid the array here = since # old rubygems versions (1.8.23.2 at least) do not support multiple # version requirements here. - s.required_ruby_version =3D '< 3.0' + s.required_ruby_version =3D '< 4.0' =20 # We do not have a hard dependency on rack, it's possible to load # things which respond to #call. HTTP status lines in responses --=20 2.26.2