From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id DAB2A1F66E for ; Mon, 7 Sep 2020 07:13:06 +0000 (UTC) Received: by mail-wr1-x433.google.com with SMTP id x14so14545700wrl.12 for ; Mon, 07 Sep 2020 00:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopify.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=lOLT9BA/Iqm7ST7lnVHp2JyLJs0jqaZYcBbOl3+LYeg=; b=WCG3jWTttwzX66yc6dL1I4PSpgDiwgDW0UTX15Yg4HzcbxBr/QODKjminTi0M5CPZf TJ4AUJbywfCX28xoH6ckPjZL+aBr/fK4heDxSeD6XT04P0qdYqm+nN/QEWQoIVaNokwE JrZW8xXwO2v76vvtwKXPPvMFL0AABgBugwyfs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=lOLT9BA/Iqm7ST7lnVHp2JyLJs0jqaZYcBbOl3+LYeg=; b=JrXbvWGGnjO9KOR4IiwqjpecZuvV4G5hPmGkmLRTrwcMB8q8Sr/KsIgpCugYIke23z uS1WMxGNmgRy7EO2W9vhZKGXBzv6slrY3NzkiWb2VOUtVqGA923w/BCrrcl3I3iaMEwl 1WQxewzk7gpeGI4ey49jGSDJwJcvBQYrkcP1qnQk++fGfTtmI75uqQsEIVbAM+w0YHDo F8zLsbLX2KB4wUgp6fDkbTK1IHJmG41JEZt88qHv0az8n5COYUsIJZMInyBt3mJU0hkV +1P9P4hLIacBVBXHQ2prN5nWALJC3wvuw9JJaQ4nlJR6pRGhtRxh/GmTknyXOZ9vFOtl vfEQ== X-Gm-Message-State: AOAM5308a6y0mirm7dt2vqO7qXLHMoeFqREbHppWakeSGjH5V/7YeFJq CNpUwb5QcJzU2V3SnJZGPHVqcQ== X-Google-Smtp-Source: ABdhPJw4d1wFyJPV4nlyt6CChawxHW8k8WmMLx2P8fuwVvTnfH5Aly4z7d/V3m5JaPLHLzsXjvCi8A== X-Received: by 2002:a5d:67c2:: with SMTP id n2mr19113556wrw.4.1599462784523; Mon, 07 Sep 2020 00:13:04 -0700 (PDT) Received: from [192.168.0.19] (87-231-62-161.rev.numericable.fr. [87.231.62.161]) by smtp.gmail.com with ESMTPSA id c206sm26496584wmf.47.2020.09.07.00.13.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Sep 2020 00:13:04 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: [PATCH] Update ruby_version requirement to allow ruby 3.0 From: Jean Boussier In-Reply-To: <20200906093038.GA25772@dcvr> Date: Mon, 7 Sep 2020 09:13:03 +0200 Cc: unicorn-public@yhbt.net Content-Transfer-Encoding: 7bit Message-Id: References: <03DE8105-749D-46E8-A163-3AAEA72E6087@shopify.com> <20200901144829.GA8068@dcvr> <20200901154117.GA1551@dcvr> <1301173B-0CA2-4498-9A9A-A042FEF9665A@shopify.com> <20200903082513.GA21482@dcvr> <20200903093150.GA21762@dcvr> <389E28C3-EF27-4E2D-94D0-0C8E95AA4488@shopify.com> <90FCA912-2FEF-4D7C-8DEA-0F3D25E1CBBC@shopify.com> <20200906093038.GA25772@dcvr> To: Eric Wong X-Mailer: Apple Mail (2.3608.120.23.2.1) List-Id: >> Ok, so the linking issues were simply me being silly. I forgot >> to run `make ragel` and commit the output (to use a git gem). >> Unicorn now run just fine under 3.0.0-dev (current master). > > Odd, just "make" (no args) should work. It does, but the files it generates are in .gitignore, and I was trying to use the gem through bundler's git gems. Anyway, now I know the drill. > Anything else in the ruby 3.0 pipeline that might introduce > incompatibilities? Not that I know of. There not any big breaking change planned for 3.0. > Not sure if releasing unicorn 5.7 is worth doing soon/now or > closer to December 25... It is up to you. But the sooner the better for me. We run our master branch CI against ruby master on a nightly basis. Until this patch is released I'll have to keep a fork around.