yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH] extras/proxy_pass: save memory in String#split arg
Date: Fri,  6 Feb 2015 23:12:14 +0000	[thread overview]
Message-ID: <1423264334-14306-1-git-send-email-e@80x24.org> (raw)

This saves over 400 bytes of memory in a cold code path.
---
 extras/proxy_pass.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/extras/proxy_pass.rb b/extras/proxy_pass.rb
index e7127d3..b1697db 100644
--- a/extras/proxy_pass.rb
+++ b/extras/proxy_pass.rb
@@ -117,7 +117,7 @@ class ProxyPass # :nodoc:
     case dest
     when %r{\Ahttp://([^/]+)(/.*)\z}
       path = $2
-      host, port = $1.split(/:/)
+      host, port = $1.split(':')
       @sockaddr = Socket.sockaddr_in(port || 80, host)
 
       # methods from Rack::Request we want:
-- 
EW


                 reply	other threads:[~2015-02-06 23:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423264334-14306-1-git-send-email-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	http://yhbt.net/yahns.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).