From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: yahns-public@yhbt.net Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id DD8D4203FA for ; Tue, 13 Oct 2015 21:19:30 +0000 (UTC) From: Eric Wong To: yahns-public@yhbt.net Subject: [PATCH] update various comments Date: Tue, 13 Oct 2015 21:19:33 +0000 Message-Id: <20151013211933.888-1-e@80x24.org> List-Id: Clarify APP_CONFIG is only public for modules maintained within yahns, not external users. While we're at it, avoid the http:// -> https:// redirect for bugs.ruby-lang.org in the comment. --- lib/yahns/config.rb | 5 ++++- lib/yahns/log.rb | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/yahns/config.rb b/lib/yahns/config.rb index faae9c9..e39115c 100644 --- a/lib/yahns/config.rb +++ b/lib/yahns/config.rb @@ -6,7 +6,10 @@ # See http://yahns.yhbt.net/examples/yahns_multi.conf.rb for a full # example configuration file. class Yahns::Config # :nodoc: - APP_CLASS = {} # public, see yahns/rack for usage example + # public within yahns itself, NOT a public interface for users outside + # of yahns. See yahns/rack for usage example + APP_CLASS = {} + CfgBlock = Struct.new(:type, :ctx) # :nodoc: attr_reader :config_file, :config_listeners, :set attr_reader :qeggs, :app_ctx diff --git a/lib/yahns/log.rb b/lib/yahns/log.rb index a03c973..b8015c4 100644 --- a/lib/yahns/log.rb +++ b/lib/yahns/log.rb @@ -66,7 +66,7 @@ def self.reopen_all # MRI will use freopen(3) here internally on std{in,out,err} fp.reopen(fp.path, "a") else - # We should not need this: http://bugs.ruby-lang.org/issues/9036 + # We should not need this: https://bugs.ruby-lang.org/issues/9036 # MRI will not call call fclose(3) or freopen(3) here # since there's no associated std{in,out,err} FILE * pointer # This should atomically use dup3(2) (or dup2(2)) syscall -- EW