* [PATCH] http_client: clear backtrace on "wrong version number" in OpenSSL
@ 2018-07-08 7:35 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2018-07-08 7:35 UTC (permalink / raw)
To: yahns-public
Errors which are the fault of the client should not generate
backtraces which can lead to dinky servers running out-of-space.
---
lib/yahns/http_client.rb | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/lib/yahns/http_client.rb b/lib/yahns/http_client.rb
index d8154a4..fd97624 100644
--- a/lib/yahns/http_client.rb
+++ b/lib/yahns/http_client.rb
@@ -298,10 +298,18 @@ def handle_error(e)
when Unicorn::HttpParserError # try to tell the client they're bad
400
else
+ n = 500
+ case e.class.to_s
+ when 'OpenSSL::SSL::SSLError'
+ if e.message.include?('wrong version number')
+ n = nil
+ e.set_backtrace([])
+ end
+ end
Yahns::Log.exception(@hs.env["rack.logger"], "app error", e)
- 500
+ n
end
- kgio_trywrite(err_response(code))
+ kgio_trywrite(err_response(code)) if code
rescue
ensure
shutdown rescue nil
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-07-08 7:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-08 7:35 [PATCH] http_client: clear backtrace on "wrong version number" in OpenSSL Eric Wong
Code repositories for project(s) associated with this public inbox
http://yhbt.net/yahns.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).