From: Eric Wong <e@80x24.org>
To: clogger-public@bogomips.org
Subject: [PATCH 2/2] pure: use monotonic clock if possible
Date: Fri, 27 Feb 2015 22:45:07 +0000 [thread overview]
Message-ID: <1425077107-25270-3-git-send-email-e@80x24.org> (raw)
In-Reply-To: <1425077107-25270-1-git-send-email-e@80x24.org>
Ruby 2.1.0 and later exposes Process.clock_gettime, resulting
in less garbage and access to the monotonic clock if it is
available. Try to use it to achieve feature parity with the
C extension (which has always used the monotonic clock if possible).
---
lib/clogger/pure.rb | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/lib/clogger/pure.rb b/lib/clogger/pure.rb
index 9efb00c..5e7ccfe 100644
--- a/lib/clogger/pure.rb
+++ b/lib/clogger/pure.rb
@@ -28,7 +28,7 @@ def initialize(app, opts = {})
end
def call(env)
- start = Time.now
+ start = mono_now
resp = @app.call(env)
unless resp.instance_of?(Array) && resp.size == 3
log(env, 500, {}, start)
@@ -165,7 +165,7 @@ def log(env, status, headers, start = @start)
when OP_TIME_LOCAL; Time.now.strftime(op[1])
when OP_TIME_UTC; Time.now.utc.strftime(op[1])
when OP_REQUEST_TIME
- t = Time.now - start
+ t = mono_now - start
time_format(t.to_i, (t - t.to_i) * 1000000, op[1], op[2])
when OP_TIME
t = Time.now
@@ -185,4 +185,14 @@ def log(env, status, headers, start = @start)
end
nil
end
+
+ # favor monotonic clock if possible, and try to use clock_gettime in
+ # more recent Rubies since it generates less garbage
+ if defined?(Process::CLOCK_MONOTONIC)
+ def mono_now; Process.clock_gettime(Process::CLOCK_MONOTONIC); end
+ elsif defined?(Process::CLOCK_REALTIME)
+ def mono_now; Process.clock_gettime(Process::CLOCK_REALTIME); end
+ else
+ def mono_now; Time.now.to_f; end
+ end
end
--
EW
prev parent reply other threads:[~2015-02-27 22:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 22:45 [PATCH 0/2] fixes for pure-Ruby users Eric Wong
2015-02-27 22:45 ` [PATCH 1/2] pure: fix reentrancy of request_time Eric Wong
2015-02-27 22:45 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/clogger/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425077107-25270-3-git-send-email-e@80x24.org \
--to=e@80x24.org \
--cc=clogger-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/clogger.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).