From: Eric Wong <e@80x24.org>
To: clogger-public@bogomips.org
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH] clogger.c: comment to explain the lack of GC guard
Date: Tue, 17 Jan 2017 19:22:41 +0000
Message-ID: <20170117192241.22814-1-e@80x24.org> (raw)
If I (the person who wrote this) spent a minute figuring out why
it wasn't needed, somebody else might, too. Save someone else
a minute.
---
ext/clogger_ext/clogger.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ext/clogger_ext/clogger.c b/ext/clogger_ext/clogger.c
index f29cf26..83ce76a 100644
--- a/ext/clogger_ext/clogger.c
+++ b/ext/clogger_ext/clogger.c
@@ -682,6 +682,7 @@ static VALUE cwrite(struct clogger *c)
if (c->fd >= 0) {
write_full(c->fd, RSTRING_PTR(dst), RSTRING_LEN(dst));
+ /* no need for RB_GC_GUARD(dst) here, marked as c->log_buf */
} else {
VALUE logger = c->logger;
--
EW
reply other threads:[~2017-01-17 19:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/clogger/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117192241.22814-1-e@80x24.org \
--to=e@80x24.org \
--cc=clogger-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
clogger RubyGem user+dev discussion/patches/pulls/bugs/help
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://yhbt.net/clogger-public
git clone --mirror http://ou63pmih66umazou.onion/clogger-public
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V1 clogger-public clogger-public/ https://yhbt.net/clogger-public \
clogger-public@yhbt.net clogger-public@bogomips.org clogger@librelist.org clogger@librelist.com
public-inbox-index clogger-public
Example config snippet for mirrors.
Newsgroups are available over NNTP:
nntp://news.public-inbox.org/inbox.comp.lang.ruby.clogger
nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.clogger
note: .onion URLs require Tor: https://www.torproject.org/
code repositories for the project(s) associated with this inbox:
../../clogger.git
AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git