Re: Clogger request_time formatting

[Eric Wong <e@yhbt.net>]

Josh Natanson <josh@natanson.net> wrote:
> Thanks.  I had some time to work on this, and I'm a little stuck.  The
> changes I've made are working as expected (both new syntax & legacy)
> when frozen into a test rails application. I've written a test for the
> new syntax, but I'm not getting the same behavior there - it looks to
> behave the same as the legacy option.  I can't see why the same code
> would behave differently in an app vs. the test, and I'm having some
> challenges getting useful debug out of the code in test.  I'm sure I'm
> just unfamiliar with something about the gem's layout, but maybe you
> have some ideas?

Ah, you're aware there's both a C extension and pure-Ruby
implementation in the same tree, right?

I only see changes to the pure-Ruby code.  Btw, I can help with
the C stuff, too, if you're not a C hacker.

Perhaps setting CLOGGER_PURE=1 lets your app work as expected?

The very short GNUmakefile has two targets for testing these
independently:

	make test-ext
	make test-pure
	# (or gmake if you're on *BSD)

> Here's the changes so far.  Don't mind the names, I'm planning to come
> up with something better before submitting.

All the rest seemed fine to me :>

Btw, please don't top-post and trim quotes.  Mostly old school
Usenet conventions, though when in doubt, I don't think quoting
is necessary at all with reliable archives, nowadays.  (it saves
storage + bandwidth for all)

Thanks.