clogger RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <>
To: Josh Natanson <>
Subject: Re: Clogger request_time formatting
Date: Wed, 29 Jul 2020 09:20:23 +0000	[thread overview]
Message-ID: <20200729092023.GA24100@dcvr> (raw)
In-Reply-To: <>

Josh Natanson <> wrote:
> Thanks.  I had some time to work on this, and I'm a little stuck.  The
> changes I've made are working as expected (both new syntax & legacy)
> when frozen into a test rails application. I've written a test for the
> new syntax, but I'm not getting the same behavior there - it looks to
> behave the same as the legacy option.  I can't see why the same code
> would behave differently in an app vs. the test, and I'm having some
> challenges getting useful debug out of the code in test.  I'm sure I'm
> just unfamiliar with something about the gem's layout, but maybe you
> have some ideas?

Ah, you're aware there's both a C extension and pure-Ruby
implementation in the same tree, right?

I only see changes to the pure-Ruby code.  Btw, I can help with
the C stuff, too, if you're not a C hacker.

Perhaps setting CLOGGER_PURE=1 lets your app work as expected?

The very short GNUmakefile has two targets for testing these

	make test-ext
	make test-pure
	# (or gmake if you're on *BSD)

> Here's the changes so far.  Don't mind the names, I'm planning to come
> up with something better before submitting.

All the rest seemed fine to me :>

Btw, please don't top-post and trim quotes.  Mostly old school
Usenet conventions, though when in doubt, I don't think quoting
is necessary at all with reliable archives, nowadays.  (it saves
storage + bandwidth for all)


  reply	other threads:[~2020-07-29  9:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-09 16:30 Clogger request_time formatting Josh Natanson
2020-07-09 20:28 ` Eric Wong
     [not found]   ` <>
2020-07-09 22:57     ` Eric Wong
2020-07-26  4:46 ` Eric Wong
2020-07-27 15:15   ` Josh Natanson
2020-07-27 18:38     ` Eric Wong
2020-07-28 13:50       ` Josh Natanson
2020-07-29  9:20         ` Eric Wong [this message]
2020-07-29 19:50           ` Josh Natanson
2020-07-30  3:54             ` Eric Wong
2020-07-31 14:08               ` Josh Natanson
2020-07-31 14:09                 ` Josh Natanson
2020-07-31 19:44                 ` Eric Wong
2020-08-02 13:47                   ` Josh Natanson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200729092023.GA24100@dcvr \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).